RefsWidget.remove_ref() - Code Metrics - Inspection of "Implement references editor" - FreeOpcUa/opcua-widgets - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( fb14b4...0d6791 )

by Olivier

created 2017-05-20 07:41 UTC

RefsWidget.remove_ref() A

↳ Parent: RefsWidget

Complexity

Conditions

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	10
rs	9.4285
cc	2

import logging
from copy import copy

from PyQt5.QtCore import pyqtSignal, QObject, QSettings, Qt
from PyQt5.QtGui import QStandardItemModel, QStandardItem
from PyQt5.QtWidgets import QMenu, QAction, QStyledItemDelegate, QAbstractItemView

from opcua import ua, Node

from uawidgets.utils import trycatchslot
from uawidgets.get_node_dialog import GetNodeButton


logger = logging.getLogger(__name__)


class RefsWidget(QObject):

    error = pyqtSignal(Exception)
    reference_changed = pyqtSignal(ua.NodeId)

    def __init__(self, view):
        self.view = view
        QObject.__init__(self, view)
        self.model = QStandardItemModel()

        delegate = MyDelegate(self.view, self)
        delegate.error.connect(self.error.emit)
        delegate.reference_changed.connect(self.reference_changed.emit)
        self.view.setEditTriggers(QAbstractItemView.DoubleClicked)
        self.view.setModel(self.model)
        self.view.setItemDelegate(delegate)
        self.settings = QSettings()
        self.model.setHorizontalHeaderLabels(['ReferenceType', 'NodeId', "BrowseName", "TypeDefinition"])
        self.view.horizontalHeader().setSectionResizeMode(0)
        self.view.horizontalHeader().setStretchLastSection(True)
        state = self.settings.value("refs_widget", None)
        self.node = None
        if state is not None:
            self.view.horizontalHeader().restoreState(state)

        self.reloadAction = QAction("Reload", self.model)
        self.reloadAction.triggered.connect(self.reload)
        self.addRefAction = QAction("Add Reference", self.model)
        self.addRefAction.triggered.connect(self.add_ref)
        self.removeRefAction = QAction("Remove Reference", self.model)
        self.removeRefAction.triggered.connect(self.remove_ref)

        self.view.setContextMenuPolicy(Qt.CustomContextMenu)
        self.view.customContextMenuRequested.connect(self.showContextMenu)
        self._contextMenu = QMenu()
        self._contextMenu.addAction(self.reloadAction)
        self._contextMenu.addSeparator()
        self._contextMenu.addAction(self.addRefAction)
        self._contextMenu.addAction(self.removeRefAction)

    def showContextMenu(self, position):
        if not self.node:
            return
        self.removeRefAction.setEnabled(False)
        idx = self.view.currentIndex()
        if idx.isValid():
            self.removeRefAction.setEnabled(True)
        self._contextMenu.exec_(self.view.viewport().mapToGlobal(position))

    def clear(self):
        # remove all rows but not header!!
        self.model.removeRows(0, self.model.rowCount())
        self.node = None

    def _make_default_ref(self):
        #FIXME: remeber last choosen values or use values that make sense
        ref = ua.ReferenceDescription()
        return ref

    @trycatchslot
    def add_ref(self):
        ref = self._make_default_ref()
        logger.info("Adding ref: %s", ref)
        self._add_ref_row(ref)
        idx = self.model.index(self.model.rowCount() - 1, 0)
        self.view.setCurrentIndex(idx)
        #self.view.edit(idx)

    @trycatchslot
    def reload(self):
        node = self.node
        self.clear()
        self.show_refs(node)

    @trycatchslot
    def remove_ref(self):
        idx = self.view.currentIndex()
        if not idx.isValid():
            logger.warning("No valid reference selected to remove")
        idx = idx.sibling(idx.row(), 0)
        item = self.model.itemFromIndex(idx)
        ref = item.data(Qt.UserRole)
        self.do_remove_ref(ref)
        self.reload()
    
    def do_remove_ref(self, ref, check=True):

        logger.info("Removing: %s", ref)
        it = ua.DeleteReferencesItem()
        it.SourceNodeId = self.node.nodeid
        it.ReferenceTypeId = ref.ReferenceTypeId
        it.IsForward = ref.IsForward
        it.TargetNodeId = ref.NodeId
        it.DeleteBidirectional = False
        #param = ua.DeleteReferencesParameters()
        #param.ReferencesToDelete.append(it)
        results = self.node.server.delete_references([it])
        logger.info("Remove result: %s", results[0]) 
        if check:
            results[0].check()

    def save_state(self):
        self.settings.setValue("refs_widget", self.view.horizontalHeader().saveState())

    def show_refs(self, node):
        self.clear()
        self.node = node
        self._show_refs(node)

    def _show_refs(self, node):
        try:
            refs = node.get_children_descriptions(refs=ua.ObjectIds.References)
        except Exception as ex:
            self.error.emit(ex)
            raise
        for ref in refs:
            self._add_ref_row(ref)

    def _add_ref_row(self, ref):
        typename = ua.ObjectIdNames[ref.ReferenceTypeId.Identifier]
        if ref.NodeId.NamespaceIndex == 0 and ref.NodeId.Identifier in ua.ObjectIdNames:
            nodeid = ua.ObjectIdNames[ref.NodeId.Identifier]
        else:
            nodeid = ref.NodeId.to_string()
        if ref.TypeDefinition.Identifier in ua.ObjectIdNames:
            typedef = ua.ObjectIdNames[ref.TypeDefinition.Identifier]
        else:
            typedef = ref.TypeDefinition.to_string()
        titem = QStandardItem(typename)
        titem.setData(ref, Qt.UserRole)
        self.model.appendRow([
            titem,
            QStandardItem(nodeid),
            QStandardItem(ref.BrowseName.to_string()),
            QStandardItem(typedef)
        ])


class MyDelegate(QStyledItemDelegate):

    error = pyqtSignal(Exception)
    reference_changed = pyqtSignal(ua.NodeId)

    def __init__(self, parent, widget):
        QStyledItemDelegate.__init__(self, parent)
        self._widget = widget

    @trycatchslot
    def createEditor(self, parent, option, idx):
        print("CREATE EDITOR", parent, option, idx)
        if idx.column() > 1:
            return None
        data_idx = idx.sibling(idx.row(), 0)
        item = self._widget.model.itemFromIndex(data_idx)
        ref = item.data(Qt.UserRole)
        if idx.column() == 1:
            node = Node(self._widget.node.server, ref.NodeId)
            startnode = Node(self._widget.node.server, ua.ObjectIds.RootFolder)
            button = GetNodeButton(parent, node, startnode)
            return button
        elif idx.column() == 0:
            node = Node(self._widget.node.server, ref.ReferenceTypeId)
            startnode = Node(self._widget.node.server, ua.ObjectIds.ReferenceTypesFolder)
            button = GetNodeButton(parent, node, startnode)
            return button

    @trycatchslot
    def setModelData(self, editor, model, idx):
        data_idx = idx.sibling(idx.row(), 0)
        ref = model.data(data_idx, Qt.UserRole)
        self._widget.do_remove_ref(ref, check=False)
        if idx.column() == 0:
            ref.ReferenceTypeId = editor.current_node.nodeid
            model.setData(idx, ref.ReferenceTypeId.to_string(), Qt.DisplayRole)
        elif idx.column() == 1:
            ref.NodeId = editor.current_node.nodeid
            ref.NodeClass = editor.current_node.get_node_class()
            model.setData(idx, ref.NodeId.to_string(), Qt.DisplayRole)
        model.setData(data_idx, ref, Qt.UserRole)
        if ref.NodeId.is_null() or ref.ReferenceTypeId.is_null():
            logger.info("Do not save yet. Need NodeId and ReferenceTypeId to be set")
            return
        self._write_ref(ref)

    def _write_ref(self, ref):

        logger.info("Writing ref %s", ref)
        it = ua.AddReferencesItem()
        it.SourceNodeId = self._widget.node.nodeid
        it.ReferenceTypeId = ref.ReferenceTypeId
        it.IsForward = ref.IsForward
        it.TargetNodeId = ref.NodeId
        it.TargetNodeClass = ref.NodeClass

        results = self._widget.node.server.add_references([it])
        results[0].check()

        self._widget.reload()






1		import logging
2		from copy import copy
3
4		from PyQt5.QtCore import pyqtSignal, QObject, QSettings, Qt
5		from PyQt5.QtGui import QStandardItemModel, QStandardItem
6		from PyQt5.QtWidgets import QMenu, QAction, QStyledItemDelegate, QAbstractItemView
7
8		from opcua import ua, Node
9
10		from uawidgets.utils import trycatchslot
11		from uawidgets.get_node_dialog import GetNodeButton
12
13
14		logger = logging.getLogger(__name__)
15
16
17		class RefsWidget(QObject):
18
19		error = pyqtSignal(Exception)
20		reference_changed = pyqtSignal(ua.NodeId)
21
22		def __init__(self, view):
23		self.view = view
24		QObject.__init__(self, view)
25		self.model = QStandardItemModel()
26
27		delegate = MyDelegate(self.view, self)
28		delegate.error.connect(self.error.emit)
29		delegate.reference_changed.connect(self.reference_changed.emit)
30		self.view.setEditTriggers(QAbstractItemView.DoubleClicked)
31		self.view.setModel(self.model)
32		self.view.setItemDelegate(delegate)
33		self.settings = QSettings()
34		self.model.setHorizontalHeaderLabels(['ReferenceType', 'NodeId', "BrowseName", "TypeDefinition"])
35		self.view.horizontalHeader().setSectionResizeMode(0)
36		self.view.horizontalHeader().setStretchLastSection(True)
37		state = self.settings.value("refs_widget", None)
38		self.node = None
39		if state is not None:
40		self.view.horizontalHeader().restoreState(state)
41
42		self.reloadAction = QAction("Reload", self.model)
43		self.reloadAction.triggered.connect(self.reload)
44		self.addRefAction = QAction("Add Reference", self.model)
45		self.addRefAction.triggered.connect(self.add_ref)
46		self.removeRefAction = QAction("Remove Reference", self.model)
47		self.removeRefAction.triggered.connect(self.remove_ref)
48
49		self.view.setContextMenuPolicy(Qt.CustomContextMenu)
50		self.view.customContextMenuRequested.connect(self.showContextMenu)
51		self._contextMenu = QMenu()
52		self._contextMenu.addAction(self.reloadAction)
53		self._contextMenu.addSeparator()
54		self._contextMenu.addAction(self.addRefAction)
55		self._contextMenu.addAction(self.removeRefAction)
56
57		def showContextMenu(self, position):
58		if not self.node:
59		return
60		self.removeRefAction.setEnabled(False)
61		idx = self.view.currentIndex()
62		if idx.isValid():
63		self.removeRefAction.setEnabled(True)
64		self._contextMenu.exec_(self.view.viewport().mapToGlobal(position))
65
66		def clear(self):
67		# remove all rows but not header!!
68		self.model.removeRows(0, self.model.rowCount())
69		self.node = None
70
71		def _make_default_ref(self):
72		#FIXME: remeber last choosen values or use values that make sense
73		ref = ua.ReferenceDescription()
74		return ref
75
76		@trycatchslot
77		def add_ref(self):
78		ref = self._make_default_ref()
79		logger.info("Adding ref: %s", ref)
80		self._add_ref_row(ref)
81		idx = self.model.index(self.model.rowCount() - 1, 0)
82		self.view.setCurrentIndex(idx)
83		#self.view.edit(idx)
84
85		@trycatchslot
86		def reload(self):
87		node = self.node
88		self.clear()
89		self.show_refs(node)
90
91		@trycatchslot
92		def remove_ref(self):
93		idx = self.view.currentIndex()
94		if not idx.isValid():
95		logger.warning("No valid reference selected to remove")
96		idx = idx.sibling(idx.row(), 0)
97		item = self.model.itemFromIndex(idx)
98		ref = item.data(Qt.UserRole)
99		self.do_remove_ref(ref)
100		self.reload()
101
102	View Code Duplication	def do_remove_ref(self, ref, check=True):
		0 ignored issues – show Duplication introduced 2017-05-20 07:29 UTC by Report Bug Copy Issue Report This code seems to be duplicated in your project. Loading history...
103		logger.info("Removing: %s", ref)
104		it = ua.DeleteReferencesItem()
105		it.SourceNodeId = self.node.nodeid
106		it.ReferenceTypeId = ref.ReferenceTypeId
107		it.IsForward = ref.IsForward
108		it.TargetNodeId = ref.NodeId
109		it.DeleteBidirectional = False
110		#param = ua.DeleteReferencesParameters()
111		#param.ReferencesToDelete.append(it)
112		results = self.node.server.delete_references([it])
113		logger.info("Remove result: %s", results[0])
114		if check:
115		results[0].check()
116
117		def save_state(self):
118		self.settings.setValue("refs_widget", self.view.horizontalHeader().saveState())
119
120		def show_refs(self, node):
121		self.clear()
122		self.node = node
123		self._show_refs(node)
124
125		def _show_refs(self, node):
126		try:
127		refs = node.get_children_descriptions(refs=ua.ObjectIds.References)
128		except Exception as ex:
129		self.error.emit(ex)
130		raise
131		for ref in refs:
132		self._add_ref_row(ref)
133
134		def _add_ref_row(self, ref):
135		typename = ua.ObjectIdNames[ref.ReferenceTypeId.Identifier]
136		if ref.NodeId.NamespaceIndex == 0 and ref.NodeId.Identifier in ua.ObjectIdNames:
137		nodeid = ua.ObjectIdNames[ref.NodeId.Identifier]
138		else:
139		nodeid = ref.NodeId.to_string()
140		if ref.TypeDefinition.Identifier in ua.ObjectIdNames:
141		typedef = ua.ObjectIdNames[ref.TypeDefinition.Identifier]
142		else:
143		typedef = ref.TypeDefinition.to_string()
144		titem = QStandardItem(typename)
145		titem.setData(ref, Qt.UserRole)
146		self.model.appendRow([
147		titem,
148		QStandardItem(nodeid),
149		QStandardItem(ref.BrowseName.to_string()),
150		QStandardItem(typedef)
151		])
152
153
154		class MyDelegate(QStyledItemDelegate):
155
156		error = pyqtSignal(Exception)
157		reference_changed = pyqtSignal(ua.NodeId)
158
159		def __init__(self, parent, widget):
160		QStyledItemDelegate.__init__(self, parent)
161		self._widget = widget
162
163		@trycatchslot
164		def createEditor(self, parent, option, idx):
165		print("CREATE EDITOR", parent, option, idx)
166		if idx.column() > 1:
167		return None
168		data_idx = idx.sibling(idx.row(), 0)
169		item = self._widget.model.itemFromIndex(data_idx)
170		ref = item.data(Qt.UserRole)
171		if idx.column() == 1:
172		node = Node(self._widget.node.server, ref.NodeId)
173		startnode = Node(self._widget.node.server, ua.ObjectIds.RootFolder)
174		button = GetNodeButton(parent, node, startnode)
175		return button
176		elif idx.column() == 0:
177		node = Node(self._widget.node.server, ref.ReferenceTypeId)
178		startnode = Node(self._widget.node.server, ua.ObjectIds.ReferenceTypesFolder)
179		button = GetNodeButton(parent, node, startnode)
180		return button
181
182		@trycatchslot
183		def setModelData(self, editor, model, idx):
184		data_idx = idx.sibling(idx.row(), 0)
185		ref = model.data(data_idx, Qt.UserRole)
186		self._widget.do_remove_ref(ref, check=False)
187		if idx.column() == 0:
188		ref.ReferenceTypeId = editor.current_node.nodeid
189		model.setData(idx, ref.ReferenceTypeId.to_string(), Qt.DisplayRole)
190		elif idx.column() == 1:
191		ref.NodeId = editor.current_node.nodeid
192		ref.NodeClass = editor.current_node.get_node_class()
193		model.setData(idx, ref.NodeId.to_string(), Qt.DisplayRole)
194		model.setData(data_idx, ref, Qt.UserRole)
195		if ref.NodeId.is_null() or ref.ReferenceTypeId.is_null():
196		logger.info("Do not save yet. Need NodeId and ReferenceTypeId to be set")
197		return
198		self._write_ref(ref)
199
200	View Code Duplication	def _write_ref(self, ref):
		0 ignored issues – show Duplication introduced 2017-05-20 07:29 UTC by Report Bug Copy Issue Report This code seems to be duplicated in your project. Loading history...
201		logger.info("Writing ref %s", ref)
202		it = ua.AddReferencesItem()
203		it.SourceNodeId = self._widget.node.nodeid
204		it.ReferenceTypeId = ref.ReferenceTypeId
205		it.IsForward = ref.IsForward
206		it.TargetNodeId = ref.NodeId
207		it.TargetNodeClass = ref.NodeClass
208
209		results = self._widget.node.server.add_references([it])
210		results[0].check()
211
212		self._widget.reload()
213
214
215
216
217

FreeOpcUa / opcua-widgets

Push — master ( fb14b4...0d6791 )

RefsWidget.remove_ref() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like