FreeOpcUa /
opcua-client-gui
| Conditions | 1 |
| Total Lines | 211 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 2 | ||
| Bugs | 1 | Features | 1 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | # -*- coding: utf-8 -*- |
||
| 12 | def setupUi(self, MainWindow): |
||
| 13 | MainWindow.setObjectName("MainWindow") |
||
| 14 | MainWindow.resize(922, 692) |
||
| 15 | icon = QtGui.QIcon() |
||
| 16 | icon.addPixmap(QtGui.QPixmap("../network.svg"), QtGui.QIcon.Normal, QtGui.QIcon.Off) |
||
| 17 | MainWindow.setWindowIcon(icon) |
||
| 18 | self.centralWidget = QtWidgets.QWidget(MainWindow) |
||
| 19 | self.centralWidget.setObjectName("centralWidget") |
||
| 20 | self.gridLayout_2 = QtWidgets.QGridLayout(self.centralWidget) |
||
| 21 | self.gridLayout_2.setContentsMargins(11, 11, 11, 11) |
||
| 22 | self.gridLayout_2.setSpacing(6) |
||
| 23 | self.gridLayout_2.setObjectName("gridLayout_2") |
||
| 24 | self.splitter = QtWidgets.QSplitter(self.centralWidget) |
||
| 25 | sizePolicy = QtWidgets.QSizePolicy(QtWidgets.QSizePolicy.Preferred, QtWidgets.QSizePolicy.Preferred) |
||
| 26 | sizePolicy.setHorizontalStretch(0) |
||
| 27 | sizePolicy.setVerticalStretch(0) |
||
| 28 | sizePolicy.setHeightForWidth(self.splitter.sizePolicy().hasHeightForWidth()) |
||
| 29 | self.splitter.setSizePolicy(sizePolicy) |
||
| 30 | self.splitter.setOrientation(QtCore.Qt.Horizontal) |
||
| 31 | self.splitter.setObjectName("splitter") |
||
| 32 | self.treeView = QtWidgets.QTreeView(self.splitter) |
||
| 33 | sizePolicy = QtWidgets.QSizePolicy(QtWidgets.QSizePolicy.Fixed, QtWidgets.QSizePolicy.Expanding) |
||
| 34 | sizePolicy.setHorizontalStretch(0) |
||
| 35 | sizePolicy.setVerticalStretch(0) |
||
| 36 | sizePolicy.setHeightForWidth(self.treeView.sizePolicy().hasHeightForWidth()) |
||
| 37 | self.treeView.setSizePolicy(sizePolicy) |
||
| 38 | self.treeView.setContextMenuPolicy(QtCore.Qt.ActionsContextMenu) |
||
| 39 | self.treeView.setEditTriggers(QtWidgets.QAbstractItemView.NoEditTriggers) |
||
| 40 | self.treeView.setDragEnabled(True) |
||
| 41 | self.treeView.setDragDropMode(QtWidgets.QAbstractItemView.DragOnly) |
||
| 42 | self.treeView.setObjectName("treeView") |
||
| 43 | self.gridLayout_2.addWidget(self.splitter, 0, 0, 1, 1) |
||
| 44 | MainWindow.setCentralWidget(self.centralWidget) |
||
| 45 | self.menuBar = QtWidgets.QMenuBar(MainWindow) |
||
| 46 | self.menuBar.setGeometry(QtCore.QRect(0, 0, 922, 26)) |
||
| 47 | self.menuBar.setObjectName("menuBar") |
||
| 48 | self.menuOPC_UA_Client = QtWidgets.QMenu(self.menuBar) |
||
| 49 | self.menuOPC_UA_Client.setObjectName("menuOPC_UA_Client") |
||
| 50 | MainWindow.setMenuBar(self.menuBar) |
||
| 51 | self.statusBar = QtWidgets.QStatusBar(MainWindow) |
||
| 52 | self.statusBar.setObjectName("statusBar") |
||
| 53 | MainWindow.setStatusBar(self.statusBar) |
||
| 54 | self.attrDockWidget = QtWidgets.QDockWidget(MainWindow) |
||
| 55 | sizePolicy = QtWidgets.QSizePolicy(QtWidgets.QSizePolicy.Expanding, QtWidgets.QSizePolicy.Preferred) |
||
| 56 | sizePolicy.setHorizontalStretch(0) |
||
| 57 | sizePolicy.setVerticalStretch(0) |
||
| 58 | sizePolicy.setHeightForWidth(self.attrDockWidget.sizePolicy().hasHeightForWidth()) |
||
| 59 | self.attrDockWidget.setSizePolicy(sizePolicy) |
||
| 60 | self.attrDockWidget.setMinimumSize(QtCore.QSize(400, 156)) |
||
| 61 | self.attrDockWidget.setObjectName("attrDockWidget") |
||
| 62 | self.dockWidgetContents = QtWidgets.QWidget() |
||
| 63 | sizePolicy = QtWidgets.QSizePolicy(QtWidgets.QSizePolicy.Expanding, QtWidgets.QSizePolicy.Preferred) |
||
| 64 | sizePolicy.setHorizontalStretch(0) |
||
| 65 | sizePolicy.setVerticalStretch(0) |
||
| 66 | sizePolicy.setHeightForWidth(self.dockWidgetContents.sizePolicy().hasHeightForWidth()) |
||
| 67 | self.dockWidgetContents.setSizePolicy(sizePolicy) |
||
| 68 | self.dockWidgetContents.setMinimumSize(QtCore.QSize(100, 0)) |
||
| 69 | self.dockWidgetContents.setObjectName("dockWidgetContents") |
||
| 70 | self.gridLayout_4 = QtWidgets.QGridLayout(self.dockWidgetContents) |
||
| 71 | self.gridLayout_4.setContentsMargins(11, 11, 11, 11) |
||
| 72 | self.gridLayout_4.setSpacing(6) |
||
| 73 | self.gridLayout_4.setObjectName("gridLayout_4") |
||
| 74 | self.attrView = QtWidgets.QTreeView(self.dockWidgetContents) |
||
| 75 | self.attrView.setSizeAdjustPolicy(QtWidgets.QAbstractScrollArea.AdjustToContents) |
||
| 76 | self.attrView.setEditTriggers(QtWidgets.QAbstractItemView.NoEditTriggers) |
||
| 77 | self.attrView.setObjectName("attrView") |
||
| 78 | self.gridLayout_4.addWidget(self.attrView, 0, 0, 1, 2) |
||
| 79 | spacerItem = QtWidgets.QSpacerItem(40, 20, QtWidgets.QSizePolicy.Expanding, QtWidgets.QSizePolicy.Minimum) |
||
| 80 | self.gridLayout_4.addItem(spacerItem, 1, 0, 1, 1) |
||
| 81 | self.attrRefreshButton = QtWidgets.QPushButton(self.dockWidgetContents) |
||
| 82 | self.attrRefreshButton.setObjectName("attrRefreshButton") |
||
| 83 | self.gridLayout_4.addWidget(self.attrRefreshButton, 1, 1, 1, 1) |
||
| 84 | self.attrDockWidget.setWidget(self.dockWidgetContents) |
||
| 85 | MainWindow.addDockWidget(QtCore.Qt.DockWidgetArea(2), self.attrDockWidget) |
||
| 86 | self.addrDockWidget = QtWidgets.QDockWidget(MainWindow) |
||
| 87 | sizePolicy = QtWidgets.QSizePolicy(QtWidgets.QSizePolicy.Preferred, QtWidgets.QSizePolicy.Minimum) |
||
| 88 | sizePolicy.setHorizontalStretch(0) |
||
| 89 | sizePolicy.setVerticalStretch(0) |
||
| 90 | sizePolicy.setHeightForWidth(self.addrDockWidget.sizePolicy().hasHeightForWidth()) |
||
| 91 | self.addrDockWidget.setSizePolicy(sizePolicy) |
||
| 92 | self.addrDockWidget.setFeatures(QtWidgets.QDockWidget.NoDockWidgetFeatures) |
||
| 93 | self.addrDockWidget.setAllowedAreas(QtCore.Qt.TopDockWidgetArea) |
||
| 94 | self.addrDockWidget.setObjectName("addrDockWidget") |
||
| 95 | self.dockWidgetContents_2 = QtWidgets.QWidget() |
||
| 96 | sizePolicy = QtWidgets.QSizePolicy(QtWidgets.QSizePolicy.Expanding, QtWidgets.QSizePolicy.Preferred) |
||
| 97 | sizePolicy.setHorizontalStretch(0) |
||
| 98 | sizePolicy.setVerticalStretch(0) |
||
| 99 | sizePolicy.setHeightForWidth(self.dockWidgetContents_2.sizePolicy().hasHeightForWidth()) |
||
| 100 | self.dockWidgetContents_2.setSizePolicy(sizePolicy) |
||
| 101 | self.dockWidgetContents_2.setObjectName("dockWidgetContents_2") |
||
| 102 | self.gridLayout = QtWidgets.QGridLayout(self.dockWidgetContents_2) |
||
| 103 | self.gridLayout.setContentsMargins(11, 11, 11, 11) |
||
| 104 | self.gridLayout.setSpacing(6) |
||
| 105 | self.gridLayout.setObjectName("gridLayout") |
||
| 106 | self.connectButton = QtWidgets.QPushButton(self.dockWidgetContents_2) |
||
| 107 | self.connectButton.setObjectName("connectButton") |
||
| 108 | self.gridLayout.addWidget(self.connectButton, 0, 1, 1, 1) |
||
| 109 | self.disconnectButton = QtWidgets.QPushButton(self.dockWidgetContents_2) |
||
| 110 | self.disconnectButton.setObjectName("disconnectButton") |
||
| 111 | self.gridLayout.addWidget(self.disconnectButton, 0, 2, 1, 1) |
||
| 112 | self.addrComboBox = QtWidgets.QComboBox(self.dockWidgetContents_2) |
||
| 113 | sizePolicy = QtWidgets.QSizePolicy(QtWidgets.QSizePolicy.Expanding, QtWidgets.QSizePolicy.Fixed) |
||
| 114 | sizePolicy.setHorizontalStretch(0) |
||
| 115 | sizePolicy.setVerticalStretch(0) |
||
| 116 | sizePolicy.setHeightForWidth(self.addrComboBox.sizePolicy().hasHeightForWidth()) |
||
| 117 | self.addrComboBox.setSizePolicy(sizePolicy) |
||
| 118 | self.addrComboBox.setEditable(True) |
||
| 119 | self.addrComboBox.setInsertPolicy(QtWidgets.QComboBox.InsertAtTop) |
||
| 120 | self.addrComboBox.setObjectName("addrComboBox") |
||
| 121 | self.gridLayout.addWidget(self.addrComboBox, 0, 0, 1, 1) |
||
| 122 | self.addrDockWidget.setWidget(self.dockWidgetContents_2) |
||
| 123 | MainWindow.addDockWidget(QtCore.Qt.DockWidgetArea(4), self.addrDockWidget) |
||
| 124 | self.subDockWidget = QtWidgets.QDockWidget(MainWindow) |
||
| 125 | sizePolicy = QtWidgets.QSizePolicy(QtWidgets.QSizePolicy.Expanding, QtWidgets.QSizePolicy.Preferred) |
||
| 126 | sizePolicy.setHorizontalStretch(0) |
||
| 127 | sizePolicy.setVerticalStretch(0) |
||
| 128 | sizePolicy.setHeightForWidth(self.subDockWidget.sizePolicy().hasHeightForWidth()) |
||
| 129 | self.subDockWidget.setSizePolicy(sizePolicy) |
||
| 130 | self.subDockWidget.setObjectName("subDockWidget") |
||
| 131 | self.dockWidgetContents_3 = QtWidgets.QWidget() |
||
| 132 | sizePolicy = QtWidgets.QSizePolicy(QtWidgets.QSizePolicy.Expanding, QtWidgets.QSizePolicy.Preferred) |
||
| 133 | sizePolicy.setHorizontalStretch(0) |
||
| 134 | sizePolicy.setVerticalStretch(0) |
||
| 135 | sizePolicy.setHeightForWidth(self.dockWidgetContents_3.sizePolicy().hasHeightForWidth()) |
||
| 136 | self.dockWidgetContents_3.setSizePolicy(sizePolicy) |
||
| 137 | self.dockWidgetContents_3.setObjectName("dockWidgetContents_3") |
||
| 138 | self.gridLayout_3 = QtWidgets.QGridLayout(self.dockWidgetContents_3) |
||
| 139 | self.gridLayout_3.setContentsMargins(11, 11, 11, 11) |
||
| 140 | self.gridLayout_3.setSpacing(6) |
||
| 141 | self.gridLayout_3.setObjectName("gridLayout_3") |
||
| 142 | self.subView = QtWidgets.QTableView(self.dockWidgetContents_3) |
||
| 143 | self.subView.setAcceptDrops(True) |
||
| 144 | self.subView.setSizeAdjustPolicy(QtWidgets.QAbstractScrollArea.AdjustToContents) |
||
| 145 | self.subView.setEditTriggers(QtWidgets.QAbstractItemView.NoEditTriggers) |
||
| 146 | self.subView.setDragDropOverwriteMode(False) |
||
| 147 | self.subView.setDragDropMode(QtWidgets.QAbstractItemView.DropOnly) |
||
| 148 | self.subView.setObjectName("subView") |
||
| 149 | self.gridLayout_3.addWidget(self.subView, 0, 0, 1, 1) |
||
| 150 | self.subDockWidget.setWidget(self.dockWidgetContents_3) |
||
| 151 | MainWindow.addDockWidget(QtCore.Qt.DockWidgetArea(2), self.subDockWidget) |
||
| 152 | self.refDockWidget = QtWidgets.QDockWidget(MainWindow) |
||
| 153 | sizePolicy = QtWidgets.QSizePolicy(QtWidgets.QSizePolicy.Expanding, QtWidgets.QSizePolicy.Preferred) |
||
| 154 | sizePolicy.setHorizontalStretch(0) |
||
| 155 | sizePolicy.setVerticalStretch(0) |
||
| 156 | sizePolicy.setHeightForWidth(self.refDockWidget.sizePolicy().hasHeightForWidth()) |
||
| 157 | self.refDockWidget.setSizePolicy(sizePolicy) |
||
| 158 | self.refDockWidget.setObjectName("refDockWidget") |
||
| 159 | self.dockWidgetContents_4 = QtWidgets.QWidget() |
||
| 160 | sizePolicy = QtWidgets.QSizePolicy(QtWidgets.QSizePolicy.Expanding, QtWidgets.QSizePolicy.Preferred) |
||
| 161 | sizePolicy.setHorizontalStretch(0) |
||
| 162 | sizePolicy.setVerticalStretch(0) |
||
| 163 | sizePolicy.setHeightForWidth(self.dockWidgetContents_4.sizePolicy().hasHeightForWidth()) |
||
| 164 | self.dockWidgetContents_4.setSizePolicy(sizePolicy) |
||
| 165 | self.dockWidgetContents_4.setObjectName("dockWidgetContents_4") |
||
| 166 | self.verticalLayout_2 = QtWidgets.QVBoxLayout(self.dockWidgetContents_4) |
||
| 167 | self.verticalLayout_2.setContentsMargins(11, 11, 11, 11) |
||
| 168 | self.verticalLayout_2.setSpacing(6) |
||
| 169 | self.verticalLayout_2.setObjectName("verticalLayout_2") |
||
| 170 | self.refView = QtWidgets.QTableView(self.dockWidgetContents_4) |
||
| 171 | self.refView.setEditTriggers(QtWidgets.QAbstractItemView.NoEditTriggers) |
||
| 172 | self.refView.setObjectName("refView") |
||
| 173 | self.verticalLayout_2.addWidget(self.refView) |
||
| 174 | self.refDockWidget.setWidget(self.dockWidgetContents_4) |
||
| 175 | MainWindow.addDockWidget(QtCore.Qt.DockWidgetArea(2), self.refDockWidget) |
||
| 176 | self.evDockWidget = QtWidgets.QDockWidget(MainWindow) |
||
| 177 | sizePolicy = QtWidgets.QSizePolicy(QtWidgets.QSizePolicy.Expanding, QtWidgets.QSizePolicy.Preferred) |
||
| 178 | sizePolicy.setHorizontalStretch(0) |
||
| 179 | sizePolicy.setVerticalStretch(0) |
||
| 180 | sizePolicy.setHeightForWidth(self.evDockWidget.sizePolicy().hasHeightForWidth()) |
||
| 181 | self.evDockWidget.setSizePolicy(sizePolicy) |
||
| 182 | self.evDockWidget.setObjectName("evDockWidget") |
||
| 183 | self.dockWidgetContents_5 = QtWidgets.QWidget() |
||
| 184 | self.dockWidgetContents_5.setObjectName("dockWidgetContents_5") |
||
| 185 | self.gridLayout_5 = QtWidgets.QGridLayout(self.dockWidgetContents_5) |
||
| 186 | self.gridLayout_5.setContentsMargins(11, 11, 11, 11) |
||
| 187 | self.gridLayout_5.setSpacing(6) |
||
| 188 | self.gridLayout_5.setObjectName("gridLayout_5") |
||
| 189 | self.evView = QtWidgets.QListView(self.dockWidgetContents_5) |
||
| 190 | self.evView.setEditTriggers(QtWidgets.QAbstractItemView.NoEditTriggers) |
||
| 191 | self.evView.setObjectName("evView") |
||
| 192 | self.gridLayout_5.addWidget(self.evView, 0, 0, 1, 1) |
||
| 193 | self.evDockWidget.setWidget(self.dockWidgetContents_5) |
||
| 194 | MainWindow.addDockWidget(QtCore.Qt.DockWidgetArea(2), self.evDockWidget) |
||
| 195 | self.actionConnect = QtWidgets.QAction(MainWindow) |
||
| 196 | self.actionConnect.setObjectName("actionConnect") |
||
| 197 | self.actionDisconnect = QtWidgets.QAction(MainWindow) |
||
| 198 | self.actionDisconnect.setObjectName("actionDisconnect") |
||
| 199 | self.actionSubscribeDataChange = QtWidgets.QAction(MainWindow) |
||
| 200 | self.actionSubscribeDataChange.setObjectName("actionSubscribeDataChange") |
||
| 201 | self.actionUnsubscribeDataChange = QtWidgets.QAction(MainWindow) |
||
| 202 | self.actionUnsubscribeDataChange.setObjectName("actionUnsubscribeDataChange") |
||
| 203 | self.actionSubscribeEvent = QtWidgets.QAction(MainWindow) |
||
| 204 | self.actionSubscribeEvent.setObjectName("actionSubscribeEvent") |
||
| 205 | self.actionUnsubscribeEvents = QtWidgets.QAction(MainWindow) |
||
| 206 | self.actionUnsubscribeEvents.setObjectName("actionUnsubscribeEvents") |
||
| 207 | self.actionCopyPath = QtWidgets.QAction(MainWindow) |
||
| 208 | self.actionCopyPath.setObjectName("actionCopyPath") |
||
| 209 | self.actionCopyNodeId = QtWidgets.QAction(MainWindow) |
||
| 210 | self.actionCopyNodeId.setObjectName("actionCopyNodeId") |
||
| 211 | self.menuOPC_UA_Client.addAction(self.actionConnect) |
||
| 212 | self.menuOPC_UA_Client.addAction(self.actionDisconnect) |
||
| 213 | self.menuOPC_UA_Client.addAction(self.actionCopyPath) |
||
| 214 | self.menuOPC_UA_Client.addAction(self.actionCopyNodeId) |
||
| 215 | self.menuOPC_UA_Client.addAction(self.actionSubscribeDataChange) |
||
| 216 | self.menuOPC_UA_Client.addAction(self.actionUnsubscribeDataChange) |
||
| 217 | self.menuOPC_UA_Client.addAction(self.actionSubscribeEvent) |
||
| 218 | self.menuOPC_UA_Client.addAction(self.actionUnsubscribeEvents) |
||
| 219 | self.menuBar.addAction(self.menuOPC_UA_Client.menuAction()) |
||
| 220 | |||
| 221 | self.retranslateUi(MainWindow) |
||
| 222 | QtCore.QMetaObject.connectSlotsByName(MainWindow) |
||
| 223 | |||
| 251 |
