| Conditions | 39 |
| Total Lines | 310 |
| Code Lines | 241 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
Complex classes like asyncua.server.uaprocessor.UaProcessor._process_message() often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
| 1 | import time |
||
| 144 | async def _process_message(self, typeid, requesthdr, seqhdr, body): |
||
| 145 | user = self._connection.security_policy.user |
||
| 146 | if user is None: |
||
| 147 | extra_log_str = "(user unknown)" |
||
| 148 | else: |
||
| 149 | extra_log_str = "(user {})".format(user.name) |
||
| 150 | if self._connection.security_policy.permissions.check_validity(user, typeid, body) is False: |
||
| 151 | raise ua.uaerrors.BadUserAccessDenied |
||
| 152 | |||
| 153 | if typeid == ua.NodeId(ua.ObjectIds.CreateSessionRequest_Encoding_DefaultBinary): |
||
| 154 | _logger.info("Create session request {}".format(extra_log_str)) |
||
| 155 | params = struct_from_binary(ua.CreateSessionParameters, body) |
||
| 156 | # create the session on server |
||
| 157 | self.session = self.iserver.create_session(self.name, user=user, external=True) |
||
| 158 | # get a session creation result to send back |
||
| 159 | sessiondata = await self.session.create_session(params, sockname=self.sockname) |
||
| 160 | response = ua.CreateSessionResponse() |
||
| 161 | response.Parameters = sessiondata |
||
| 162 | response.Parameters.ServerCertificate = self._connection.security_policy.host_certificate |
||
| 163 | if self._connection.security_policy.peer_certificate is None: |
||
| 164 | data = params.ClientNonce |
||
| 165 | else: |
||
| 166 | data = self._connection.security_policy.peer_certificate + params.ClientNonce |
||
| 167 | response.Parameters.ServerSignature.Signature = \ |
||
| 168 | self._connection.security_policy.asymmetric_cryptography.signature(data) |
||
| 169 | response.Parameters.ServerSignature.Algorithm = self._connection.security_policy.AsymmetricSignatureURI |
||
| 170 | #_logger.info("sending create session response") |
||
| 171 | self.send_response(requesthdr.RequestHandle, seqhdr, response) |
||
| 172 | |||
| 173 | elif typeid == ua.NodeId(ua.ObjectIds.CloseSessionRequest_Encoding_DefaultBinary): |
||
| 174 | _logger.info("Close session request {}".format(extra_log_str)) |
||
| 175 | if self.session: |
||
| 176 | deletesubs = ua.ua_binary.Primitives.Boolean.unpack(body) |
||
| 177 | await self.session.close_session(deletesubs) |
||
| 178 | else: |
||
| 179 | _logger.info("Request to close non-existing session {}".format(extra_log_str)) |
||
| 180 | |||
| 181 | response = ua.CloseSessionResponse() |
||
| 182 | _logger.info("sending close session response {}".format(extra_log_str)) |
||
| 183 | self.send_response(requesthdr.RequestHandle, seqhdr, response) |
||
| 184 | |||
| 185 | elif typeid == ua.NodeId(ua.ObjectIds.ActivateSessionRequest_Encoding_DefaultBinary): |
||
| 186 | _logger.info("Activate session request {}".format(extra_log_str)) |
||
| 187 | params = struct_from_binary(ua.ActivateSessionParameters, body) |
||
| 188 | if not self.session: |
||
| 189 | _logger.info("request to activate non-existing session {}".format(extra_log_str)) |
||
| 190 | raise ServiceError(ua.StatusCodes.BadSessionIdInvalid) |
||
| 191 | if self._connection.security_policy.host_certificate is None: |
||
| 192 | data = self.session.nonce |
||
| 193 | else: |
||
| 194 | data = self._connection.security_policy.host_certificate + self.session.nonce |
||
| 195 | self._connection.security_policy.asymmetric_cryptography.verify(data, params.ClientSignature.Signature) |
||
| 196 | result = self.session.activate_session(params) |
||
| 197 | response = ua.ActivateSessionResponse() |
||
| 198 | response.Parameters = result |
||
| 199 | #_logger.info("sending read response") |
||
| 200 | self.send_response(requesthdr.RequestHandle, seqhdr, response) |
||
| 201 | |||
| 202 | elif typeid == ua.NodeId(ua.ObjectIds.ReadRequest_Encoding_DefaultBinary): |
||
| 203 | _logger.info("Read request {}".format(extra_log_str)) |
||
| 204 | params = struct_from_binary(ua.ReadParameters, body) |
||
| 205 | results = await self.session.read(params) |
||
| 206 | response = ua.ReadResponse() |
||
| 207 | response.Results = results |
||
| 208 | #_logger.info("sending read response") |
||
| 209 | self.send_response(requesthdr.RequestHandle, seqhdr, response) |
||
| 210 | |||
| 211 | elif typeid == ua.NodeId(ua.ObjectIds.WriteRequest_Encoding_DefaultBinary): |
||
| 212 | _logger.info("Write request {}".format(extra_log_str)) |
||
| 213 | params = struct_from_binary(ua.WriteParameters, body) |
||
| 214 | results = await self.session.write(params) |
||
| 215 | response = ua.WriteResponse() |
||
| 216 | response.Results = results |
||
| 217 | #_logger.info("sending write response") |
||
| 218 | self.send_response(requesthdr.RequestHandle, seqhdr, response) |
||
| 219 | |||
| 220 | elif typeid == ua.NodeId(ua.ObjectIds.BrowseRequest_Encoding_DefaultBinary): |
||
| 221 | _logger.info("Browse request {}".format(extra_log_str)) |
||
| 222 | params = struct_from_binary(ua.BrowseParameters, body) |
||
| 223 | results = await self.session.browse(params) |
||
| 224 | response = ua.BrowseResponse() |
||
| 225 | response.Results = results |
||
| 226 | #_logger.info("sending browse response") |
||
| 227 | self.send_response(requesthdr.RequestHandle, seqhdr, response) |
||
| 228 | |||
| 229 | elif typeid == ua.NodeId(ua.ObjectIds.GetEndpointsRequest_Encoding_DefaultBinary): |
||
| 230 | _logger.info("get endpoints request {}".format(extra_log_str)) |
||
| 231 | params = struct_from_binary(ua.GetEndpointsParameters, body) |
||
| 232 | endpoints = await self.iserver.get_endpoints(params, sockname=self.sockname) |
||
| 233 | response = ua.GetEndpointsResponse() |
||
| 234 | response.Endpoints = endpoints |
||
| 235 | #_logger.info("sending get endpoints response") |
||
| 236 | self.send_response(requesthdr.RequestHandle, seqhdr, response) |
||
| 237 | |||
| 238 | elif typeid == ua.NodeId(ua.ObjectIds.FindServersRequest_Encoding_DefaultBinary): |
||
| 239 | _logger.info("find servers request {}".format(extra_log_str)) |
||
| 240 | params = struct_from_binary(ua.FindServersParameters, body) |
||
| 241 | servers = self.iserver.find_servers(params) |
||
| 242 | response = ua.FindServersResponse() |
||
| 243 | response.Servers = servers |
||
| 244 | #_logger.info("sending find servers response") |
||
| 245 | self.send_response(requesthdr.RequestHandle, seqhdr, response) |
||
| 246 | |||
| 247 | elif typeid == ua.NodeId(ua.ObjectIds.RegisterServerRequest_Encoding_DefaultBinary): |
||
| 248 | _logger.info("register server request {}".format(extra_log_str)) |
||
| 249 | serv = struct_from_binary(ua.RegisteredServer, body) |
||
| 250 | self.iserver.register_server(serv) |
||
| 251 | response = ua.RegisterServerResponse() |
||
| 252 | #_logger.info("sending register server response") |
||
| 253 | self.send_response(requesthdr.RequestHandle, seqhdr, response) |
||
| 254 | |||
| 255 | elif typeid == ua.NodeId(ua.ObjectIds.RegisterServer2Request_Encoding_DefaultBinary): |
||
| 256 | _logger.info("register server 2 request {}".format(extra_log_str)) |
||
| 257 | params = struct_from_binary(ua.RegisterServer2Parameters, body) |
||
| 258 | results = self.iserver.register_server2(params) |
||
| 259 | response = ua.RegisterServer2Response() |
||
| 260 | response.ConfigurationResults = results |
||
| 261 | #_logger.info("sending register server 2 response") |
||
| 262 | self.send_response(requesthdr.RequestHandle, seqhdr, response) |
||
| 263 | |||
| 264 | elif typeid == ua.NodeId(ua.ObjectIds.TranslateBrowsePathsToNodeIdsRequest_Encoding_DefaultBinary): |
||
| 265 | _logger.info("translate browsepaths to nodeids request {}".format(extra_log_str)) |
||
| 266 | params = struct_from_binary(ua.TranslateBrowsePathsToNodeIdsParameters, body) |
||
| 267 | paths = await self.session.translate_browsepaths_to_nodeids(params.BrowsePaths) |
||
| 268 | response = ua.TranslateBrowsePathsToNodeIdsResponse() |
||
| 269 | response.Results = paths |
||
| 270 | #_logger.info("sending translate browsepaths to nodeids response") |
||
| 271 | self.send_response(requesthdr.RequestHandle, seqhdr, response) |
||
| 272 | |||
| 273 | elif typeid == ua.NodeId(ua.ObjectIds.AddNodesRequest_Encoding_DefaultBinary): |
||
| 274 | _logger.info("add nodes request {}".format(extra_log_str)) |
||
| 275 | params = struct_from_binary(ua.AddNodesParameters, body) |
||
| 276 | results = await self.session.add_nodes(params.NodesToAdd) |
||
| 277 | response = ua.AddNodesResponse() |
||
| 278 | response.Results = results |
||
| 279 | #_logger.info("sending add node response") |
||
| 280 | self.send_response(requesthdr.RequestHandle, seqhdr, response) |
||
| 281 | |||
| 282 | elif typeid == ua.NodeId(ua.ObjectIds.DeleteNodesRequest_Encoding_DefaultBinary): |
||
| 283 | _logger.info("delete nodes request {}".format(extra_log_str)) |
||
| 284 | params = struct_from_binary(ua.DeleteNodesParameters, body) |
||
| 285 | results = await self.session.delete_nodes(params) |
||
| 286 | response = ua.DeleteNodesResponse() |
||
| 287 | response.Results = results |
||
| 288 | #_logger.info("sending delete node response") |
||
| 289 | self.send_response(requesthdr.RequestHandle, seqhdr, response) |
||
| 290 | |||
| 291 | elif typeid == ua.NodeId(ua.ObjectIds.AddReferencesRequest_Encoding_DefaultBinary): |
||
| 292 | _logger.info("add references request {}".format(extra_log_str)) |
||
| 293 | params = struct_from_binary(ua.AddReferencesParameters, body) |
||
| 294 | results = await self.session.add_references(params.ReferencesToAdd) |
||
| 295 | response = ua.AddReferencesResponse() |
||
| 296 | response.Results = results |
||
| 297 | #_logger.info("sending add references response") |
||
| 298 | self.send_response(requesthdr.RequestHandle, seqhdr, response) |
||
| 299 | |||
| 300 | elif typeid == ua.NodeId(ua.ObjectIds.DeleteReferencesRequest_Encoding_DefaultBinary): |
||
| 301 | _logger.info("delete references request {}".format(extra_log_str)) |
||
| 302 | params = struct_from_binary(ua.DeleteReferencesParameters, body) |
||
| 303 | results = await self.session.delete_references(params.ReferencesToDelete) |
||
| 304 | response = ua.DeleteReferencesResponse() |
||
| 305 | response.Parameters.Results = results |
||
| 306 | #_logger.info("sending delete references response") |
||
| 307 | self.send_response(requesthdr.RequestHandle, seqhdr, response) |
||
| 308 | |||
| 309 | elif typeid == ua.NodeId(ua.ObjectIds.CreateSubscriptionRequest_Encoding_DefaultBinary): |
||
| 310 | _logger.info("create subscription request {}".format(extra_log_str)) |
||
| 311 | params = struct_from_binary(ua.CreateSubscriptionParameters, body) |
||
| 312 | result = await self.session.create_subscription(params, callback=self.forward_publish_response) |
||
| 313 | response = ua.CreateSubscriptionResponse() |
||
| 314 | response.Parameters = result |
||
| 315 | #_logger.info("sending create subscription response") |
||
| 316 | self.send_response(requesthdr.RequestHandle, seqhdr, response) |
||
| 317 | |||
| 318 | elif typeid == ua.NodeId(ua.ObjectIds.DeleteSubscriptionsRequest_Encoding_DefaultBinary): |
||
| 319 | _logger.info("delete subscriptions request {}".format(extra_log_str)) |
||
| 320 | params = struct_from_binary(ua.DeleteSubscriptionsParameters, body) |
||
| 321 | results = await self.session.delete_subscriptions(params.SubscriptionIds) |
||
| 322 | response = ua.DeleteSubscriptionsResponse() |
||
| 323 | response.Results = results |
||
| 324 | #_logger.info("sending delete subscription response") |
||
| 325 | self.send_response(requesthdr.RequestHandle, seqhdr, response) |
||
| 326 | |||
| 327 | elif typeid == ua.NodeId(ua.ObjectIds.CreateMonitoredItemsRequest_Encoding_DefaultBinary): |
||
| 328 | _logger.info("create monitored items request {}".format(extra_log_str)) |
||
| 329 | params = struct_from_binary(ua.CreateMonitoredItemsParameters, body) |
||
| 330 | results = await self.session.create_monitored_items(params) |
||
| 331 | response = ua.CreateMonitoredItemsResponse() |
||
| 332 | response.Results = results |
||
| 333 | #_logger.info("sending create monitored items response") |
||
| 334 | self.send_response(requesthdr.RequestHandle, seqhdr, response) |
||
| 335 | |||
| 336 | elif typeid == ua.NodeId(ua.ObjectIds.ModifyMonitoredItemsRequest_Encoding_DefaultBinary): |
||
| 337 | _logger.info("modify monitored items request {}".format(extra_log_str)) |
||
| 338 | params = struct_from_binary(ua.ModifyMonitoredItemsParameters, body) |
||
| 339 | results = await self.session.modify_monitored_items(params) |
||
| 340 | response = ua.ModifyMonitoredItemsResponse() |
||
| 341 | response.Results = results |
||
| 342 | #_logger.info("sending modify monitored items response") |
||
| 343 | self.send_response(requesthdr.RequestHandle, seqhdr, response) |
||
| 344 | |||
| 345 | elif typeid == ua.NodeId(ua.ObjectIds.DeleteMonitoredItemsRequest_Encoding_DefaultBinary): |
||
| 346 | _logger.info("delete monitored items request {}".format(extra_log_str)) |
||
| 347 | params = struct_from_binary(ua.DeleteMonitoredItemsParameters, body) |
||
| 348 | results = await self.session.delete_monitored_items(params) |
||
| 349 | response = ua.DeleteMonitoredItemsResponse() |
||
| 350 | response.Results = results |
||
| 351 | #_logger.info("sending delete monitored items response") |
||
| 352 | self.send_response(requesthdr.RequestHandle, seqhdr, response) |
||
| 353 | |||
| 354 | elif typeid == ua.NodeId(ua.ObjectIds.HistoryReadRequest_Encoding_DefaultBinary): |
||
| 355 | _logger.info("history read request {}".format(extra_log_str)) |
||
| 356 | params = struct_from_binary(ua.HistoryReadParameters, body) |
||
| 357 | results = await self.session.history_read(params) |
||
| 358 | response = ua.HistoryReadResponse() |
||
| 359 | response.Results = results |
||
| 360 | #_logger.info("sending history read response") |
||
| 361 | self.send_response(requesthdr.RequestHandle, seqhdr, response) |
||
| 362 | |||
| 363 | elif typeid == ua.NodeId(ua.ObjectIds.RegisterNodesRequest_Encoding_DefaultBinary): |
||
| 364 | _logger.info("register nodes request {}".format(extra_log_str)) |
||
| 365 | params = struct_from_binary(ua.RegisterNodesParameters, body) |
||
| 366 | _logger.info("Node registration not implemented") |
||
| 367 | response = ua.RegisterNodesResponse() |
||
| 368 | response.Parameters.RegisteredNodeIds = params.NodesToRegister |
||
| 369 | #_logger.info("sending register nodes response") |
||
| 370 | self.send_response(requesthdr.RequestHandle, seqhdr, response) |
||
| 371 | |||
| 372 | elif typeid == ua.NodeId(ua.ObjectIds.UnregisterNodesRequest_Encoding_DefaultBinary): |
||
| 373 | _logger.info("unregister nodes request {}".format(extra_log_str)) |
||
| 374 | params = struct_from_binary(ua.UnregisterNodesParameters, body) |
||
| 375 | response = ua.UnregisterNodesResponse() |
||
| 376 | #_logger.info("sending unregister nodes response") |
||
| 377 | self.send_response(requesthdr.RequestHandle, seqhdr, response) |
||
| 378 | |||
| 379 | elif typeid == ua.NodeId(ua.ObjectIds.PublishRequest_Encoding_DefaultBinary): |
||
| 380 | _logger.debug("publish request {}".format(extra_log_str)) |
||
| 381 | if not self.session: |
||
| 382 | return False |
||
| 383 | params = struct_from_binary(ua.PublishParameters, body) |
||
| 384 | data = PublishRequestData(requesthdr=requesthdr, seqhdr=seqhdr) |
||
| 385 | # Store the Publish Request (will be used to send publish answers from server) |
||
| 386 | self._publish_requests.append(data) |
||
| 387 | # If there is an enqueued result forward it immediately |
||
| 388 | while self._publish_results: |
||
| 389 | result = self._publish_results.popleft() |
||
| 390 | if result.SubscriptionId not in self.session.subscription_service.active_subscription_ids: |
||
| 391 | # Discard the result if the subscription is no longer active |
||
| 392 | continue |
||
| 393 | await self.forward_publish_response(result) |
||
| 394 | break |
||
| 395 | self.session.publish(params.SubscriptionAcknowledgements) |
||
| 396 | #_logger.debug("publish forward to server") |
||
| 397 | |||
| 398 | elif typeid == ua.NodeId(ua.ObjectIds.RepublishRequest_Encoding_DefaultBinary): |
||
| 399 | _logger.info("re-publish request {}".format(extra_log_str)) |
||
| 400 | params = struct_from_binary(ua.RepublishParameters, body) |
||
| 401 | msg = self.session.republish(params) |
||
| 402 | response = ua.RepublishResponse() |
||
| 403 | response.NotificationMessage = msg |
||
| 404 | self.send_response(requesthdr.RequestHandle, seqhdr, response) |
||
| 405 | |||
| 406 | elif typeid == ua.NodeId(ua.ObjectIds.CloseSecureChannelRequest_Encoding_DefaultBinary): |
||
| 407 | _logger.info("close secure channel request {}".format(extra_log_str)) |
||
| 408 | self._connection.close() |
||
| 409 | response = ua.CloseSecureChannelResponse() |
||
| 410 | self.send_response(requesthdr.RequestHandle, seqhdr, response) |
||
| 411 | return False |
||
| 412 | |||
| 413 | elif typeid == ua.NodeId(ua.ObjectIds.CallRequest_Encoding_DefaultBinary): |
||
| 414 | _logger.info("call request {}".format(extra_log_str)) |
||
| 415 | params = struct_from_binary(ua.CallParameters, body) |
||
| 416 | results = await self.session.call(params.MethodsToCall) |
||
| 417 | response = ua.CallResponse() |
||
| 418 | response.Results = results |
||
| 419 | self.send_response(requesthdr.RequestHandle, seqhdr, response) |
||
| 420 | |||
| 421 | elif typeid == ua.NodeId(ua.ObjectIds.SetMonitoringModeRequest_Encoding_DefaultBinary): |
||
| 422 | _logger.info("set monitoring mode request {}".format(extra_log_str)) |
||
| 423 | params = struct_from_binary(ua.SetMonitoringModeParameters, body) |
||
| 424 | # FIXME: Implement SetMonitoringMode |
||
| 425 | # For now send dummy results to keep clients happy |
||
| 426 | response = ua.SetMonitoringModeResponse() |
||
| 427 | results = ua.SetMonitoringModeResult() |
||
| 428 | ids = params.MonitoredItemIds |
||
| 429 | statuses = [ua.StatusCode(ua.StatusCodes.Good) for node_id in ids] |
||
| 430 | results.Results = statuses |
||
| 431 | response.Parameters = results |
||
| 432 | _logger.info("sending set monitoring mode response") |
||
| 433 | self.send_response(requesthdr.RequestHandle, seqhdr, response) |
||
| 434 | |||
| 435 | elif typeid == ua.NodeId(ua.ObjectIds.SetPublishingModeRequest_Encoding_DefaultBinary): |
||
| 436 | _logger.info("set publishing mode request {}".format(extra_log_str)) |
||
| 437 | params = struct_from_binary(ua.SetPublishingModeParameters, body) |
||
| 438 | # FIXME: Implement SetPublishingMode |
||
| 439 | # For now send dummy results to keep clients happy |
||
| 440 | response = ua.SetPublishingModeResponse() |
||
| 441 | results = ua.SetPublishingModeResult() |
||
| 442 | ids = params.SubscriptionIds |
||
| 443 | statuses = [ua.StatusCode(ua.StatusCodes.Good) for node_id in ids] |
||
| 444 | results.Results = statuses |
||
| 445 | response.Parameters = results |
||
| 446 | _logger.info("sending set publishing mode response") |
||
| 447 | self.send_response(requesthdr.RequestHandle, seqhdr, response) |
||
| 448 | |||
| 449 | else: |
||
| 450 | _logger.warning("Unknown message received %s {}".format(extra_log_str), typeid) |
||
| 451 | raise ServiceError(ua.StatusCodes.BadServiceUnsupported) |
||
| 452 | |||
| 453 | return True |
||
| 454 | |||
| 463 |