Conditions | 40 |
Total Lines | 312 |
Code Lines | 242 |
Lines | 0 |
Ratio | 0 % |
Changes | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
Complex classes like asyncua.server.uaprocessor.UaProcessor._process_message() often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
1 | import time |
||
144 | async def _process_message(self, typeid, requesthdr, seqhdr, body): |
||
145 | if typeid in [ua.NodeId(ua.ObjectIds.CreateSessionRequest_Encoding_DefaultBinary), |
||
146 | ua.NodeId(ua.ObjectIds.ActivateSessionRequest_Encoding_DefaultBinary)]: |
||
147 | # The connection is first created without a user being attached, and then during activation the |
||
148 | user = None |
||
149 | else: |
||
150 | user = self.session.user |
||
151 | if self._connection.security_policy.permissions is not None: |
||
152 | if self._connection.security_policy.permissions.check_validity(user, typeid, body) is False: |
||
153 | raise ua.uaerrors.BadUserAccessDenied |
||
154 | |||
155 | if typeid == ua.NodeId(ua.ObjectIds.CreateSessionRequest_Encoding_DefaultBinary): |
||
156 | _logger.info("Create session request (%s)", user) |
||
157 | params = struct_from_binary(ua.CreateSessionParameters, body) |
||
158 | # create the session on server |
||
159 | self.session = self.iserver.create_session(self.name, external=True) |
||
160 | # get a session creation result to send back |
||
161 | sessiondata = await self.session.create_session(params, sockname=self.sockname) |
||
162 | response = ua.CreateSessionResponse() |
||
163 | response.Parameters = sessiondata |
||
164 | response.Parameters.ServerCertificate = self._connection.security_policy.host_certificate |
||
165 | if self._connection.security_policy.peer_certificate is None: |
||
166 | data = params.ClientNonce |
||
167 | else: |
||
168 | data = self._connection.security_policy.peer_certificate + params.ClientNonce |
||
169 | response.Parameters.ServerSignature.Signature = \ |
||
170 | self._connection.security_policy.asymmetric_cryptography.signature(data) |
||
171 | response.Parameters.ServerSignature.Algorithm = self._connection.security_policy.AsymmetricSignatureURI |
||
172 | #_logger.info("sending create session response") |
||
173 | self.send_response(requesthdr.RequestHandle, seqhdr, response) |
||
174 | |||
175 | elif typeid == ua.NodeId(ua.ObjectIds.CloseSessionRequest_Encoding_DefaultBinary): |
||
176 | _logger.info("Close session request (%s)", user) |
||
177 | if self.session: |
||
178 | deletesubs = ua.ua_binary.Primitives.Boolean.unpack(body) |
||
179 | await self.session.close_session(deletesubs) |
||
180 | else: |
||
181 | _logger.info("Request to close non-existing session (%s)", user) |
||
182 | |||
183 | response = ua.CloseSessionResponse() |
||
184 | _logger.info("sending close session response (%s)", user) |
||
185 | self.send_response(requesthdr.RequestHandle, seqhdr, response) |
||
186 | |||
187 | elif typeid == ua.NodeId(ua.ObjectIds.ActivateSessionRequest_Encoding_DefaultBinary): |
||
188 | _logger.info("Activate session request (%s)", user) |
||
189 | params = struct_from_binary(ua.ActivateSessionParameters, body) |
||
190 | if not self.session: |
||
191 | _logger.info("request to activate non-existing session (%s)", user) |
||
192 | raise ServiceError(ua.StatusCodes.BadSessionIdInvalid) |
||
193 | if self._connection.security_policy.host_certificate is None: |
||
194 | data = self.session.nonce |
||
195 | else: |
||
196 | data = self._connection.security_policy.host_certificate + self.session.nonce |
||
197 | self._connection.security_policy.asymmetric_cryptography.verify(data, params.ClientSignature.Signature) |
||
198 | result = self.session.activate_session(params, self._connection.security_policy.peer_certificate) |
||
199 | response = ua.ActivateSessionResponse() |
||
200 | response.Parameters = result |
||
201 | #_logger.info("sending read response") |
||
202 | self.send_response(requesthdr.RequestHandle, seqhdr, response) |
||
203 | |||
204 | elif typeid == ua.NodeId(ua.ObjectIds.ReadRequest_Encoding_DefaultBinary): |
||
205 | _logger.info("Read request (%s)", user) |
||
206 | params = struct_from_binary(ua.ReadParameters, body) |
||
207 | results = await self.session.read(params) |
||
208 | response = ua.ReadResponse() |
||
209 | response.Results = results |
||
210 | #_logger.info("sending read response") |
||
211 | self.send_response(requesthdr.RequestHandle, seqhdr, response) |
||
212 | |||
213 | elif typeid == ua.NodeId(ua.ObjectIds.WriteRequest_Encoding_DefaultBinary): |
||
214 | _logger.info("Write request (%s)", user) |
||
215 | params = struct_from_binary(ua.WriteParameters, body) |
||
216 | results = await self.session.write(params) |
||
217 | response = ua.WriteResponse() |
||
218 | response.Results = results |
||
219 | #_logger.info("sending write response") |
||
220 | self.send_response(requesthdr.RequestHandle, seqhdr, response) |
||
221 | |||
222 | elif typeid == ua.NodeId(ua.ObjectIds.BrowseRequest_Encoding_DefaultBinary): |
||
223 | _logger.info("Browse request (%s)", user) |
||
224 | params = struct_from_binary(ua.BrowseParameters, body) |
||
225 | results = await self.session.browse(params) |
||
226 | response = ua.BrowseResponse() |
||
227 | response.Results = results |
||
228 | #_logger.info("sending browse response") |
||
229 | self.send_response(requesthdr.RequestHandle, seqhdr, response) |
||
230 | |||
231 | elif typeid == ua.NodeId(ua.ObjectIds.GetEndpointsRequest_Encoding_DefaultBinary): |
||
232 | _logger.info("get endpoints request (%s)", user) |
||
233 | params = struct_from_binary(ua.GetEndpointsParameters, body) |
||
234 | endpoints = await self.iserver.get_endpoints(params, sockname=self.sockname) |
||
235 | response = ua.GetEndpointsResponse() |
||
236 | response.Endpoints = endpoints |
||
237 | #_logger.info("sending get endpoints response") |
||
238 | self.send_response(requesthdr.RequestHandle, seqhdr, response) |
||
239 | |||
240 | elif typeid == ua.NodeId(ua.ObjectIds.FindServersRequest_Encoding_DefaultBinary): |
||
241 | _logger.info("find servers request (%s)", user) |
||
242 | params = struct_from_binary(ua.FindServersParameters, body) |
||
243 | servers = self.iserver.find_servers(params) |
||
244 | response = ua.FindServersResponse() |
||
245 | response.Servers = servers |
||
246 | #_logger.info("sending find servers response") |
||
247 | self.send_response(requesthdr.RequestHandle, seqhdr, response) |
||
248 | |||
249 | elif typeid == ua.NodeId(ua.ObjectIds.RegisterServerRequest_Encoding_DefaultBinary): |
||
250 | _logger.info("register server request %s", user) |
||
251 | serv = struct_from_binary(ua.RegisteredServer, body) |
||
252 | self.iserver.register_server(serv) |
||
253 | response = ua.RegisterServerResponse() |
||
254 | #_logger.info("sending register server response") |
||
255 | self.send_response(requesthdr.RequestHandle, seqhdr, response) |
||
256 | |||
257 | elif typeid == ua.NodeId(ua.ObjectIds.RegisterServer2Request_Encoding_DefaultBinary): |
||
258 | _logger.info("register server 2 request %s", user) |
||
259 | params = struct_from_binary(ua.RegisterServer2Parameters, body) |
||
260 | results = self.iserver.register_server2(params) |
||
261 | response = ua.RegisterServer2Response() |
||
262 | response.ConfigurationResults = results |
||
263 | #_logger.info("sending register server 2 response") |
||
264 | self.send_response(requesthdr.RequestHandle, seqhdr, response) |
||
265 | |||
266 | elif typeid == ua.NodeId(ua.ObjectIds.TranslateBrowsePathsToNodeIdsRequest_Encoding_DefaultBinary): |
||
267 | _logger.info("translate browsepaths to nodeids request (%s)", user) |
||
268 | params = struct_from_binary(ua.TranslateBrowsePathsToNodeIdsParameters, body) |
||
269 | paths = await self.session.translate_browsepaths_to_nodeids(params.BrowsePaths) |
||
270 | response = ua.TranslateBrowsePathsToNodeIdsResponse() |
||
271 | response.Results = paths |
||
272 | #_logger.info("sending translate browsepaths to nodeids response") |
||
273 | self.send_response(requesthdr.RequestHandle, seqhdr, response) |
||
274 | |||
275 | elif typeid == ua.NodeId(ua.ObjectIds.AddNodesRequest_Encoding_DefaultBinary): |
||
276 | _logger.info("add nodes request (%s)", user) |
||
277 | params = struct_from_binary(ua.AddNodesParameters, body) |
||
278 | results = await self.session.add_nodes(params.NodesToAdd) |
||
279 | response = ua.AddNodesResponse() |
||
280 | response.Results = results |
||
281 | #_logger.info("sending add node response") |
||
282 | self.send_response(requesthdr.RequestHandle, seqhdr, response) |
||
283 | |||
284 | elif typeid == ua.NodeId(ua.ObjectIds.DeleteNodesRequest_Encoding_DefaultBinary): |
||
285 | _logger.info("delete nodes request (%s)", user) |
||
286 | params = struct_from_binary(ua.DeleteNodesParameters, body) |
||
287 | results = await self.session.delete_nodes(params) |
||
288 | response = ua.DeleteNodesResponse() |
||
289 | response.Results = results |
||
290 | #_logger.info("sending delete node response") |
||
291 | self.send_response(requesthdr.RequestHandle, seqhdr, response) |
||
292 | |||
293 | elif typeid == ua.NodeId(ua.ObjectIds.AddReferencesRequest_Encoding_DefaultBinary): |
||
294 | _logger.info("add references request (%s)", user) |
||
295 | params = struct_from_binary(ua.AddReferencesParameters, body) |
||
296 | results = await self.session.add_references(params.ReferencesToAdd) |
||
297 | response = ua.AddReferencesResponse() |
||
298 | response.Results = results |
||
299 | #_logger.info("sending add references response") |
||
300 | self.send_response(requesthdr.RequestHandle, seqhdr, response) |
||
301 | |||
302 | elif typeid == ua.NodeId(ua.ObjectIds.DeleteReferencesRequest_Encoding_DefaultBinary): |
||
303 | _logger.info("delete references request (%s)", user) |
||
304 | params = struct_from_binary(ua.DeleteReferencesParameters, body) |
||
305 | results = await self.session.delete_references(params.ReferencesToDelete) |
||
306 | response = ua.DeleteReferencesResponse() |
||
307 | response.Parameters.Results = results |
||
308 | #_logger.info("sending delete references response") |
||
309 | self.send_response(requesthdr.RequestHandle, seqhdr, response) |
||
310 | |||
311 | elif typeid == ua.NodeId(ua.ObjectIds.CreateSubscriptionRequest_Encoding_DefaultBinary): |
||
312 | _logger.info("create subscription request (%s)", user) |
||
313 | params = struct_from_binary(ua.CreateSubscriptionParameters, body) |
||
314 | result = await self.session.create_subscription(params, callback=self.forward_publish_response) |
||
315 | response = ua.CreateSubscriptionResponse() |
||
316 | response.Parameters = result |
||
317 | #_logger.info("sending create subscription response") |
||
318 | self.send_response(requesthdr.RequestHandle, seqhdr, response) |
||
319 | |||
320 | elif typeid == ua.NodeId(ua.ObjectIds.DeleteSubscriptionsRequest_Encoding_DefaultBinary): |
||
321 | _logger.info("delete subscriptions request (%s)", user) |
||
322 | params = struct_from_binary(ua.DeleteSubscriptionsParameters, body) |
||
323 | results = await self.session.delete_subscriptions(params.SubscriptionIds) |
||
324 | response = ua.DeleteSubscriptionsResponse() |
||
325 | response.Results = results |
||
326 | #_logger.info("sending delete subscription response") |
||
327 | self.send_response(requesthdr.RequestHandle, seqhdr, response) |
||
328 | |||
329 | elif typeid == ua.NodeId(ua.ObjectIds.CreateMonitoredItemsRequest_Encoding_DefaultBinary): |
||
330 | _logger.info("create monitored items request (%s)", user) |
||
331 | params = struct_from_binary(ua.CreateMonitoredItemsParameters, body) |
||
332 | results = await self.session.create_monitored_items(params) |
||
333 | response = ua.CreateMonitoredItemsResponse() |
||
334 | response.Results = results |
||
335 | #_logger.info("sending create monitored items response") |
||
336 | self.send_response(requesthdr.RequestHandle, seqhdr, response) |
||
337 | |||
338 | elif typeid == ua.NodeId(ua.ObjectIds.ModifyMonitoredItemsRequest_Encoding_DefaultBinary): |
||
339 | _logger.info("modify monitored items request (%s)", user) |
||
340 | params = struct_from_binary(ua.ModifyMonitoredItemsParameters, body) |
||
341 | results = await self.session.modify_monitored_items(params) |
||
342 | response = ua.ModifyMonitoredItemsResponse() |
||
343 | response.Results = results |
||
344 | #_logger.info("sending modify monitored items response") |
||
345 | self.send_response(requesthdr.RequestHandle, seqhdr, response) |
||
346 | |||
347 | elif typeid == ua.NodeId(ua.ObjectIds.DeleteMonitoredItemsRequest_Encoding_DefaultBinary): |
||
348 | _logger.info("delete monitored items request (%s)", user) |
||
349 | params = struct_from_binary(ua.DeleteMonitoredItemsParameters, body) |
||
350 | results = await self.session.delete_monitored_items(params) |
||
351 | response = ua.DeleteMonitoredItemsResponse() |
||
352 | response.Results = results |
||
353 | #_logger.info("sending delete monitored items response") |
||
354 | self.send_response(requesthdr.RequestHandle, seqhdr, response) |
||
355 | |||
356 | elif typeid == ua.NodeId(ua.ObjectIds.HistoryReadRequest_Encoding_DefaultBinary): |
||
357 | _logger.info("history read request (%s)", user) |
||
358 | params = struct_from_binary(ua.HistoryReadParameters, body) |
||
359 | results = await self.session.history_read(params) |
||
360 | response = ua.HistoryReadResponse() |
||
361 | response.Results = results |
||
362 | #_logger.info("sending history read response") |
||
363 | self.send_response(requesthdr.RequestHandle, seqhdr, response) |
||
364 | |||
365 | elif typeid == ua.NodeId(ua.ObjectIds.RegisterNodesRequest_Encoding_DefaultBinary): |
||
366 | _logger.info("register nodes request (%s)", user) |
||
367 | params = struct_from_binary(ua.RegisterNodesParameters, body) |
||
368 | _logger.info("Node registration not implemented") |
||
369 | response = ua.RegisterNodesResponse() |
||
370 | response.Parameters.RegisteredNodeIds = params.NodesToRegister |
||
371 | #_logger.info("sending register nodes response") |
||
372 | self.send_response(requesthdr.RequestHandle, seqhdr, response) |
||
373 | |||
374 | elif typeid == ua.NodeId(ua.ObjectIds.UnregisterNodesRequest_Encoding_DefaultBinary): |
||
375 | _logger.info("unregister nodes request (%s)", user) |
||
376 | params = struct_from_binary(ua.UnregisterNodesParameters, body) |
||
377 | response = ua.UnregisterNodesResponse() |
||
378 | #_logger.info("sending unregister nodes response") |
||
379 | self.send_response(requesthdr.RequestHandle, seqhdr, response) |
||
380 | |||
381 | elif typeid == ua.NodeId(ua.ObjectIds.PublishRequest_Encoding_DefaultBinary): |
||
382 | _logger.debug("publish request (%s)", user) |
||
383 | if not self.session: |
||
384 | return False |
||
385 | params = struct_from_binary(ua.PublishParameters, body) |
||
386 | data = PublishRequestData(requesthdr=requesthdr, seqhdr=seqhdr) |
||
387 | # Store the Publish Request (will be used to send publish answers from server) |
||
388 | self._publish_requests.append(data) |
||
389 | # If there is an enqueued result forward it immediately |
||
390 | while self._publish_results: |
||
391 | result = self._publish_results.popleft() |
||
392 | if result.SubscriptionId not in self.session.subscription_service.active_subscription_ids: |
||
393 | # Discard the result if the subscription is no longer active |
||
394 | continue |
||
395 | await self.forward_publish_response(result) |
||
396 | break |
||
397 | self.session.publish(params.SubscriptionAcknowledgements) |
||
398 | #_logger.debug("publish forward to server") |
||
399 | |||
400 | elif typeid == ua.NodeId(ua.ObjectIds.RepublishRequest_Encoding_DefaultBinary): |
||
401 | _logger.info("re-publish request (%s)", user) |
||
402 | params = struct_from_binary(ua.RepublishParameters, body) |
||
403 | msg = self.session.republish(params) |
||
404 | response = ua.RepublishResponse() |
||
405 | response.NotificationMessage = msg |
||
406 | self.send_response(requesthdr.RequestHandle, seqhdr, response) |
||
407 | |||
408 | elif typeid == ua.NodeId(ua.ObjectIds.CloseSecureChannelRequest_Encoding_DefaultBinary): |
||
409 | _logger.info("close secure channel request (%s)", user) |
||
410 | self._connection.close() |
||
411 | response = ua.CloseSecureChannelResponse() |
||
412 | self.send_response(requesthdr.RequestHandle, seqhdr, response) |
||
413 | return False |
||
414 | |||
415 | elif typeid == ua.NodeId(ua.ObjectIds.CallRequest_Encoding_DefaultBinary): |
||
416 | _logger.info("call request (%s)", user) |
||
417 | params = struct_from_binary(ua.CallParameters, body) |
||
418 | results = await self.session.call(params.MethodsToCall) |
||
419 | response = ua.CallResponse() |
||
420 | response.Results = results |
||
421 | self.send_response(requesthdr.RequestHandle, seqhdr, response) |
||
422 | |||
423 | elif typeid == ua.NodeId(ua.ObjectIds.SetMonitoringModeRequest_Encoding_DefaultBinary): |
||
424 | _logger.info("set monitoring mode request (%s)", user) |
||
425 | params = struct_from_binary(ua.SetMonitoringModeParameters, body) |
||
426 | # FIXME: Implement SetMonitoringMode |
||
427 | # For now send dummy results to keep clients happy |
||
428 | response = ua.SetMonitoringModeResponse() |
||
429 | results = ua.SetMonitoringModeResult() |
||
430 | ids = params.MonitoredItemIds |
||
431 | statuses = [ua.StatusCode(ua.StatusCodes.Good) for node_id in ids] |
||
432 | results.Results = statuses |
||
433 | response.Parameters = results |
||
434 | _logger.info("sending set monitoring mode response") |
||
435 | self.send_response(requesthdr.RequestHandle, seqhdr, response) |
||
436 | |||
437 | elif typeid == ua.NodeId(ua.ObjectIds.SetPublishingModeRequest_Encoding_DefaultBinary): |
||
438 | _logger.info("set publishing mode request (%s)", user) |
||
439 | params = struct_from_binary(ua.SetPublishingModeParameters, body) |
||
440 | # FIXME: Implement SetPublishingMode |
||
441 | # For now send dummy results to keep clients happy |
||
442 | response = ua.SetPublishingModeResponse() |
||
443 | results = ua.SetPublishingModeResult() |
||
444 | ids = params.SubscriptionIds |
||
445 | statuses = [ua.StatusCode(ua.StatusCodes.Good) for node_id in ids] |
||
446 | results.Results = statuses |
||
447 | response.Parameters = results |
||
448 | _logger.info("sending set publishing mode response") |
||
449 | self.send_response(requesthdr.RequestHandle, seqhdr, response) |
||
450 | |||
451 | else: |
||
452 | _logger.warning("Unknown message received %s (%s)", typeid, user) |
||
453 | raise ServiceError(ua.StatusCodes.BadServiceUnsupported) |
||
454 | |||
455 | return True |
||
456 | |||
465 |