Conditions | 37 |
Total Lines | 302 |
Code Lines | 235 |
Lines | 0 |
Ratio | 0 % |
Changes | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
Complex classes like asyncua.server.uaprocessor.UaProcessor._process_message() often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
1 | import time |
||
134 | async def _process_message(self, typeid, requesthdr, seqhdr, body): |
||
135 | if typeid == ua.NodeId(ua.ObjectIds.CreateSessionRequest_Encoding_DefaultBinary): |
||
136 | _logger.info("Create session request") |
||
137 | params = struct_from_binary(ua.CreateSessionParameters, body) |
||
138 | # create the session on server |
||
139 | self.session = self.iserver.create_session(self.name, external=True) |
||
140 | # get a session creation result to send back |
||
141 | sessiondata = await self.session.create_session(params, sockname=self.sockname) |
||
142 | response = ua.CreateSessionResponse() |
||
143 | response.Parameters = sessiondata |
||
144 | response.Parameters.ServerCertificate = self._connection.security_policy.client_certificate |
||
145 | if self._connection.security_policy.server_certificate is None: |
||
146 | data = params.ClientNonce |
||
147 | else: |
||
148 | data = self._connection.security_policy.server_certificate + params.ClientNonce |
||
149 | response.Parameters.ServerSignature.Signature = \ |
||
150 | self._connection.security_policy.asymmetric_cryptography.signature(data) |
||
151 | response.Parameters.ServerSignature.Algorithm = self._connection.security_policy.AsymmetricSignatureURI |
||
152 | #_logger.info("sending create session response") |
||
153 | self.send_response(requesthdr.RequestHandle, seqhdr, response) |
||
154 | |||
155 | elif typeid == ua.NodeId(ua.ObjectIds.CloseSessionRequest_Encoding_DefaultBinary): |
||
156 | _logger.info("Close session request") |
||
157 | if self.session: |
||
158 | deletesubs = ua.ua_binary.Primitives.Boolean.unpack(body) |
||
159 | await self.session.close_session(deletesubs) |
||
160 | else: |
||
161 | _logger.info("Request to close non-existing session") |
||
162 | |||
163 | response = ua.CloseSessionResponse() |
||
164 | _logger.info("sending close session response") |
||
165 | self.send_response(requesthdr.RequestHandle, seqhdr, response) |
||
166 | |||
167 | elif typeid == ua.NodeId(ua.ObjectIds.ActivateSessionRequest_Encoding_DefaultBinary): |
||
168 | _logger.info("Activate session request") |
||
169 | params = struct_from_binary(ua.ActivateSessionParameters, body) |
||
170 | if not self.session: |
||
171 | _logger.info("request to activate non-existing session") |
||
172 | raise ServiceError(ua.StatusCodes.BadSessionIdInvalid) |
||
173 | if self._connection.security_policy.client_certificate is None: |
||
174 | data = self.session.nonce |
||
175 | else: |
||
176 | data = self._connection.security_policy.client_certificate + self.session.nonce |
||
177 | self._connection.security_policy.asymmetric_cryptography.verify(data, params.ClientSignature.Signature) |
||
178 | result = self.session.activate_session(params) |
||
179 | response = ua.ActivateSessionResponse() |
||
180 | response.Parameters = result |
||
181 | #_logger.info("sending read response") |
||
182 | self.send_response(requesthdr.RequestHandle, seqhdr, response) |
||
183 | |||
184 | elif typeid == ua.NodeId(ua.ObjectIds.ReadRequest_Encoding_DefaultBinary): |
||
185 | _logger.info("Read request") |
||
186 | params = struct_from_binary(ua.ReadParameters, body) |
||
187 | results = await self.session.read(params) |
||
188 | response = ua.ReadResponse() |
||
189 | response.Results = results |
||
190 | #_logger.info("sending read response") |
||
191 | self.send_response(requesthdr.RequestHandle, seqhdr, response) |
||
192 | |||
193 | elif typeid == ua.NodeId(ua.ObjectIds.WriteRequest_Encoding_DefaultBinary): |
||
194 | _logger.info("Write request") |
||
195 | params = struct_from_binary(ua.WriteParameters, body) |
||
196 | results = await self.session.write(params) |
||
197 | response = ua.WriteResponse() |
||
198 | response.Results = results |
||
199 | #_logger.info("sending write response") |
||
200 | self.send_response(requesthdr.RequestHandle, seqhdr, response) |
||
201 | |||
202 | elif typeid == ua.NodeId(ua.ObjectIds.BrowseRequest_Encoding_DefaultBinary): |
||
203 | _logger.info("Browse request") |
||
204 | params = struct_from_binary(ua.BrowseParameters, body) |
||
205 | results = await self.session.browse(params) |
||
206 | response = ua.BrowseResponse() |
||
207 | response.Results = results |
||
208 | #_logger.info("sending browse response") |
||
209 | self.send_response(requesthdr.RequestHandle, seqhdr, response) |
||
210 | |||
211 | elif typeid == ua.NodeId(ua.ObjectIds.GetEndpointsRequest_Encoding_DefaultBinary): |
||
212 | _logger.info("get endpoints request") |
||
213 | params = struct_from_binary(ua.GetEndpointsParameters, body) |
||
214 | endpoints = await self.iserver.get_endpoints(params, sockname=self.sockname) |
||
215 | response = ua.GetEndpointsResponse() |
||
216 | response.Endpoints = endpoints |
||
217 | #_logger.info("sending get endpoints response") |
||
218 | self.send_response(requesthdr.RequestHandle, seqhdr, response) |
||
219 | |||
220 | elif typeid == ua.NodeId(ua.ObjectIds.FindServersRequest_Encoding_DefaultBinary): |
||
221 | _logger.info("find servers request") |
||
222 | params = struct_from_binary(ua.FindServersParameters, body) |
||
223 | servers = self.iserver.find_servers(params) |
||
224 | response = ua.FindServersResponse() |
||
225 | response.Servers = servers |
||
226 | #_logger.info("sending find servers response") |
||
227 | self.send_response(requesthdr.RequestHandle, seqhdr, response) |
||
228 | |||
229 | elif typeid == ua.NodeId(ua.ObjectIds.RegisterServerRequest_Encoding_DefaultBinary): |
||
230 | _logger.info("register server request") |
||
231 | serv = struct_from_binary(ua.RegisteredServer, body) |
||
232 | self.iserver.register_server(serv) |
||
233 | response = ua.RegisterServerResponse() |
||
234 | #_logger.info("sending register server response") |
||
235 | self.send_response(requesthdr.RequestHandle, seqhdr, response) |
||
236 | |||
237 | elif typeid == ua.NodeId(ua.ObjectIds.RegisterServer2Request_Encoding_DefaultBinary): |
||
238 | _logger.info("register server 2 request") |
||
239 | params = struct_from_binary(ua.RegisterServer2Parameters, body) |
||
240 | results = self.iserver.register_server2(params) |
||
241 | response = ua.RegisterServer2Response() |
||
242 | response.ConfigurationResults = results |
||
243 | #_logger.info("sending register server 2 response") |
||
244 | self.send_response(requesthdr.RequestHandle, seqhdr, response) |
||
245 | |||
246 | elif typeid == ua.NodeId(ua.ObjectIds.TranslateBrowsePathsToNodeIdsRequest_Encoding_DefaultBinary): |
||
247 | _logger.info("translate browsepaths to nodeids request") |
||
248 | params = struct_from_binary(ua.TranslateBrowsePathsToNodeIdsParameters, body) |
||
249 | paths = await self.session.translate_browsepaths_to_nodeids(params.BrowsePaths) |
||
250 | response = ua.TranslateBrowsePathsToNodeIdsResponse() |
||
251 | response.Results = paths |
||
252 | #_logger.info("sending translate browsepaths to nodeids response") |
||
253 | self.send_response(requesthdr.RequestHandle, seqhdr, response) |
||
254 | |||
255 | elif typeid == ua.NodeId(ua.ObjectIds.AddNodesRequest_Encoding_DefaultBinary): |
||
256 | _logger.info("add nodes request") |
||
257 | params = struct_from_binary(ua.AddNodesParameters, body) |
||
258 | results = await self.session.add_nodes(params.NodesToAdd) |
||
259 | response = ua.AddNodesResponse() |
||
260 | response.Results = results |
||
261 | #_logger.info("sending add node response") |
||
262 | self.send_response(requesthdr.RequestHandle, seqhdr, response) |
||
263 | |||
264 | elif typeid == ua.NodeId(ua.ObjectIds.DeleteNodesRequest_Encoding_DefaultBinary): |
||
265 | _logger.info("delete nodes request") |
||
266 | params = struct_from_binary(ua.DeleteNodesParameters, body) |
||
267 | results = await self.session.delete_nodes(params) |
||
268 | response = ua.DeleteNodesResponse() |
||
269 | response.Results = results |
||
270 | #_logger.info("sending delete node response") |
||
271 | self.send_response(requesthdr.RequestHandle, seqhdr, response) |
||
272 | |||
273 | elif typeid == ua.NodeId(ua.ObjectIds.AddReferencesRequest_Encoding_DefaultBinary): |
||
274 | _logger.info("add references request") |
||
275 | params = struct_from_binary(ua.AddReferencesParameters, body) |
||
276 | results = await self.session.add_references(params.ReferencesToAdd) |
||
277 | response = ua.AddReferencesResponse() |
||
278 | response.Results = results |
||
279 | #_logger.info("sending add references response") |
||
280 | self.send_response(requesthdr.RequestHandle, seqhdr, response) |
||
281 | |||
282 | elif typeid == ua.NodeId(ua.ObjectIds.DeleteReferencesRequest_Encoding_DefaultBinary): |
||
283 | _logger.info("delete references request") |
||
284 | params = struct_from_binary(ua.DeleteReferencesParameters, body) |
||
285 | results = await self.session.delete_references(params.ReferencesToDelete) |
||
286 | response = ua.DeleteReferencesResponse() |
||
287 | response.Parameters.Results = results |
||
288 | #_logger.info("sending delete references response") |
||
289 | self.send_response(requesthdr.RequestHandle, seqhdr, response) |
||
290 | |||
291 | elif typeid == ua.NodeId(ua.ObjectIds.CreateSubscriptionRequest_Encoding_DefaultBinary): |
||
292 | _logger.info("create subscription request") |
||
293 | params = struct_from_binary(ua.CreateSubscriptionParameters, body) |
||
294 | result = await self.session.create_subscription(params, callback=self.forward_publish_response) |
||
295 | response = ua.CreateSubscriptionResponse() |
||
296 | response.Parameters = result |
||
297 | #_logger.info("sending create subscription response") |
||
298 | self.send_response(requesthdr.RequestHandle, seqhdr, response) |
||
299 | |||
300 | elif typeid == ua.NodeId(ua.ObjectIds.DeleteSubscriptionsRequest_Encoding_DefaultBinary): |
||
301 | _logger.info("delete subscriptions request") |
||
302 | params = struct_from_binary(ua.DeleteSubscriptionsParameters, body) |
||
303 | results = await self.session.delete_subscriptions(params.SubscriptionIds) |
||
304 | response = ua.DeleteSubscriptionsResponse() |
||
305 | response.Results = results |
||
306 | #_logger.info("sending delete subscription response") |
||
307 | self.send_response(requesthdr.RequestHandle, seqhdr, response) |
||
308 | |||
309 | elif typeid == ua.NodeId(ua.ObjectIds.CreateMonitoredItemsRequest_Encoding_DefaultBinary): |
||
310 | _logger.info("create monitored items request") |
||
311 | params = struct_from_binary(ua.CreateMonitoredItemsParameters, body) |
||
312 | results = await self.session.create_monitored_items(params) |
||
313 | response = ua.CreateMonitoredItemsResponse() |
||
314 | response.Results = results |
||
315 | #_logger.info("sending create monitored items response") |
||
316 | self.send_response(requesthdr.RequestHandle, seqhdr, response) |
||
317 | |||
318 | elif typeid == ua.NodeId(ua.ObjectIds.ModifyMonitoredItemsRequest_Encoding_DefaultBinary): |
||
319 | _logger.info("modify monitored items request") |
||
320 | params = struct_from_binary(ua.ModifyMonitoredItemsParameters, body) |
||
321 | results = await self.session.modify_monitored_items(params) |
||
322 | response = ua.ModifyMonitoredItemsResponse() |
||
323 | response.Results = results |
||
324 | #_logger.info("sending modify monitored items response") |
||
325 | self.send_response(requesthdr.RequestHandle, seqhdr, response) |
||
326 | |||
327 | elif typeid == ua.NodeId(ua.ObjectIds.DeleteMonitoredItemsRequest_Encoding_DefaultBinary): |
||
328 | _logger.info("delete monitored items request") |
||
329 | params = struct_from_binary(ua.DeleteMonitoredItemsParameters, body) |
||
330 | results = await self.session.delete_monitored_items(params) |
||
331 | response = ua.DeleteMonitoredItemsResponse() |
||
332 | response.Results = results |
||
333 | #_logger.info("sending delete monitored items response") |
||
334 | self.send_response(requesthdr.RequestHandle, seqhdr, response) |
||
335 | |||
336 | elif typeid == ua.NodeId(ua.ObjectIds.HistoryReadRequest_Encoding_DefaultBinary): |
||
337 | _logger.info("history read request") |
||
338 | params = struct_from_binary(ua.HistoryReadParameters, body) |
||
339 | results = await self.session.history_read(params) |
||
340 | response = ua.HistoryReadResponse() |
||
341 | response.Results = results |
||
342 | #_logger.info("sending history read response") |
||
343 | self.send_response(requesthdr.RequestHandle, seqhdr, response) |
||
344 | |||
345 | elif typeid == ua.NodeId(ua.ObjectIds.RegisterNodesRequest_Encoding_DefaultBinary): |
||
346 | _logger.info("register nodes request") |
||
347 | params = struct_from_binary(ua.RegisterNodesParameters, body) |
||
348 | _logger.info("Node registration not implemented") |
||
349 | response = ua.RegisterNodesResponse() |
||
350 | response.Parameters.RegisteredNodeIds = params.NodesToRegister |
||
351 | #_logger.info("sending register nodes response") |
||
352 | self.send_response(requesthdr.RequestHandle, seqhdr, response) |
||
353 | |||
354 | elif typeid == ua.NodeId(ua.ObjectIds.UnregisterNodesRequest_Encoding_DefaultBinary): |
||
355 | _logger.info("unregister nodes request") |
||
356 | params = struct_from_binary(ua.UnregisterNodesParameters, body) |
||
357 | response = ua.UnregisterNodesResponse() |
||
358 | #_logger.info("sending unregister nodes response") |
||
359 | self.send_response(requesthdr.RequestHandle, seqhdr, response) |
||
360 | |||
361 | elif typeid == ua.NodeId(ua.ObjectIds.PublishRequest_Encoding_DefaultBinary): |
||
362 | _logger.debug("publish request") |
||
363 | if not self.session: |
||
364 | return False |
||
365 | params = struct_from_binary(ua.PublishParameters, body) |
||
366 | data = PublishRequestData(requesthdr=requesthdr, seqhdr=seqhdr) |
||
367 | # Store the Publish Request (will be used to send publish answers from server) |
||
368 | self._publish_requests.append(data) |
||
369 | # If there is an enqueued result forward it immediately |
||
370 | while self._publish_results: |
||
371 | result = self._publish_results.popleft() |
||
372 | if result.SubscriptionId not in self.session.subscription_service.active_subscription_ids: |
||
373 | # Discard the result if the subscription is no longer active |
||
374 | continue |
||
375 | self.forward_publish_response(result) |
||
376 | break |
||
377 | self.session.publish(params.SubscriptionAcknowledgements) |
||
378 | #_logger.debug("publish forward to server") |
||
379 | |||
380 | elif typeid == ua.NodeId(ua.ObjectIds.RepublishRequest_Encoding_DefaultBinary): |
||
381 | _logger.info("re-publish request") |
||
382 | params = struct_from_binary(ua.RepublishParameters, body) |
||
383 | msg = self.session.republish(params) |
||
384 | response = ua.RepublishResponse() |
||
385 | response.NotificationMessage = msg |
||
386 | self.send_response(requesthdr.RequestHandle, seqhdr, response) |
||
387 | |||
388 | elif typeid == ua.NodeId(ua.ObjectIds.CloseSecureChannelRequest_Encoding_DefaultBinary): |
||
389 | _logger.info("close secure channel request") |
||
390 | self._connection.close() |
||
391 | response = ua.CloseSecureChannelResponse() |
||
392 | self.send_response(requesthdr.RequestHandle, seqhdr, response) |
||
393 | return False |
||
394 | |||
395 | elif typeid == ua.NodeId(ua.ObjectIds.CallRequest_Encoding_DefaultBinary): |
||
396 | _logger.info("call request") |
||
397 | params = struct_from_binary(ua.CallParameters, body) |
||
398 | results = await self.session.call(params.MethodsToCall) |
||
399 | response = ua.CallResponse() |
||
400 | response.Results = results |
||
401 | self.send_response(requesthdr.RequestHandle, seqhdr, response) |
||
402 | |||
403 | elif typeid == ua.NodeId(ua.ObjectIds.SetMonitoringModeRequest_Encoding_DefaultBinary): |
||
404 | _logger.info("set monitoring mode request") |
||
405 | params = struct_from_binary(ua.SetMonitoringModeParameters, body) |
||
406 | # FIXME: Implement SetMonitoringMode |
||
407 | # For now send dummy results to keep clients happy |
||
408 | response = ua.SetMonitoringModeResponse() |
||
409 | results = ua.SetMonitoringModeResult() |
||
410 | ids = params.MonitoredItemIds |
||
411 | statuses = [ua.StatusCode(ua.StatusCodes.Good) for node_id in ids] |
||
412 | results.Results = statuses |
||
413 | response.Parameters = results |
||
414 | _logger.info("sending set monitoring mode response") |
||
415 | self.send_response(requesthdr.RequestHandle, seqhdr, response) |
||
416 | |||
417 | elif typeid == ua.NodeId(ua.ObjectIds.SetPublishingModeRequest_Encoding_DefaultBinary): |
||
418 | _logger.info("set publishing mode request") |
||
419 | params = struct_from_binary(ua.SetPublishingModeParameters, body) |
||
420 | # FIXME: Implement SetPublishingMode |
||
421 | # For now send dummy results to keep clients happy |
||
422 | response = ua.SetPublishingModeResponse() |
||
423 | results = ua.SetPublishingModeResult() |
||
424 | ids = params.SubscriptionIds |
||
425 | statuses = [ua.StatusCode(ua.StatusCodes.Good) for node_id in ids] |
||
426 | results.Results = statuses |
||
427 | response.Parameters = results |
||
428 | _logger.info("sending set publishing mode response") |
||
429 | self.send_response(requesthdr.RequestHandle, seqhdr, response) |
||
430 | |||
431 | else: |
||
432 | _logger.warning("Unknown message received %s", typeid) |
||
433 | raise ServiceError(ua.StatusCodes.BadServiceUnsupported) |
||
434 | |||
435 | return True |
||
436 | |||
445 |