Conditions | 42 |
Total Lines | 329 |
Code Lines | 254 |
Lines | 0 |
Ratio | 0 % |
Changes | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
Complex classes like asyncua.server.uaprocessor.UaProcessor._process_message() often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
1 | import time |
||
150 | async def _process_message(self, typeid, requesthdr, seqhdr, body): |
||
151 | if typeid in [ua.NodeId(ua.ObjectIds.CreateSessionRequest_Encoding_DefaultBinary), |
||
152 | ua.NodeId(ua.ObjectIds.ActivateSessionRequest_Encoding_DefaultBinary), |
||
153 | ua.NodeId(ua.ObjectIds.FindServersRequest_Encoding_DefaultBinary), |
||
154 | ua.NodeId(ua.ObjectIds.GetEndpointsRequest_Encoding_DefaultBinary)]: |
||
155 | # The connection is first created without a user being attached, and then during activation the |
||
156 | user = None |
||
157 | elif self.session is None: |
||
158 | _logger.warning("Received a request of type %d without an existing session", typeid.Identifier) |
||
159 | raise ua.uaerrors.BadUserAccessDenied |
||
160 | else: |
||
161 | user = self.session.user |
||
162 | if self._connection.security_policy.permissions is not None: |
||
163 | if self._connection.security_policy.permissions.check_validity(user, typeid, body) is False: |
||
164 | raise ua.uaerrors.BadUserAccessDenied |
||
165 | |||
166 | if typeid == ua.NodeId(ua.ObjectIds.CreateSessionRequest_Encoding_DefaultBinary): |
||
167 | _logger.info("Create session request (%s)", user) |
||
168 | params = struct_from_binary(ua.CreateSessionParameters, body) |
||
169 | # create the session on server |
||
170 | self.session = self.iserver.create_session(self.name, external=True) |
||
171 | # get a session creation result to send back |
||
172 | sessiondata = await self.session.create_session(params, sockname=self.sockname) |
||
173 | response = ua.CreateSessionResponse() |
||
174 | response.Parameters = sessiondata |
||
175 | response.Parameters.ServerCertificate = self._connection.security_policy.host_certificate |
||
176 | if self._connection.security_policy.peer_certificate is None: |
||
177 | data = params.ClientNonce |
||
178 | else: |
||
179 | data = self._connection.security_policy.peer_certificate + params.ClientNonce |
||
180 | response.Parameters.ServerSignature.Signature = \ |
||
181 | self._connection.security_policy.asymmetric_cryptography.signature(data) |
||
182 | response.Parameters.ServerSignature.Algorithm = self._connection.security_policy.AsymmetricSignatureURI |
||
183 | # _logger.info("sending create session response") |
||
184 | self.send_response(requesthdr.RequestHandle, seqhdr, response) |
||
185 | |||
186 | elif typeid == ua.NodeId(ua.ObjectIds.CloseSessionRequest_Encoding_DefaultBinary): |
||
187 | _logger.info("Close session request (%s)", user) |
||
188 | if self.session: |
||
189 | deletesubs = ua.ua_binary.Primitives.Boolean.unpack(body) |
||
190 | await self.session.close_session(deletesubs) |
||
191 | else: |
||
192 | _logger.info("Request to close non-existing session (%s)", user) |
||
193 | |||
194 | response = ua.CloseSessionResponse() |
||
195 | _logger.info("sending close session response (%s)", user) |
||
196 | self.send_response(requesthdr.RequestHandle, seqhdr, response) |
||
197 | |||
198 | elif typeid == ua.NodeId(ua.ObjectIds.ActivateSessionRequest_Encoding_DefaultBinary): |
||
199 | _logger.info("Activate session request (%s)", user) |
||
200 | params = struct_from_binary(ua.ActivateSessionParameters, body) |
||
201 | if not self.session: |
||
202 | _logger.info("request to activate non-existing session (%s)", user) |
||
203 | raise ServiceError(ua.StatusCodes.BadSessionIdInvalid) |
||
204 | if self._connection.security_policy.host_certificate is None: |
||
205 | data = self.session.nonce |
||
206 | else: |
||
207 | data = self._connection.security_policy.host_certificate + self.session.nonce |
||
208 | self._connection.security_policy.asymmetric_cryptography.verify(data, params.ClientSignature.Signature) |
||
209 | result = self.session.activate_session(params, self._connection.security_policy.peer_certificate) |
||
210 | response = ua.ActivateSessionResponse() |
||
211 | response.Parameters = result |
||
212 | # _logger.info("sending read response") |
||
213 | self.send_response(requesthdr.RequestHandle, seqhdr, response) |
||
214 | |||
215 | elif typeid == ua.NodeId(ua.ObjectIds.ReadRequest_Encoding_DefaultBinary): |
||
216 | _logger.info("Read request (%s)", user) |
||
217 | params = struct_from_binary(ua.ReadParameters, body) |
||
218 | results = await self.session.read(params) |
||
219 | response = ua.ReadResponse() |
||
220 | response.Results = results |
||
221 | # _logger.info("sending read response") |
||
222 | self.send_response(requesthdr.RequestHandle, seqhdr, response) |
||
223 | |||
224 | elif typeid == ua.NodeId(ua.ObjectIds.WriteRequest_Encoding_DefaultBinary): |
||
225 | _logger.info("Write request (%s)", user) |
||
226 | params = struct_from_binary(ua.WriteParameters, body) |
||
227 | results = await self.session.write(params) |
||
228 | response = ua.WriteResponse() |
||
229 | response.Results = results |
||
230 | # _logger.info("sending write response") |
||
231 | self.send_response(requesthdr.RequestHandle, seqhdr, response) |
||
232 | |||
233 | elif typeid == ua.NodeId(ua.ObjectIds.BrowseRequest_Encoding_DefaultBinary): |
||
234 | _logger.info("Browse request (%s)", user) |
||
235 | params = struct_from_binary(ua.BrowseParameters, body) |
||
236 | results = await self.session.browse(params) |
||
237 | response = ua.BrowseResponse() |
||
238 | response.Results = results |
||
239 | # _logger.info("sending browse response") |
||
240 | self.send_response(requesthdr.RequestHandle, seqhdr, response) |
||
241 | |||
242 | elif typeid == ua.NodeId(ua.ObjectIds.GetEndpointsRequest_Encoding_DefaultBinary): |
||
243 | _logger.info("get endpoints request (%s)", user) |
||
244 | params = struct_from_binary(ua.GetEndpointsParameters, body) |
||
245 | endpoints = await self.iserver.get_endpoints(params, sockname=self.sockname) |
||
246 | response = ua.GetEndpointsResponse() |
||
247 | response.Endpoints = endpoints |
||
248 | # _logger.info("sending get endpoints response") |
||
249 | self.send_response(requesthdr.RequestHandle, seqhdr, response) |
||
250 | |||
251 | elif typeid == ua.NodeId(ua.ObjectIds.FindServersRequest_Encoding_DefaultBinary): |
||
252 | _logger.info("find servers request (%s)", user) |
||
253 | params = struct_from_binary(ua.FindServersParameters, body) |
||
254 | servers = self.iserver.find_servers(params) |
||
255 | response = ua.FindServersResponse() |
||
256 | response.Servers = servers |
||
257 | # _logger.info("sending find servers response") |
||
258 | self.send_response(requesthdr.RequestHandle, seqhdr, response) |
||
259 | |||
260 | elif typeid == ua.NodeId(ua.ObjectIds.RegisterServerRequest_Encoding_DefaultBinary): |
||
261 | _logger.info("register server request %s", user) |
||
262 | serv = struct_from_binary(ua.RegisteredServer, body) |
||
263 | self.iserver.register_server(serv) |
||
264 | response = ua.RegisterServerResponse() |
||
265 | # _logger.info("sending register server response") |
||
266 | self.send_response(requesthdr.RequestHandle, seqhdr, response) |
||
267 | |||
268 | elif typeid == ua.NodeId(ua.ObjectIds.RegisterServer2Request_Encoding_DefaultBinary): |
||
269 | _logger.info("register server 2 request %s", user) |
||
270 | params = struct_from_binary(ua.RegisterServer2Parameters, body) |
||
271 | results = self.iserver.register_server2(params) |
||
272 | response = ua.RegisterServer2Response() |
||
273 | response.ConfigurationResults = results |
||
274 | # _logger.info("sending register server 2 response") |
||
275 | self.send_response(requesthdr.RequestHandle, seqhdr, response) |
||
276 | |||
277 | elif typeid == ua.NodeId(ua.ObjectIds.TranslateBrowsePathsToNodeIdsRequest_Encoding_DefaultBinary): |
||
278 | _logger.info("translate browsepaths to nodeids request (%s)", user) |
||
279 | params = struct_from_binary(ua.TranslateBrowsePathsToNodeIdsParameters, body) |
||
280 | paths = await self.session.translate_browsepaths_to_nodeids(params.BrowsePaths) |
||
281 | response = ua.TranslateBrowsePathsToNodeIdsResponse() |
||
282 | response.Results = paths |
||
283 | # _logger.info("sending translate browsepaths to nodeids response") |
||
284 | self.send_response(requesthdr.RequestHandle, seqhdr, response) |
||
285 | |||
286 | elif typeid == ua.NodeId(ua.ObjectIds.AddNodesRequest_Encoding_DefaultBinary): |
||
287 | _logger.info("add nodes request (%s)", user) |
||
288 | params = struct_from_binary(ua.AddNodesParameters, body) |
||
289 | results = await self.session.add_nodes(params.NodesToAdd) |
||
290 | response = ua.AddNodesResponse() |
||
291 | response.Results = results |
||
292 | # _logger.info("sending add node response") |
||
293 | self.send_response(requesthdr.RequestHandle, seqhdr, response) |
||
294 | |||
295 | elif typeid == ua.NodeId(ua.ObjectIds.DeleteNodesRequest_Encoding_DefaultBinary): |
||
296 | _logger.info("delete nodes request (%s)", user) |
||
297 | params = struct_from_binary(ua.DeleteNodesParameters, body) |
||
298 | results = await self.session.delete_nodes(params) |
||
299 | response = ua.DeleteNodesResponse() |
||
300 | response.Results = results |
||
301 | # _logger.info("sending delete node response") |
||
302 | self.send_response(requesthdr.RequestHandle, seqhdr, response) |
||
303 | |||
304 | elif typeid == ua.NodeId(ua.ObjectIds.AddReferencesRequest_Encoding_DefaultBinary): |
||
305 | _logger.info("add references request (%s)", user) |
||
306 | params = struct_from_binary(ua.AddReferencesParameters, body) |
||
307 | results = await self.session.add_references(params.ReferencesToAdd) |
||
308 | response = ua.AddReferencesResponse() |
||
309 | response.Results = results |
||
310 | # _logger.info("sending add references response") |
||
311 | self.send_response(requesthdr.RequestHandle, seqhdr, response) |
||
312 | |||
313 | elif typeid == ua.NodeId(ua.ObjectIds.DeleteReferencesRequest_Encoding_DefaultBinary): |
||
314 | _logger.info("delete references request (%s)", user) |
||
315 | params = struct_from_binary(ua.DeleteReferencesParameters, body) |
||
316 | results = await self.session.delete_references(params.ReferencesToDelete) |
||
317 | response = ua.DeleteReferencesResponse() |
||
318 | response.Parameters.Results = results |
||
319 | # _logger.info("sending delete references response") |
||
320 | self.send_response(requesthdr.RequestHandle, seqhdr, response) |
||
321 | |||
322 | elif typeid == ua.NodeId(ua.ObjectIds.CreateSubscriptionRequest_Encoding_DefaultBinary): |
||
323 | _logger.info("create subscription request (%s)", user) |
||
324 | params = struct_from_binary(ua.CreateSubscriptionParameters, body) |
||
325 | result = await self.session.create_subscription(params, callback=self.forward_publish_response) |
||
326 | response = ua.CreateSubscriptionResponse() |
||
327 | response.Parameters = result |
||
328 | # _logger.info("sending create subscription response") |
||
329 | self.send_response(requesthdr.RequestHandle, seqhdr, response) |
||
330 | |||
331 | elif typeid == ua.NodeId(ua.ObjectIds.ModifySubscriptionRequest_Encoding_DefaultBinary): |
||
332 | _logger.info("modify subscription request") |
||
333 | params = struct_from_binary(ua.ModifySubscriptionParameters, body) |
||
334 | |||
335 | result = self.session.modify_subscription(params, self.forward_publish_response) |
||
336 | |||
337 | response = ua.ModifySubscriptionResponse() |
||
338 | response.Parameters = result |
||
339 | |||
340 | #_logger.info("sending modify subscription response") |
||
341 | self.send_response(requesthdr.RequestHandle, seqhdr, response) |
||
342 | |||
343 | elif typeid == ua.NodeId(ua.ObjectIds.DeleteSubscriptionsRequest_Encoding_DefaultBinary): |
||
344 | _logger.info("delete subscriptions request (%s)", user) |
||
345 | params = struct_from_binary(ua.DeleteSubscriptionsParameters, body) |
||
346 | results = await self.session.delete_subscriptions(params.SubscriptionIds) |
||
347 | response = ua.DeleteSubscriptionsResponse() |
||
348 | response.Results = results |
||
349 | # _logger.info("sending delete subscription response") |
||
350 | self.send_response(requesthdr.RequestHandle, seqhdr, response) |
||
351 | |||
352 | elif typeid == ua.NodeId(ua.ObjectIds.CreateMonitoredItemsRequest_Encoding_DefaultBinary): |
||
353 | _logger.info("create monitored items request (%s)", user) |
||
354 | params = struct_from_binary(ua.CreateMonitoredItemsParameters, body) |
||
355 | results = await self.session.create_monitored_items(params) |
||
356 | response = ua.CreateMonitoredItemsResponse() |
||
357 | response.Results = results |
||
358 | # _logger.info("sending create monitored items response") |
||
359 | self.send_response(requesthdr.RequestHandle, seqhdr, response) |
||
360 | |||
361 | elif typeid == ua.NodeId(ua.ObjectIds.ModifyMonitoredItemsRequest_Encoding_DefaultBinary): |
||
362 | _logger.info("modify monitored items request (%s)", user) |
||
363 | params = struct_from_binary(ua.ModifyMonitoredItemsParameters, body) |
||
364 | results = await self.session.modify_monitored_items(params) |
||
365 | response = ua.ModifyMonitoredItemsResponse() |
||
366 | response.Results = results |
||
367 | # _logger.info("sending modify monitored items response") |
||
368 | self.send_response(requesthdr.RequestHandle, seqhdr, response) |
||
369 | |||
370 | elif typeid == ua.NodeId(ua.ObjectIds.DeleteMonitoredItemsRequest_Encoding_DefaultBinary): |
||
371 | _logger.info("delete monitored items request (%s)", user) |
||
372 | params = struct_from_binary(ua.DeleteMonitoredItemsParameters, body) |
||
373 | results = await self.session.delete_monitored_items(params) |
||
374 | response = ua.DeleteMonitoredItemsResponse() |
||
375 | response.Results = results |
||
376 | # _logger.info("sending delete monitored items response") |
||
377 | self.send_response(requesthdr.RequestHandle, seqhdr, response) |
||
378 | |||
379 | elif typeid == ua.NodeId(ua.ObjectIds.HistoryReadRequest_Encoding_DefaultBinary): |
||
380 | _logger.info("history read request (%s)", user) |
||
381 | params = struct_from_binary(ua.HistoryReadParameters, body) |
||
382 | results = await self.session.history_read(params) |
||
383 | response = ua.HistoryReadResponse() |
||
384 | response.Results = results |
||
385 | # _logger.info("sending history read response") |
||
386 | self.send_response(requesthdr.RequestHandle, seqhdr, response) |
||
387 | |||
388 | elif typeid == ua.NodeId(ua.ObjectIds.RegisterNodesRequest_Encoding_DefaultBinary): |
||
389 | _logger.info("register nodes request (%s)", user) |
||
390 | params = struct_from_binary(ua.RegisterNodesParameters, body) |
||
391 | _logger.info("Node registration not implemented") |
||
392 | response = ua.RegisterNodesResponse() |
||
393 | response.Parameters.RegisteredNodeIds = params.NodesToRegister |
||
394 | # _logger.info("sending register nodes response") |
||
395 | self.send_response(requesthdr.RequestHandle, seqhdr, response) |
||
396 | |||
397 | elif typeid == ua.NodeId(ua.ObjectIds.UnregisterNodesRequest_Encoding_DefaultBinary): |
||
398 | _logger.info("unregister nodes request (%s)", user) |
||
399 | params = struct_from_binary(ua.UnregisterNodesParameters, body) |
||
400 | response = ua.UnregisterNodesResponse() |
||
401 | # _logger.info("sending unregister nodes response") |
||
402 | self.send_response(requesthdr.RequestHandle, seqhdr, response) |
||
403 | |||
404 | elif typeid == ua.NodeId(ua.ObjectIds.PublishRequest_Encoding_DefaultBinary): |
||
405 | _logger.debug("publish request (%s)", user) |
||
406 | if not self.session: |
||
407 | return False |
||
408 | params = struct_from_binary(ua.PublishParameters, body) |
||
409 | data = PublishRequestData(requesthdr=requesthdr, seqhdr=seqhdr) |
||
410 | # Store the Publish Request (will be used to send publish answers from server) |
||
411 | self._publish_requests.append(data) |
||
412 | # If there is an enqueued result forward it immediately |
||
413 | while self._publish_results: |
||
414 | result = self._publish_results.popleft() |
||
415 | if result.SubscriptionId not in self.session.subscription_service.active_subscription_ids: |
||
416 | # Discard the result if the subscription is no longer active |
||
417 | continue |
||
418 | await self.forward_publish_response(result) |
||
419 | break |
||
420 | self.session.publish(params.SubscriptionAcknowledgements) |
||
421 | # _logger.debug("publish forward to server") |
||
422 | |||
423 | elif typeid == ua.NodeId(ua.ObjectIds.RepublishRequest_Encoding_DefaultBinary): |
||
424 | _logger.info("re-publish request (%s)", user) |
||
425 | params = struct_from_binary(ua.RepublishParameters, body) |
||
426 | msg = self.session.republish(params) |
||
427 | response = ua.RepublishResponse() |
||
428 | response.NotificationMessage = msg |
||
429 | self.send_response(requesthdr.RequestHandle, seqhdr, response) |
||
430 | |||
431 | elif typeid == ua.NodeId(ua.ObjectIds.CloseSecureChannelRequest_Encoding_DefaultBinary): |
||
432 | _logger.info("close secure channel request (%s)", user) |
||
433 | self._connection.close() |
||
434 | response = ua.CloseSecureChannelResponse() |
||
435 | self.send_response(requesthdr.RequestHandle, seqhdr, response) |
||
436 | return False |
||
437 | |||
438 | elif typeid == ua.NodeId(ua.ObjectIds.CallRequest_Encoding_DefaultBinary): |
||
439 | _logger.info("call request (%s)", user) |
||
440 | params = struct_from_binary(ua.CallParameters, body) |
||
441 | results = await self.session.call(params.MethodsToCall) |
||
442 | response = ua.CallResponse() |
||
443 | response.Results = results |
||
444 | self.send_response(requesthdr.RequestHandle, seqhdr, response) |
||
445 | |||
446 | elif typeid == ua.NodeId(ua.ObjectIds.SetMonitoringModeRequest_Encoding_DefaultBinary): |
||
447 | _logger.info("set monitoring mode request (%s)", user) |
||
448 | params = struct_from_binary(ua.SetMonitoringModeParameters, body) |
||
449 | # FIXME: Implement SetMonitoringMode |
||
450 | # For now send dummy results to keep clients happy |
||
451 | response = ua.SetMonitoringModeResponse() |
||
452 | results = ua.SetMonitoringModeResult() |
||
453 | ids = params.MonitoredItemIds |
||
454 | statuses = [ua.StatusCode(ua.StatusCodes.Good) for node_id in ids] |
||
455 | results.Results = statuses |
||
456 | response.Parameters = results |
||
457 | _logger.info("sending set monitoring mode response") |
||
458 | self.send_response(requesthdr.RequestHandle, seqhdr, response) |
||
459 | |||
460 | elif typeid == ua.NodeId(ua.ObjectIds.SetPublishingModeRequest_Encoding_DefaultBinary): |
||
461 | _logger.info("set publishing mode request (%s)", user) |
||
462 | params = struct_from_binary(ua.SetPublishingModeParameters, body) |
||
463 | # FIXME: Implement SetPublishingMode |
||
464 | # For now send dummy results to keep clients happy |
||
465 | response = ua.SetPublishingModeResponse() |
||
466 | results = ua.SetPublishingModeResult() |
||
467 | ids = params.SubscriptionIds |
||
468 | statuses = [ua.StatusCode(ua.StatusCodes.Good) for node_id in ids] |
||
469 | results.Results = statuses |
||
470 | response.Parameters = results |
||
471 | _logger.info("sending set publishing mode response") |
||
472 | self.send_response(requesthdr.RequestHandle, seqhdr, response) |
||
473 | |||
474 | else: |
||
475 | _logger.warning("Unknown message received %s (%s)", typeid, user) |
||
476 | raise ServiceError(ua.StatusCodes.BadServiceUnsupported) |
||
477 | |||
478 | return True |
||
479 | |||
488 |