DomFactory::build() - Code Metrics - FrancisBaileyH/Purge - Measure and Improve Code Quality continuously with Scrutinizer

DomFactory::build() A
last analyzed 2019-05-10 05:44 UTC

↳ Parent: DomFactory

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	8
rs	10
c	0
b	0
f	0
cc	1
nc	1
nop	1

<?php



namespace Katten\Purge\Factory;


use Katten\Purge\PurgeHtmlCrawler;
use Katten\Purge\Exceptions\UnableToReadInFileException;


class DomFactory extends FileFactory {


    /**
     * Build a preloaded Dom object
     * 
     * @param string $file
     *      A local file path or remote url
     * 
     * @return
     *      A Dom object with the HTML parsed
     */ 
    public static function build($file) {
        
        $html = parent::buildFromFile($file);
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
        
        $dom = new PurgeHtmlCrawler($html);
        
        return $dom;
    }

}


1			<?php
2
3
4
5			namespace Katten\Purge\Factory;
6
7
8			use Katten\Purge\PurgeHtmlCrawler;
9			use Katten\Purge\Exceptions\UnableToReadInFileException;
10
11
12			class DomFactory extends FileFactory {
13
14
15			/**
16			* Build a preloaded Dom object
17			*
18			* @param string $file
19			* A local file path or remote url
20			*
21			* @return
22			* A Dom object with the HTML parsed
23			*/
24			public static function build($file) {
25
26			$html = parent::buildFromFile($file);
			0 ignored issues – show Comprehensibility Bug introduced 2019-05-10 05:44 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`buildFromFile()` instead of `build()`). Are you sure this is correct? If so, you might want to change this to `$this->buildFromFile()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
27
28			$dom = new PurgeHtmlCrawler($html);
29
30			return $dom;
31			}
32
33			}
34

FrancisBaileyH / Purge

GitHub Access Token became invalid

DomFactory::build() A last analyzed 2019-05-10 05:44 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

DomFactory::build() A
last analyzed 2019-05-10 05:44 UTC