CashVoucherPdfModel - Code Metrics - Fousky/iDoklad - Measure and Improve Code Quality continuously with Scrutinizer

CashVoucherPdfModel A
last analyzed 2019-12-20 15:37 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	30
Duplicated Lines	100 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes

Metric	Value
wmc	2
lcom	1
cbo	3
dl	30
loc	30
rs	10
c	0
b	0
f	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	createFromResponse()	9	9	1
A	save()	4	4	1

How to fix Duplicated Code

<?php

namespace Fousky\Component\iDoklad\Model\CashVoucher;

use Fousky\Component\iDoklad\Model\iDokladAbstractModel;
use Fousky\Component\iDoklad\Model\iDokladModelInterface;
use Psr\Http\Message\ResponseInterface;

/**
 * @author Lukáš Brzák <[email protected]>
 */
class CashVoucherPdfModel extends iDokladAbstractModel

{
    /** @var null|string $pdf Raw Base64 ALREADY DECODED data. */
    public $pdf;

    /**
     * @param ResponseInterface $response
     *
     * @return iDokladModelInterface
     */
    public static function createFromResponse(ResponseInterface $response): iDokladModelInterface
    {
        $raw = $response->getBody()->getContents();

        $model = new static();
        $model->pdf = base64_decode($raw);

        return $model;
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }

    /**
     * @param string $fileName
     *
     * @return bool If saving was successfully
     */
    public function save(string $fileName): bool
    {
        return false !== file_put_contents($fileName, $this->pdf);
    }
}


1		<?php
2
3		namespace Fousky\Component\iDoklad\Model\CashVoucher;
4
5		use Fousky\Component\iDoklad\Model\iDokladAbstractModel;
6		use Fousky\Component\iDoklad\Model\iDokladModelInterface;
7		use Psr\Http\Message\ResponseInterface;
8
9		/**
10		* @author Lukáš Brzák <[email protected]>
11		*/
12	View Code Duplication	class CashVoucherPdfModel extends iDokladAbstractModel
		0 ignored issues – show Duplication introduced 2017-08-20 18:35 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
13		{
14		/** @var null\|string $pdf Raw Base64 ALREADY DECODED data. */
15		public $pdf;
16
17		/**
18		* @param ResponseInterface $response
19		*
20		* @return iDokladModelInterface
21		*/
22		public static function createFromResponse(ResponseInterface $response): iDokladModelInterface
23		{
24		$raw = $response->getBody()->getContents();
25
26		$model = new static();
27		$model->pdf = base64_decode($raw);
28
29		return $model;
		0 ignored issues – show Bug Best Practice introduced 2017-11-10 03:46 UTC by Report Bug Copy Issue Report The return type of `return $model;` (`Fousky\Component\iDoklad...her\CashVoucherPdfModel`) is incompatible with the return type declared by the interface `Fousky\Component\iDoklad...ace::createFromResponse` of type `self`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
30		}
31
32		/**
33		* @param string $fileName
34		*
35		* @return bool If saving was successfully
36		*/
37		public function save(string $fileName): bool
38		{
39		return false !== file_put_contents($fileName, $this->pdf);
40		}
41		}
42

Fousky / iDoklad

CashVoucherPdfModel A last analyzed 2019-12-20 15:37 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

2 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like

CashVoucherPdfModel A
last analyzed 2019-12-20 15:37 UTC