Conditions | 1 |
Paths | 1 |
Total Lines | 119 |
Code Lines | 108 |
Lines | 0 |
Ratio | 0 % |
Changes | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
111 | public function __construct(\Twig_Environment $env) |
||
112 | { |
||
113 | parent::__construct($env); |
||
114 | |||
115 | $this->typeCompilers = array( |
||
116 | 'Twig_Node' => new NodeCompiler(), |
||
117 | 'Twig_Node_Body' => new BodyCompiler(), |
||
118 | 'Twig_Node_Module' => new ModuleCompiler\GoogleCompiler(), |
||
119 | 'Twig_Node_Block' => new BlockCompiler(), |
||
120 | 'Twig_Node_Text' => new TextCompiler(), |
||
121 | 'Twig_Node_If' => new IfCompiler(), |
||
122 | 'Twig_Node_Print' => new PrintCompiler(), |
||
123 | 'Twig_Node_For' => new ForCompiler(), |
||
124 | 'Twig_Node_ForLoop' => new ForLoopCompiler(), |
||
125 | 'Twig_Node_Set' => new SetCompiler(), |
||
126 | 'Twig_Node_Include' => new IncludeCompiler(), |
||
127 | 'Twig_Node_Spaceless' => new SpacelessCompiler(), |
||
128 | 'Twig_Node_SetTemp' => new SetTempCompiler(), |
||
129 | 'Twig_Node_ExtensionReference' => new ExtensionReferenceCompiler(), |
||
130 | 'Twig_Node_BlockReference' => new BlockReferenceCompiler(), |
||
131 | 'Twig_Node_AutoEscape' => new AutoEscapeCompiler(), |
||
132 | 'Twig_Node_Import' => new ImportCompiler(), |
||
133 | 'Twig_Node_Macro' => new MacroCompiler(), |
||
134 | 'Twig_Node_Expression_TempName' => new TempNameCompiler(), |
||
135 | 'Twig_Node_Expression_DefaultFilter' => new DefaultFilterCompiler(), |
||
136 | 'Twig_Node_Expression_ExtensionReference' => new ExpressionExtensionReferenceCompiler(), |
||
137 | 'Twig_Node_Expression_Conditional' => new ConditionalCompiler(), |
||
138 | 'Twig_Node_Expression_Array' => new ArrayCompiler(), |
||
139 | 'Twig_Node_Expression_Function' => new FunctionCompiler(), |
||
140 | 'Twig_Node_Expression_Parent' => new ParentCompiler(), |
||
141 | 'Twig_Node_Expression_BlockReference' => new ExpressionBlockReferenceCompiler(), |
||
142 | 'Twig_Node_Expression_AssignName' => new AssignNameCompiler(), |
||
143 | 'Twig_Node_Expression_Test' => new TestCompiler(), |
||
144 | 'Twig_Node_Expression_Name' => new NameCompiler(), |
||
145 | 'Twig_Node_Expression_Filter' => new FilterCompiler(), |
||
146 | 'Twig_Node_Expression_Filter_Default' => new Compiler\Expression\Filter\DefaultCompiler(), |
||
147 | 'Twig_Node_Expression_Constant' => new ConstantCompiler(), |
||
148 | 'Twig_Node_Expression_GetAttr' => new GetAttrCompiler(), |
||
149 | 'Twig_Node_Expression_MacroCall' => new Compiler\Expression\MacroCallCompiler(), |
||
150 | 'Twig_Node_Expression_MethodCall' => new Compiler\Expression\MethodCallCompiler(), |
||
151 | 'Twig_Node_Expression_Binary_Add' => new AddCompiler(), |
||
152 | 'Twig_Node_Expression_Binary_And' => new AndCompiler(), |
||
153 | 'Twig_Node_Expression_Binary_BitwiseAnd' => new BitwiseAndCompiler(), |
||
154 | 'Twig_Node_Expression_Binary_BitwiseOr' => new BitwiseOrCompiler(), |
||
155 | 'Twig_Node_Expression_Binary_BitwiseXor' => new BitwiseXorCompiler(), |
||
156 | 'Twig_Node_Expression_Binary_Concat' => new ConcatCompiler(), |
||
157 | 'Twig_Node_Expression_Binary_Div' => new DivCompiler(), |
||
158 | 'Twig_Node_Expression_Binary_Equal' => new EqualCompiler(), |
||
159 | 'Twig_Node_Expression_Binary_FloorDiv' => new FloorDivCompiler(), |
||
160 | 'Twig_Node_Expression_Binary_Greater' => new GreaterCompiler(), |
||
161 | 'Twig_Node_Expression_Binary_GreaterEqual' => new GreaterEqualCompiler(), |
||
162 | 'Twig_Node_Expression_Binary_In' => new InCompiler(), |
||
163 | 'Twig_Node_Expression_Binary_Less' => new LessCompiler(), |
||
164 | 'Twig_Node_Expression_Binary_LessEqual' => new LessEqualCompiler(), |
||
165 | 'Twig_Node_Expression_Binary_Mod' => new ModCompiler(), |
||
166 | 'Twig_Node_Expression_Binary_Mul' => new MulCompiler(), |
||
167 | 'Twig_Node_Expression_Binary_NotEqual' => new NotEqualCompiler(), |
||
168 | 'Twig_Node_Expression_Binary_NotIn' => new NotInCompiler(), |
||
169 | 'Twig_Node_Expression_Binary_Or' => new OrCompiler(), |
||
170 | 'Twig_Node_Expression_Binary_Power' => new PowerCompiler(), |
||
171 | 'Twig_Node_Expression_Binary_Range' => new RangeCompiler(), |
||
172 | 'Twig_Node_Expression_Binary_Sub' => new SubCompiler(), |
||
173 | 'Twig_Node_Expression_Unary_Neg' => new NegCompiler(), |
||
174 | 'Twig_Node_Expression_Unary_Not' => new NotCompiler(), |
||
175 | 'Twig_Node_Expression_Unary_Pos' => new PosCompiler(), |
||
176 | 'Twig_Node_Expression_Test_Constant' => new Compiler\Expression\Test\ConstantCompiler(), |
||
177 | 'Twig_Node_Expression_Test_Defined' => new Compiler\Expression\Test\DefinedCompiler(), |
||
178 | 'Twig_Node_Expression_Test_Divisibleby' => new Compiler\Expression\Test\DivisiblebyCompiler(), |
||
179 | 'Twig_Node_Expression_Test_Even' => new Compiler\Expression\Test\EvenCompiler(), |
||
180 | 'Twig_Node_Expression_Test_Null' => new Compiler\Expression\Test\NullCompiler(), |
||
181 | 'Twig_Node_Expression_Test_Odd' => new Compiler\Expression\Test\OddCompiler(), |
||
182 | 'Twig_Node_Expression_Test_Sameas' => new Compiler\Expression\Test\SameasCompiler(), |
||
183 | |||
184 | ); |
||
185 | |||
186 | $this->testCompilers = array( |
||
187 | 'defined' => new DefinedCompiler(), |
||
188 | 'divisibleby' => new DivisibleByCompiler(), |
||
189 | 'empty' => new EmptyCompiler(), |
||
190 | 'even' => new EvenCompiler(), |
||
191 | 'none' => new NoneCompiler(), |
||
192 | 'null' => new NullCompiler(), |
||
193 | 'odd' => new OddCompiler(), |
||
194 | 'sameas' => new SameAsCompiler(), |
||
195 | ); |
||
196 | |||
197 | $this->filterCompilers = array(); |
||
198 | $this->filterFunctions = array( |
||
199 | '_default' => 'twig.filter.def', |
||
200 | 'abs' => 'twig.filter.abs', |
||
201 | 'batch' => 'twig.filter.batch', |
||
202 | 'capitalize' => 'twig.filter.capitalize', |
||
203 | 'default' => 'twig.filter.def', |
||
204 | 'e' => 'twig.filter.escape', |
||
205 | 'escape' => 'twig.filter.escape', |
||
206 | 'first' => 'twig.filter.first', |
||
207 | 'join' => 'twig.filter.join', |
||
208 | 'json_encode' => 'twig.filter.json_encode', |
||
209 | 'keys' => 'twig.filter.keys', |
||
210 | 'last' => 'twig.filter.last', |
||
211 | 'length' => 'twig.filter.length', |
||
212 | 'lower' => 'twig.filter.lower', |
||
213 | 'merge' => 'twig.filter.merge', |
||
214 | 'nl2br' => 'twig.filter.nl2br', |
||
215 | 'replace' => 'twig.filter.replace', |
||
216 | 'reverse' => 'twig.filter.reverse', |
||
217 | 'title' => 'twig.filter.title', |
||
218 | 'trim' => 'twig.filter.trim', |
||
219 | 'upper' => 'twig.filter.upper', |
||
220 | 'url_encode' => 'encodeURIComponent', |
||
221 | ); |
||
222 | |||
223 | $this->functionMap = array( |
||
224 | 'max' => 'twig.functions.max', |
||
225 | 'min' => 'twig.functions.min', |
||
226 | 'random' => 'twig.functions.random', |
||
227 | 'range' => 'twig.range', |
||
228 | ); |
||
229 | } |
||
230 | |||
409 |
This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function.
Consider the following example. The parameter
$italy
is not defined by the methodfinale(...)
.The most likely cause is that the parameter was removed, but the annotation was not.