IfCompiler::compile() - Code Metrics - ForkNetwork/twig.js - Measure and Improve Code Quality continuously with Scrutinizer

IfCompiler::compile() B
last analyzed 2016-11-28 10:32 UTC

↳ Parent: IfCompiler

Complexity

Conditions	6
Paths	7

Size

Total Lines	40
Code Lines	26

Duplication

Lines	8
Ratio	20 %

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	8
loc	40
rs	8.439
cc	6
eloc	26
nc	7
nop	2

<?php

/*
 * Copyright 2011 Johannes M. Schmitt <[email protected]>
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 * http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */

namespace TwigJs\Compiler;

use TwigJs\JsCompiler;
use TwigJs\TypeCompilerInterface;

class IfCompiler implements TypeCompilerInterface
{
    public function getType()
    {
        return 'Twig_Node_If';
    }

    public function compile(JsCompiler $compiler, \Twig_NodeInterface $node)
    {
        if (!$node instanceof \Twig_Node_If) {
            throw new \RuntimeException(sprintf('$node must be an instanceof of \If, but got "%s".', get_class($node)));
        }

        $compiler->addDebugInfo($node);
        for ($i = 0; $i < count($node->getNode('tests')); $i += 2) {
for ($i=0; $i<count($array); $i++) { // calls count() on each iteration
}

// Better
for ($i=0, $c=count($array); $i<$c; $i++) { // calls count() just once
}
            if ($i > 0) {
                $compiler
                    ->outdent()
                    ->write("} else if (")
                ;
            } else {
                $compiler
                    ->write('if (')
                ;
            }

            $compiler
                ->subcompile($node->getNode('tests')->getNode($i))
                ->raw(") {\n")
                ->indent()
                ->subcompile($node->getNode('tests')->getNode($i + 1))
            ;
        }

        if ($node->hasNode('else') && null !== $node->getNode('else')) {

            $compiler
                ->outdent()
                ->write("} else {\n")
                ->indent()
                ->subcompile($node->getNode('else'))
            ;
        }

        $compiler
            ->outdent()
            ->write("}\n");
    }
}


1		<?php
2
3		/*
4		* Copyright 2011 Johannes M. Schmitt <[email protected]>
5		*
6		* Licensed under the Apache License, Version 2.0 (the "License");
7		* you may not use this file except in compliance with the License.
8		* You may obtain a copy of the License at
9		*
10		* http://www.apache.org/licenses/LICENSE-2.0
11		*
12		* Unless required by applicable law or agreed to in writing, software
13		* distributed under the License is distributed on an "AS IS" BASIS,
14		* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
15		* See the License for the specific language governing permissions and
16		* limitations under the License.
17		*/
18
19		namespace TwigJs\Compiler;
20
21		use TwigJs\JsCompiler;
22		use TwigJs\TypeCompilerInterface;
23
24		class IfCompiler implements TypeCompilerInterface
25		{
26		public function getType()
27		{
28		return 'Twig_Node_If';
29		}
30
31		public function compile(JsCompiler $compiler, \Twig_NodeInterface $node)
32		{
33		if (!$node instanceof \Twig_Node_If) {
34		throw new \RuntimeException(sprintf('$node must be an instanceof of \If, but got "%s".', get_class($node)));
35		}
36
37		$compiler->addDebugInfo($node);
38		for ($i = 0; $i < count($node->getNode('tests')); $i += 2) {
		0 ignored issues – show Performance Best Practice introduced 2016-11-25 14:46 UTC by Report Bug Copy Issue Report It seems like you are calling the size function `count()` as part of the test condition. You might want to compute the size beforehand, and not on each iteration. If the size of the collection does not change during the iteration, it is generally a good practice to compute it beforehand, and not on each iteration: for ($i=0; $i<count($array); $i++) { // calls count() on each iteration } // Better for ($i=0, $c=count($array); $i<$c; $i++) { // calls count() just once } Loading history...
39		if ($i > 0) {
40		$compiler
41		->outdent()
42		->write("} else if (")
43		;
44		} else {
45		$compiler
46		->write('if (')
47		;
48		}
49
50		$compiler
51		->subcompile($node->getNode('tests')->getNode($i))
52		->raw(") {\n")
53		->indent()
54		->subcompile($node->getNode('tests')->getNode($i + 1))
55		;
56		}
57
58	View Code Duplication	if ($node->hasNode('else') && null !== $node->getNode('else')) {
		0 ignored issues – show Duplication introduced 2016-11-25 14:46 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
59		$compiler
60		->outdent()
61		->write("} else {\n")
62		->indent()
63		->subcompile($node->getNode('else'))
64		;
65		}
66
67		$compiler
68		->outdent()
69		->write("}\n");
70		}
71		}
72

ForkNetwork / twig.js

GitHub Access Token became invalid

IfCompiler::compile() B last analyzed 2016-11-28 10:32 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

IfCompiler::compile() B
last analyzed 2016-11-28 10:32 UTC