ForkNetwork / guzzle3

src/Guzzle/Http/Url.php

Doc Comments +4 added lines, -1 removed lines

@@ -116,7 +116,7 @@ 
      * @param string                   $password Password of the URL
      * @param int                      $port     Port of the URL
      * @param string                   $path     Path of the URL
-     * @param QueryString|array|string $query    Query string of the URL
+     * @param QueryString $query    Query string of the URL
      * @param string                   $fragment Fragment of the URL
      */
     public function __construct($scheme, $host, $username = null, $password = null, $port = null, $path = null, QueryString $query = null, $fragment = null)
@@ -543,6 +543,9 @@ 
         return $this;
     }
 
+    /**
+     * @param boolean $strictRfc386
+     */
     private function addQuery(QueryString $new, $strictRfc386)
     {
         if (!$strictRfc386) {

Spacing +2 added lines, -2 removed lines

@@ -72,7 +72,7 @@ 
                 if (isset($parts['pass'])) {
                     $url .= ':' . $parts['pass'];
                 }
-                $url .=  '@';
+                $url .= '@';
             }
 
             $url .= $parts['host'];
@@ -88,7 +88,7 @@ 
         // Add the path component if present
         if (isset($parts['path']) && 0 !== strlen($parts['path'])) {
             // Always ensure that the path begins with '/' if set and something is before the path
-            if ($url && $parts['path'][0] != '/' && substr($url, -1)  != '/') {
+            if ($url && $parts['path'][0] != '/' && substr($url, -1) != '/') {
                 $url .= '/';
             }
             $url .= $parts['path'];

src/Guzzle/Plugin/Cache/DefaultCacheStorage.php

Doc Comments +1 added lines, -1 removed lines

@@ -25,7 +25,7 @@
     protected $defaultTtl;
 
     /**
-     * @param mixed  $cache      Cache used to store cache data
+     * @param CacheAdapterInterface  $cache      Cache used to store cache data
      * @param string $keyPrefix  Provide an optional key prefix to prefix on all cache keys
      * @param int    $defaultTtl Default cache TTL
      */

Spacing +1 added lines, -1 removed lines

@@ -259,7 +259,7 @@
         $headers = $message->getHeaders()->getAll();
         $headers = array_diff_key($headers, $noCache);
         // Cast the headers to a string
-        $headers = array_map(function ($h) { return (string) $h; }, $headers);
+        $headers = array_map(function($h) { return (string) $h; }, $headers);
 
         return $headers;
     }

src/Guzzle/Plugin/Cookie/Cookie.php

Doc Comments +1 added lines, -1 removed lines

@@ -24,7 +24,7 @@
     /**
      * Gets an array of invalid cookie characters
      *
-     * @return array
+     * @return string
      */
     protected static function getInvalidCharacters()
     {

src/Guzzle/Plugin/Md5/Md5ValidatorPlugin.php

Doc Comments +1 added lines, -1 removed lines

@@ -24,7 +24,7 @@
      *                                      applied is a more expensive comparison because the entity body will need to
      *                                      be compressed in order to get the correct hash.  Set to FALSE to not
      *                                      validate the MD5 hash of an entity body with an applied Content-Encoding.
-     * @param bool|int $contentLengthCutoff Maximum Content-Length (bytes) in which a MD5 hash will be validated. Any
+     * @param boolean $contentLengthCutoff Maximum Content-Length (bytes) in which a MD5 hash will be validated. Any
      *                                      response with a Content-Length greater than this value will not be validated
      *                                      because it will be deemed too memory intensive.
      */

src/Guzzle/Plugin/Oauth/OauthPlugin.php

Doc Comments +5 added lines, -5 removed lines

@@ -69,7 +69,7 @@ 
      * Request before-send event handler
      *
      * @param Event $event Event received
-     * @return array
+     * @return Collection
      * @throws \InvalidArgumentException
      */
     public function onRequestBeforeSend(Event $event)
@@ -105,7 +105,7 @@ 
     /**
      * Builds the Authorization header for a request
      *
-     * @param array $authorizationParams Associative array of authorization parameters
+     * @param Collection $authorizationParams Associative array of authorization parameters
      *
      * @return string
      */
@@ -168,8 +168,8 @@ 
     /**
      * Get the oauth parameters as named by the oauth spec
      *
-     * @param $timestamp
-     * @param $nonce
+     * @param integer $timestamp
+     * @param string $nonce
      * @return Collection
      */
     protected function getOauthParams($timestamp, $nonce)
@@ -237,7 +237,7 @@ 
      * overwritten e.g. the Flickr API incorrectly adds the post fields when the Content-Type
      * is 'application/x-www-form-urlencoded'
      *
-     * @param $request
+     * @param RequestInterface $request
      * @return bool Whether the post fields should be signed or not
      */
     public function shouldPostFieldsBeSigned($request)

Unused Use Statements -1 removed lines

@@ -6,7 +6,6 @@
 use Guzzle\Common\Collection;
 use Guzzle\Http\Message\RequestInterface;
 use Guzzle\Http\Message\EntityEnclosingRequestInterface;
-use Guzzle\Http\QueryString;
 use Guzzle\Http\Url;
 use Symfony\Component\EventDispatcher\EventSubscriberInterface;
 

Indentation +3 added lines, -3 removed lines

@@ -161,8 +161,8 @@ 
         $url = Url::factory($request->getUrl())->setQuery('')->setFragment(null);
 
         return strtoupper($request->getMethod()) . '&'
-             . rawurlencode($url) . '&'
-             . rawurlencode((string) $parameterString);
+                . rawurlencode($url) . '&'
+                . rawurlencode((string) $parameterString);
     }
 
     /**
@@ -274,7 +274,7 @@ 
      */
     public function getTimestamp(Event $event)
     {
-       return $event['timestamp'] ?: time();
+        return $event['timestamp'] ?: time();
     }
 
     /**

Spacing +1 added lines, -1 removed lines

@@ -78,7 +78,7 @@
         $request = $event['request'];
         $nonce = $this->generateNonce($request);
         $authorizationParams = $this->getOauthParams($timestamp, $nonce);
-        $authorizationParams['oauth_signature']  = $this->getSignature($request, $timestamp, $nonce);
+        $authorizationParams['oauth_signature'] = $this->getSignature($request, $timestamp, $nonce);
 
         switch ($this->config['request_method']) {
             case self::REQUEST_METHOD_HEADER:

src/Guzzle/Service/Client.php

Doc Comments +2 added lines, -2 removed lines

@@ -68,7 +68,7 @@ 
      * @param string $method Name of the command object to instantiate
      * @param array  $args   Arguments to pass to the command
      *
-     * @return mixed Returns the result of the command
+     * @return \Guzzle\Http\Message\Response Returns the result of the command
      * @throws BadMethodCallException when a command is not found
      */
     public function __call($method, $args)
@@ -181,7 +181,7 @@ 
     /**
      * Get the inflector used with the client
      *
-     * @return self
+     * @return InflectorInterface
      */
     public function getInflector()
     {

src/Guzzle/Service/Command/Factory/CompositeFactory.php

Doc Comments +1 added lines, -1 removed lines

@@ -32,7 +32,7 @@
     }
 
     /**
-     * @param array $factories Array of command factories
+     * @param ConcreteClassFactory[] $factories Array of command factories
      */
     public function __construct(array $factories = array())
     {

src/Guzzle/Service/Command/LocationVisitor/Request/XmlVisitor.php

Doc Comments +1 added lines, -1 removed lines

@@ -207,7 +207,7 @@
      *
      * @param \XMLWriter $xmlWriter
      *
-     * @return \string the writer resource
+     * @return string the writer resource
      */
     protected function finishDocument($xmlWriter)
     {

Spacing +1 added lines, -1 removed lines

@@ -97,7 +97,7 @@
             foreach ((array) $root['namespaces'] as $prefix => $uri) {
                 $nsLabel = 'xmlns';
                 if (!is_numeric($prefix)) {
-                    $nsLabel .= ':'.$prefix;
+                    $nsLabel .= ':' . $prefix;
                 }
                 $xmlWriter->writeAttribute($nsLabel, $uri);
             }

src/Guzzle/Service/Command/OperationResponseParser.php

Unused Use Statements -1 removed lines

@@ -7,7 +7,6 @@
 use Guzzle\Service\Command\LocationVisitor\Response\ResponseVisitorInterface;
 use Guzzle\Service\Description\Parameter;
 use Guzzle\Service\Description\OperationInterface;
-use Guzzle\Service\Description\Operation;
 use Guzzle\Service\Exception\ResponseClassException;
 use Guzzle\Service\Resource\Model;