JsonTable\Validate\Format\NumberValidator::formatCurrency()

Complexity

Conditions	2
Paths	2

Size

Total Lines	14
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	4
CRAP Score	2.032

Importance

Changes	2
Bugs	0	Features	0

<?php
    protected function formatCurrency()
    {
        // Remove any non-digits from the input.
        //TODO: Validate that any non-digits are valid currency characters.
        $input = preg_filter('/^\D./', '', $this->input);

        if (empty($input)) {
            return true;
        }

        // Check that the remainder of the input matches an expected currency format.
        // This regex is provided by Tim Pietzcker here: http://stackoverflow.com/a/4983648.
        return (true == preg_match('/\b\d{1,3}(?:,?\d{3})*(?:\.\d{2})?\b/', $input));

It seems like you are loosely comparing preg_match('/\\b\\d{1,3}(?:,?\\d{3})*(?:\\.\\d{2})?\\b/', $input) of type integer to the boolean true. If you are specifically checking for non-zero, consider using something more explicit like > 0 or !== 0 instead.

    }
}