JsonTable\Validate\Format\DatetimeValidator::formatDefault()

Complexity

Conditions	5
Paths	5

Size

Total Lines	23
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	8
CRAP Score	5.2

Importance

Changes	1
Bugs	0	Features	0

<?php
    protected function formatDefault()
    {
        // Check if this is an ISO8601 datetime format (in the UTC timezone).
        if (true == preg_match('/^(\d{4})-(\d{2})-(\d{2})T(\d{2}):(\d{2}):(\d{2})Z$/', $this->input)) {

It seems like you are loosely comparing preg_match('/^(\\d{4})-(\\d{2})-(\\d{2})T(\\d{2}):(\\d{2}):(\\d{2})Z$/', $this->input) of type integer to the boolean true. If you are specifically checking for non-zero, consider using something more explicit like > 0 or !== 0 instead.

            // Check that PHP can build a date object from the input.
            return (false !== \DateTime::createFromFormat(DATE_ISO8601, $this->input));
        }

        if ($this->formatDate('Y-m-d H:i:s')) {
            return true;
        }

        if ($this->formatDate('Y-m-d')) {
            return true;
        }

        if ($this->formatDate('H:i:s')) {
            return true;
        }

        // The input didn't match any of the expected formats.
        return false;
    }