DatetimeValidator::formatDate() - Code Metrics - Inspection of "Re-added failing test as it now has a valid mock t..." - FootworkSolutions/json_table - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 163405...503637 )

by George

created 2016-04-13 16:24 UTC

DatetimeValidator::formatDate() A

↳ Parent: DatetimeValidator

Complexity

Conditions	2
Paths	2

Size

Total Lines	6
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	3
CRAP Score	2

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
c	2
b	0
f	0
dl	0
loc	6
ccs	3
cts	3
cp	1
rs	9.4285
cc	2
eloc	3
nc	2
nop	1
crap	2

<?php
namespace JsonTable\Validate\Format;

use \JsonTable\Validate\AbstractFormatValidator;

/**
 * Lexical datetime validator.
 *
 * @package JSON table
 */
class DatetimeValidator extends AbstractFormatValidator
{
    /**
     * Validate that the input is a valid ISO8601 formatted date.
     *
     * @access  protected
     *
     * @return  boolean Whether the input is valid.
     */
    protected function formatDefault()
    {
        // Check if this is an ISO8601 datetime format (in the UTC timezone).
        if (true == preg_match('/^(\d{4})-(\d{2})-(\d{2})T(\d{2}):(\d{2}):(\d{2})Z$/', $this->input)) {

            // Check that PHP can build a date object from the input.
            return (false !== \DateTime::createFromFormat(DATE_ISO8601, $this->input));
        }

        if ($this->formatDate('Y-m-d H:i:s')) {
            return true;
        }

        if ($this->formatDate('Y-m-d')) {
            return true;
        }

        if ($this->formatDate('H:i:s')) {
            return true;
        }

        // The input didn't match any of the expected formats.
        return false;
    }


    /**
     * Validate that the input is a valid date in the specified format.
     *
     * @access  protected
     *
     * @param   string   $format   The date format to validate against.
     *
     * @return  boolean            Whether the input is valid.
     */
    protected function formatDate($format)
    {
        $date = \DateTime::createFromFormat($format, $this->input);

        return $date && ($date->format($format) === $this->input);
    }
}


1		<?php
2		namespace JsonTable\Validate\Format;
3
4		use \JsonTable\Validate\AbstractFormatValidator;
5
6		/**
7		* Lexical datetime validator.
8		*
9		* @package JSON table
10		*/
11		class DatetimeValidator extends AbstractFormatValidator
12		{
13		/**
14		* Validate that the input is a valid ISO8601 formatted date.
15		*
16		* @access protected
17		*
18		* @return boolean Whether the input is valid.
19		*/
20	1	protected function formatDefault()
21		{
22		// Check if this is an ISO8601 datetime format (in the UTC timezone).
23	1	if (true == preg_match('/^(\d{4})-(\d{2})-(\d{2})T(\d{2}):(\d{2}):(\d{2})Z$/', $this->input)) {
		0 ignored issues – show Bug Best Practice introduced 2016-02-28 18:09 UTC by Report Bug Copy Issue Report It seems like you are loosely comparing `preg_match('/^(\\d{4})-(...{2})Z$/', $this->input)` of type `integer` to the boolean `true`. If you are specifically checking for non-zero, consider using something more explicit like `> 0` or `!== 0` instead. Loading history...
24		// Check that PHP can build a date object from the input.
25		return (false !== \DateTime::createFromFormat(DATE_ISO8601, $this->input));
26		}
27
28	1	if ($this->formatDate('Y-m-d H:i:s')) {
29	1	return true;
30		}
31
32	1	if ($this->formatDate('Y-m-d')) {
33	1	return true;
34		}
35
36	1	if ($this->formatDate('H:i:s')) {
37	1	return true;
38		}
39
40		// The input didn't match any of the expected formats.
41		return false;
42		}
43
44
45		/**
46		* Validate that the input is a valid date in the specified format.
47		*
48		* @access protected
49		*
50		* @param string $format The date format to validate against.
51		*
52		* @return boolean Whether the input is valid.
53		*/
54	1	protected function formatDate($format)
55		{
56	1	$date = \DateTime::createFromFormat($format, $this->input);
57
58	1	return $date && ($date->format($format) === $this->input);
59		}
60		}
61

FootworkSolutions / json_table

Push — master ( 163405...503637 )

DatetimeValidator::formatDate() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like