JsonTable\Analyse\Lexical

Complexity

Total Complexity

25

Size/Duplication

Total Lines	280
Duplicated Lines	5.71 %

Coupling/Cohesion

Components	1
Dependencies	1

Test Coverage

Coverage

52.44%

Importance

Changes	1
Bugs	0	Features	0

11 Methods

Rating	Name	Duplication	Size	Complexity
A	handleUnexpectedColumnCount()	0	6	1
A	handleInvalidMandatoryColumn()	0	7	1
A	handleInvalidFormat()	8	8	1
A	handleInvalidPattern()	8	8	1
C	validate()	0	47	10
A	checkRowHasExpectedColumnCount()	0	7	1
A	checkMandatoryColumnHasData()	0	8	2
A	validateSpecificFormat()	0	9	1
A	getColumnPattern()	0	7	3
A	validatePattern()	0	11	3
A	setRowsAnalysedStatistic()	0	4	1

<?php
namespace JsonTable\Analyse;

/**
 * Perform lexical analysis.
 * 
 * @package JsonTable
 */
class Lexical extends Analyse implements AnalyseInterface
{
    /**
     * @var string The description for fields with invalid formats.
     */
    const ERROR_INVALID_PATTERN = 'There are <strong>%d</strong> fields that don\'t have the correct pattern:';

    /**
     * @var string The description for fields with invalid formats.
     */
    const ERROR_INVALID_FORMAT = 'There are <strong>%d</strong> fields that don\'t have the correct format:';

    /**
     * @var array   The current CSV row being analysed.
     */
    private $currentCsvRow;

    /**
     * @var int The position of the CSV column currently being analysed.
     */
    private $csvColumnPosition;

    /**
     * @var int The position of the current CSV row row in the CSV file.
     */
    private $rowNumber;

    /**
     * @var object  The schema definition for the column currently being analysed.
     */
    private $schemaColumn;

    /**
     * @var int The number of columns in the currently analysed row.
     */
    private $columnCount;

    /**
     * @var int The number of columns expected in each row.
     * This is taken from the CSV header row.
     */
    private $expectedColumnCount;

    /**
     * @var string  The pattern to validate the current field against.
     */
    private $pattern;

    /**
     * @var string  The format to validate the current field against.
     */
    private $format;

    /**
     * @var bool    Whether the file is valid.
     */
    private $valid;


    /**
     * Validate that all fields are of the correct type, format and pattern.
     * This also checks that each CSV row has the expected number of columns.
     *
     * @access  public
     *
     * @return  boolean Is all data lexically valid.
     */
    public function validate()
    {
        $this->valid = true;
        $this->rowNumber = 1;

        parent::rewindFilePointerToFirstData();

It seems like you call parent on a different method (rewindFilePointerToFirstData() instead of validate()). Are you sure this is correct? If so, you might want to change this to $this->rewindFilePointerToFirstData().

        while ($this->currentCsvRow = parent::loopThroughFileRows()) {

It seems like you call parent on a different method (loopThroughFileRows() instead of validate()). Are you sure this is correct? If so, you might want to change this to $this->loopThroughFileRows().

            if (!$this->checkRowHasExpectedColumnCount()) {
                $this->handleUnexpectedColumnCount();
            }

            for ($this->csvColumnPosition = 0; $this->csvColumnPosition < $this->columnCount; $this->csvColumnPosition++) {
                $this->schemaColumn = $this->getSchemaColumnFromCsvColumnPosition($this->csvColumnPosition);

                if (!$this->checkMandatoryColumnHasData()) {
                    $this->handleInvalidMandatoryColumn();

                    if ($this->stopIfInvalid) {
                        return false;
                    }
                }

                if (!$this->validateSpecificFormat()) {
                    $this->handleInvalidFormat();

                    if ($this->stopIfInvalid) {
                        return false;
                    }
                }

                if (!$this->validatePattern()) {
                    $this->handleInvalidPattern();

                    if ($this->stopIfInvalid) {
                        return false;
                    }
                }
            }

            $this->rowNumber++;
        }

        $this->setRowsAnalysedStatistic();

        return $this->valid;
    }


    /**
     * Check that the specified row has the expected number of columns.
     * The expected number of columns is the number of columns in the CSV header row.
     *
     * @return boolean  Whether the current row has the expected number of columns.
     */
    private function checkRowHasExpectedColumnCount()
    {
        $this->columnCount = count($this->currentCsvRow);
        $this->expectedColumnCount = count(parent::$headerColumns);

        return ($this->expectedColumnCount === $this->columnCount);
    }


    /**
     * Set an error and update the application as the current row has an unexpected number of columns.
     *
     * @access  private
     *
     * @return  void
     */
    private function handleUnexpectedColumnCount()
    {
        $errorMessage = "Row $this->rowNumber has $this->columnCount columns but should have $this->expectedColumnCount.";
        $this->setError(Analyse::ERROR_INCORRECT_COLUMN_COUNT, $errorMessage);
        $this->statistics['rows_with_errors'][] = $this->rowNumber;
    }


    /**
     * Check whether the current column is mandatory and if so, whether it has data in it.
     *
     * @access  private
     *
     * @return  boolean Whether the column has data in it.
     */
    private function checkMandatoryColumnHasData()
    {
        if ($this->isColumnMandatory($this->schemaColumn)) {
            return ('' !== $this->currentCsvRow[$this->csvColumnPosition]);
        }

        return true;
    }


    /**
     * Set an error and update the application as the current column is mandatory and has no data in it.
     *
     * @access  private
     *
     * @return  void
     */
    private function handleInvalidMandatoryColumn()
    {
        $errorMessage = "$this->schemaColumn->name on row $this->rowNumber is missing.";
        $this->setError(Analyse::ERROR_REQUIRED_FIELD_MISSING_DATA, $errorMessage);
        $this->statistics['rows_with_errors'][] = $this->rowNumber;
        $this->valid = false;
    }


    /**
     * Check that the data in the current field is of a valid format as specified in the schema for this column.
     * This instantiates and passed the data to the format validator for this field type.
     *
     * @access  private
     *
     * @return  boolean Whether the current field is of a valid format.
     */
    private function validateSpecificFormat()
    {
        $type = $this->getColumnType($this->schemaColumn);
        $this->format = $this->getColumnFormat($this->schemaColumn);
        $validator = $this->instantiateValidator(Analyse::VALIDATION_TYPE_FORMAT, $type);
        $validator->setInput($this->currentCsvRow[$this->csvColumnPosition]);

        return $validator->validateFormat($this->format);
    }


    /**
     * Set an error and update the application as the current data didn't match the specified format.
     *
     * @access  private
     *
     * @return  void
     */
    private function handleInvalidFormat()

This method seems to be duplicated in your project.

    {
        $errorMessage  = "The data in column $this->schemaColumn->name on row $this->rowNumber doesn't ";
        $errorMessage .= "match the required format of $this->format.";
        $this->setError(self::ERROR_INVALID_FORMAT, $errorMessage);
        $this->statistics['rows_with_errors'][] = $this->rowNumber;
        $this->valid = false;
    }


    /**
     * Get the pattern of the specified column.
     *
     * @access  private
     *
     * @return  string  The pattern or null if no pattern is specified.
     */
    private function getColumnPattern()
    {
        $propertyExists = property_exists($this->schemaColumn, 'constraints') &&
            property_exists($this->schemaColumn->constraints, 'pattern');

        return $propertyExists ? $this->schemaColumn->constraints->pattern : null;
    }


    /**
     * Check that the input matches the specified pattern.
     *
     * @access  private
     *
     * @return  boolean Is the data valid.
     */
    private function validatePattern()
    {
        $this->pattern = $this->getColumnPattern();
        $input = $this->currentCsvRow[$this->csvColumnPosition];

        if (is_null($this->pattern) || '' === $input) {
            return true;
        }

        return (false !== filter_var($input, FILTER_VALIDATE_REGEXP, ['options' => ['regexp' => $this->pattern]]));
    }


    /**
     * Set an error and update the application as the current data didn't match the specified pattern.
     *
     * @access  private
     *
     * @return  void
     */
    private function handleInvalidPattern()

This method seems to be duplicated in your project.

    {
        $errorMessage  = "The data in column $this->schemaColumn->name on row $this->rowNumber doesn't ";
        $errorMessage .= "match the required pattern of $this->pattern.";
        $this->setError(self::ERROR_INVALID_PATTERN, $errorMessage);
        $this->statistics['rows_with_errors'][] = $this->rowNumber;
        $this->valid = false;
    }


    /**
     * Add the number of rows analysed to the statistics.
     *
     * @access  private
     *
     * @return  void
     */
    private function setRowsAnalysedStatistic()
    {
        $this->statistics['rows_analysed'] = ($this->rowNumber - 2);
    }
}