Str::initConfig() - Code Metrics - Inspection of "Minor bugfix for Scrutinizer configuration" - FlyingDR/struct - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 4cc6c2...176af1 )

by Alexander

created 2017-11-08 15:44 UTC

Str::initConfig() A

↳ Parent: Str

Complexity

Conditions	1
Paths	1

Size

Total Lines	7
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	7
ccs	0
cts	6
cp	0
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	4
nc	1
nop	0
crap	2

<?php

namespace Flying\Struct\Property;

/**
 * Structure property with string value
 */
class Str extends Property
{
    /**
     * {@inheritdoc}
     */
    public function validateConfig($name, &$value)

    {
        /** @noinspection DegradedSwitchInspection */
        switch ($name) {
            case 'maxlength':
                if ($value !== null) {
                    $value = max((int)$value, 1);
                }
                break;
            default:
                return parent::validateConfig($name, $value);
                break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
        }
        return true;
    }

    /**
     * {@inheritdoc}
     */
    protected function initConfig()
    {
        parent::initConfig();
        $this->mergeConfig([
            'maxlength' => null, // String length limitation
        ]);
    }

    /**
     * {@inheritdoc}
     * @throws \RuntimeException
     */
    protected function normalize(&$value)
    {
        if (!parent::normalize($value)) {
            return false;
        }
        if ($value === null) {
            return true;
        }
        if (!is_scalar($value)) {
            if (is_array($value)) {
                return false;
            }

            if (is_object($value)) {

                if (method_exists($value, 'toString')) {
                    $value = $value->toString();
                } elseif (method_exists($value, '__toString')) {
                    $value = (string)$value;
                } else {
                    return false;
                }
            }
        }
        $value = (string)$value;
        $maxlength = $this->getConfig('maxlength');
        if (($maxlength !== null) && (strlen($value) > $maxlength)) {
            $value = substr($value, 0, $maxlength);
        }
        return true;
    }
}


1			<?php
2
3			namespace Flying\Struct\Property;
4
5			/**
6			* Structure property with string value
7			*/
8			class Str extends Property
9			{
10			/**
11			* {@inheritdoc}
12			*/
13	186	View Code Duplication	public function validateConfig($name, &$value)
			0 ignored issues – show Duplication introduced 2017-11-08 15:48 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
14			{
15			/** @noinspection DegradedSwitchInspection */
16			switch ($name) {
17	186		case 'maxlength':
18	185		if ($value !== null) {
19	2		$value = max((int)$value, 1);
20	2		}
21	185		break;
22	186		default:
23	186		return parent::validateConfig($name, $value);
24			break;
			0 ignored issues – show Unused Code introduced 2017-11-08 15:48 UTC by Report Bug Copy Issue Report `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
25	186		}
26	185		return true;
27			}
28
29			/**
30			* {@inheritdoc}
31			*/
32			protected function initConfig()
33			{
34			parent::initConfig();
35			$this->mergeConfig([
36			'maxlength' => null, // String length limitation
37			]);
38			}
39
40			/**
41			* {@inheritdoc}
42			* @throws \RuntimeException
43			*/
44	186		protected function normalize(&$value)
45			{
46	186		if (!parent::normalize($value)) {
47			return false;
48			}
49	186		if ($value === null) {
50	125		return true;
51			}
52	185		if (!is_scalar($value)) {
53	4		if (is_array($value)) {
54	1		return false;
55			}
56
57	3	View Code Duplication	if (is_object($value)) {
			0 ignored issues – show Duplication introduced 2017-11-08 15:48 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
58	3		if (method_exists($value, 'toString')) {
59	1		$value = $value->toString();
60	3		} elseif (method_exists($value, '__toString')) {
61	1		$value = (string)$value;
62	1		} else {
63	1		return false;
64			}
65	2		}
66	2		}
67	185		$value = (string)$value;
68	185		$maxlength = $this->getConfig('maxlength');
69	185		if (($maxlength !== null) && (strlen($value) > $maxlength)) {
70	2		$value = substr($value, 0, $maxlength);
71	2		}
72	185		return true;
73			}
74			}
75

FlyingDR / struct

Push — master ( 4cc6c2...176af1 )

Str::initConfig() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like