Annotation::parseValues() - Code Metrics - Inspection of "- Annotation parser is updated to switch away from..." - FlyingDR/struct - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 83d554...edb865 )

by Alexander

created 2017-12-12 20:29 UTC

Annotation::parseValues() A

↳ Parent: Annotation

Complexity

Conditions	4
Paths	4

Size

Total Lines	11
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	8
CRAP Score	4

Importance

Changes

Metric	Value
dl	0
loc	11
ccs	8
cts	8
cp	1
rs	9.2
c	0
b	0
f	0
cc	4
eloc	6
nc	4
nop	1
crap	4

<?php

namespace Flying\Struct\Annotation;

use Doctrine\Common\Annotations\AnnotationException;

/**
 * Base class for structure annotations
 */
abstract class Annotation
{
    /**
     * Name of structure property
     *
     * @var string
     */
    private $name;

    /**
     * Class constructor
     *
     * @param array $values
     * @throws AnnotationException
     */
    public function __construct(array $values)
    {
        $this->parseValues($values);
    }

    /**
     * Parse given annotation values
     *
     * @param array $values
     * @throws AnnotationException
     * @return void
     */
    protected function parseValues(array &$values)
    {
        if (array_key_exists('name', $values)) {
            $this->name = $values['name'];
            unset($values['name']);
        }
        // Check if we got required properties
        if ((!is_string($this->name)) || ($this->name === '')) {
            throw new AnnotationException('Required property annotation is missed: name');
        }
    }

    /**
     * Get structure property name
     *
     * @return string
     */
    public function getName()
    {
        return $this->name;
    }
}


1		<?php
2
3		namespace Flying\Struct\Annotation;
4
5		use Doctrine\Common\Annotations\AnnotationException;
6
7		/**
8		* Base class for structure annotations
9		*/
10		abstract class Annotation
11		{
12		/**
13		* Name of structure property
14		*
15		* @var string
16		*/
17		private $name;
18
19		/**
20		* Class constructor
21		*
22		* @param array $values
23		* @throws AnnotationException
24		*/
25	190	public function __construct(array $values)
26		{
27	190	$this->parseValues($values);
28	187	}
29
30		/**
31		* Parse given annotation values
32		*
33		* @param array $values
34		* @throws AnnotationException
35		* @return void
36		*/
37	190	protected function parseValues(array &$values)
38		{
39	190	if (array_key_exists('name', $values)) {
40	189	$this->name = $values['name'];
41	189	unset($values['name']);
42	189	}
43		// Check if we got required properties
44	190	if ((!is_string($this->name)) \|\| ($this->name === '')) {
45	1	throw new AnnotationException('Required property annotation is missed: name');
46		}
47	189	}
48
49		/**
50		* Get structure property name
51		*
52		* @return string
53		*/
54	180	public function getName()
55		{
56	180	return $this->name;
57		}
58		}
59

FlyingDR / struct

Push — master ( 83d554...edb865 )

Annotation::parseValues() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like