DateTime::normalize() - Code Metrics - Inspection of "Minor bugfix for Scrutinizer configuration" - FlyingDR/struct - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 4cc6c2...176af1 )

by Alexander

created 2017-11-08 15:44 UTC

DateTime::normalize() D

↳ Parent: DateTime

Complexity

Conditions	9
Paths	13

Size

Total Lines	35
Code Lines	22

Duplication

Lines	9
Ratio	25.71 %

Code Coverage

Tests	22
CRAP Score	9.0066

Importance

Changes

Metric	Value
dl	9
loc	35
ccs	22
cts	23
cp	0.9565
rs	4.909
c	0
b	0
f	0
cc	9
eloc	22
nc	13
nop	1
crap	9.0066

<?php

namespace Flying\Struct\Property;

/**
 * Structure property with DateTime value
 */
class DateTime extends Property
{
    /**
     * {@inheritdoc}
     * @throws \RuntimeException
     */
    public function validateConfig($name, &$value)
    {
        switch ($name) {
            case 'format':
                if ((!is_string($value)) || ($value === '')) {
                    $value = null;
                }
                break;
            case 'default':
                if ($value === null) {
                    if (!$this->getConfig('nullable')) {
                        $value = new \DateTime();
                    }
                } elseif (is_string($value)) {
                    $value = new \DateTime($value);
                } elseif (!($value instanceof \DateTime)) {
                    return false;
                }
                break;
            default:
                return parent::validateConfig($name, $value);
                break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
        }
        return true;
    }

    /**
     * {@inheritdoc}
     * @throws \RuntimeException
     */
    protected function normalize(&$value)
    {
        if (!parent::normalize($value)) {
            return false;
        }
        if ($value === null) {
            return true;
        }

        if ($value instanceof \DateTime) {
            return true;
        }

        if (is_object($value)) {

            if (method_exists($value, 'toString')) {
                $value = $value->toString();
            } elseif (method_exists($value, '__toString')) {
                $value = (string)$value;
            } else {
                return false;
            }
        }

        if (!is_string($value)) {
            return false;
        }

        $format = $this->getConfig('format');
        if ($format) {
            $value = \DateTime::createFromFormat($format, $value);
        } else {
            $value = new \DateTime($value);
        }
        return true;
    }

    /**
     * {@inheritdoc}
     */
    protected function initConfig()
    {
        parent::initConfig();
        $this->mergeConfig([
            'format' => null, // Default format of date/time information to use for constructing DateTime object from string
        ]);
    }
}


1			<?php
2
3			namespace Flying\Struct\Property;
4
5			/**
6			* Structure property with DateTime value
7			*/
8			class DateTime extends Property
9			{
10			/**
11			* {@inheritdoc}
12			* @throws \RuntimeException
13			*/
14	21		public function validateConfig($name, &$value)
15			{
16			switch ($name) {
17	21		case 'format':
18	11		if ((!is_string($value)) \|\| ($value === '')) {
19	10		$value = null;
20	10		}
21	11		break;
22	21		case 'default':
23	21		if ($value === null) {
24	3		if (!$this->getConfig('nullable')) {
25	1		$value = new \DateTime();
26	1		}
27	21		} elseif (is_string($value)) {
28	15		$value = new \DateTime($value);
29	18		} elseif (!($value instanceof \DateTime)) {
30			return false;
31			}
32	21		break;
33	21		default:
34	21		return parent::validateConfig($name, $value);
35			break;
			0 ignored issues – show Unused Code introduced 2017-11-08 15:48 UTC by Report Bug Copy Issue Report `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
36	21		}
37	21		return true;
38			}
39
40			/**
41			* {@inheritdoc}
42			* @throws \RuntimeException
43			*/
44	21		protected function normalize(&$value)
45			{
46	21		if (!parent::normalize($value)) {
47			return false;
48			}
49	21		if ($value === null) {
50	2		return true;
51			}
52
53	19		if ($value instanceof \DateTime) {
54	12		return true;
55			}
56
57	14	View Code Duplication	if (is_object($value)) {
			0 ignored issues – show Duplication introduced 2017-11-08 15:48 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
58	3		if (method_exists($value, 'toString')) {
59	1		$value = $value->toString();
60	3		} elseif (method_exists($value, '__toString')) {
61	1		$value = (string)$value;
62	1		} else {
63	1		return false;
64			}
65	2		}
66
67	13		if (!is_string($value)) {
68	4		return false;
69			}
70
71	9		$format = $this->getConfig('format');
72	9		if ($format) {
73	1		$value = \DateTime::createFromFormat($format, $value);
74	1		} else {
75	8		$value = new \DateTime($value);
76			}
77	8		return true;
78			}
79
80			/**
81			* {@inheritdoc}
82			*/
83	1		protected function initConfig()
84			{
85	1		parent::initConfig();
86	1		$this->mergeConfig([
87	1		'format' => null, // Default format of date/time information to use for constructing DateTime object from string
88	1		]);
89	1		}
90			}
91

FlyingDR / struct

Push — master ( 4cc6c2...176af1 )

DateTime::normalize() D

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like