Issues in RabbitFish.php - Filtered Issues - Inspection of "Add an .editorconfig to help with formatting" - FluentDOM/FluentDOM - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( c562f3...3066ec )

by Thomas

created 2017-08-13 15:20 UTC

src/FluentDOM/Serializer/Json/RabbitFish.php (1 issue)

Labels

Bug 1

Severity

Minor 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 * Serialize a DOM to RabbitFish Json: http://www.bramstein.com/projects/xsltjson/
 *
 * @license http://www.opensource.org/licenses/mit-license.php The MIT License
 * @copyright Copyright (c) 2009-2017 FluentDOM Contributors
 */

namespace FluentDOM\Serializer\Json {

  use FluentDOM\DOM\Xpath;

  /**
   * Serialize a DOM to RabbitFish Json: http://www.bramstein.com/projects/xsltjson/
   *
   * @license http://www.opensource.org/licenses/mit-license.php The MIT License
   * @copyright Copyright (c) 2009-2017 FluentDOM Contributors
   */
  class RabbitFish extends BadgerFish {

    /**
     * @param \DOMElement $node
     * @return mixed
     */
    protected function getNodes(\DOMElement $node) {
      $xpath = new Xpath($node->ownerDocument);
      $hasText = $xpath->evaluate('count(text()[normalize-space(.) != ""]) > 0', $node);
      $hasElements = $xpath->evaluate('count(*) > 0', $node);
      $attributes = new \stdClass();
      $this->addAttributes($attributes, $node, $xpath);
      $this->addNamespaces($attributes, $node, $xpath);
      $attributes = (array)$attributes;
      if ($hasText && $hasElements) {
        return $this->getNodesArray($node, $attributes, $xpath);
      }
      if ($hasText && count($attributes) === 0) {
        return $node->nodeValue;
      }
      return parent::getNodes($node);
    }

    /**
     * @param \DOMElement $node
     * @param \stdClass|array $attributes
     * @param Xpath $xpath
     * @return array
     */
    private function getNodesArray(\DOMElement $node, $attributes, $xpath): array {
      $result = [];
      foreach ((array)$attributes as $name => $value) {
        $child = new \stdClass();
        $child->{$name} = $value;
        $result[] = $child;
      }
      $nodes = $xpath->evaluate('*|text()[normalize-space(.) != ""]', $node);
      foreach ($nodes as $childNode) {
$collection = json_decode($data, true);
if ( ! is_array($collection)) {
    throw new \RuntimeException('$collection must be an array.');
}

foreach ($collection as $item) { /** ... */ }
        /** @var \DOMElement|\DOMText|\DOMCdataSection $childNode */
        if ($childNode instanceof \DOMElement) {
          $child = new \stdClass();
          $child->{$childNode->nodeName} = $this->getNodes($childNode);
          $result[] = $child;
        } elseif (!$childNode->isWhitespaceInElementContent()) {
          $result[] = $childNode->nodeValue;
        }
      }
      return $result;
    }
  }
}

1		<?php
2		/**
3		* Serialize a DOM to RabbitFish Json: http://www.bramstein.com/projects/xsltjson/
4		*
5		* @license http://www.opensource.org/licenses/mit-license.php The MIT License
6		* @copyright Copyright (c) 2009-2017 FluentDOM Contributors
7		*/
8
9		namespace FluentDOM\Serializer\Json {
10
11		use FluentDOM\DOM\Xpath;
12
13		/**
14		* Serialize a DOM to RabbitFish Json: http://www.bramstein.com/projects/xsltjson/
15		*
16		* @license http://www.opensource.org/licenses/mit-license.php The MIT License
17		* @copyright Copyright (c) 2009-2017 FluentDOM Contributors
18		*/
19		class RabbitFish extends BadgerFish {
20
21		/**
22		* @param \DOMElement $node
23		* @return mixed
24		*/
25	9	protected function getNodes(\DOMElement $node) {
26	9	$xpath = new Xpath($node->ownerDocument);
27	9	$hasText = $xpath->evaluate('count(text()[normalize-space(.) != ""]) > 0', $node);
28	9	$hasElements = $xpath->evaluate('count(*) > 0', $node);
29	9	$attributes = new \stdClass();
30	9	$this->addAttributes($attributes, $node, $xpath);
31	9	$this->addNamespaces($attributes, $node, $xpath);
32	9	$attributes = (array)$attributes;
33	9	if ($hasText && $hasElements) {
34	2	return $this->getNodesArray($node, $attributes, $xpath);
35		}
36	9	if ($hasText && count($attributes) === 0) {
37	5	return $node->nodeValue;
38		}
39	6	return parent::getNodes($node);
40		}
41
42		/**
43		* @param \DOMElement $node
44		* @param \stdClass\|array $attributes
45		* @param Xpath $xpath
46		* @return array
47		*/
48	2	private function getNodesArray(\DOMElement $node, $attributes, $xpath): array {
49	2	$result = [];
50	2	foreach ((array)$attributes as $name => $value) {
51	1	$child = new \stdClass();
52	1	$child->{$name} = $value;
53	1	$result[] = $child;
54		}
55	2	$nodes = $xpath->evaluate('*\|text()[normalize-space(.) != ""]', $node);
56	2	foreach ($nodes as $childNode) {
		1 ignored issue – show Bug introduced 2017-08-02 18:25 UTC by Report Bug Copy Issue Report Show Similar Issues like this The expression `$nodes` of type `string\|double\|boolean\|object<DOMNodeList>` is not guaranteed to be traversable. How about adding an additional type check? There are different options of fixing this problem. If you want to be on the safe side, you can add an additional type-check: $collection = json_decode($data, true); if ( ! is_array($collection)) { throw new \RuntimeException('$collection must be an array.'); } foreach ($collection as $item) { /** ... / } If you are sure that the expression is traversable, you might want to add a doc comment cast* to improve IDE auto-completion and static analysis: /** @var array $collection / $collection = json_decode($data, true); foreach ($collection as $item) { /* .. / } Mark the issue as a false-positive*: Just hover the remove button, in the top-right corner of this issue for more options. Loading history...
57		/** @var \DOMElement\|\DOMText\|\DOMCdataSection $childNode */
58	2	if ($childNode instanceof \DOMElement) {
59	2	$child = new \stdClass();
60	2	$child->{$childNode->nodeName} = $this->getNodes($childNode);
61	2	$result[] = $child;
62	2	} elseif (!$childNode->isWhitespaceInElementContent()) {
63	2	$result[] = $childNode->nodeValue;
64		}
65		}
66	2	return $result;
67		}
68		}
69		}

FluentDOM / FluentDOM

Push — master ( c562f3...3066ec )

src/FluentDOM/Serializer/Json/RabbitFish.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like