Issues in ErrorController.php (master) - Issues in master - FloKnapp/faulancer - Measure and Improve Code Quality continuously with Scrutinizer

Issues (56)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Controller/ErrorController.php (1 issue)

Labels

Unused Code 1

Severity

Major 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Faulancer\Controller;

use Faulancer\Http\Request;
use Faulancer\Http\Response;
use Faulancer\Service\Config;

/**
 * Class ErrorAbstractController
 *
 * @category ErrorController
 * @package  Faulancer\Controller
 * @author   Florian Knapp <[email protected]>
 * @license  MIT License
 * @link     not provided
 */
class ErrorController extends Controller
{

    /**
     * The exception object
     *
     * @var \Exception
     */
    private $_exception;

    /**
     * ErrorController constructor.
     *
     * @param Request    $request The request object
     * @param \Exception $e       The given exception
     *
     * @codeCoverageIgnore
     */
    public function __construct(Request $request, $e)
    {
        parent::__construct($request);
        $this->_exception = $e;
    }

    /**
     * Decide if debug output or 404 page should be rendered
     *
     * @return Response
     *
     * @codeCoverageIgnore
     */
    public function displayError()
    {
        if (getenv('APPLICATION_ENV') === 'dev') {
            return $this->_renderDebugPage();
        }

        return $this->_renderNotFoundPage();
    }

    /**
     * Render the debug output
     *
     * @return Response
     *
     * @codeCoverageIgnore
     */
    private function _renderDebugPage()
    {
        $this->getView()->addStylesheet('/core/css/main.css');
        $this->getView()->addScript('/core/js/namespace.js');
        $this->getView()->addScript('/core/js/engine.js');
        $this->getView()->setTemplatePath(__DIR__ . '/../../template');

        $raiser = [
            'function'=> $this->_exception->getTrace()[0]['function'] ?? 'unknown',
            'message' => $this->_exception->getMessage(),
            'type'    => $this->_exception->getCode(),
            'file'    => $this->_exception->getFile(),
            'line'    => $this->_exception->getLine()
        ];

        $trace  = $this->_exception->getTrace();

        if (isset($trace[0]['line']) && $trace[0]['line'] !== $raiser['line']) {
            array_unshift($trace, $raiser);
        } else {
            array_shift($trace);
            array_unshift($trace, $raiser);
        }

        return $this->render(
            '/debug.phtml',
            [
                'exception' => $this->_exception,
                'trace' => $trace
            ]
        );
    }

    /**
     * Render a 404 page
     *
     * @return Response
     */
    private function _renderNotFoundPage()
    {
        /** @var Config $config */
        $config = $errorController = $this->getServiceLocator()->get(Config::class);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

        /** @var ErrorControllerInterface $errorController */
        $errorController = $config->get('customErrorController');

        if (in_array(ErrorControllerInterface::class, class_implements($errorController) ?? [])) {
            return (new $errorController($this->request))->notFoundAction();
        }

        die();
    }

}

1			<?php
2
3			namespace Faulancer\Controller;
4
5			use Faulancer\Http\Request;
6			use Faulancer\Http\Response;
7			use Faulancer\Service\Config;
8
9			/**
10			* Class ErrorAbstractController
11			*
12			* @category ErrorController
13			* @package Faulancer\Controller
14			* @author Florian Knapp <[email protected]>
15			* @license MIT License
16			* @link not provided
17			*/
18			class ErrorController extends Controller
19			{
20
21			/**
22			* The exception object
23			*
24			* @var \Exception
25			*/
26			private $_exception;
27
28			/**
29			* ErrorController constructor.
30			*
31			* @param Request $request The request object
32			* @param \Exception $e The given exception
33			*
34			* @codeCoverageIgnore
35			*/
36			public function __construct(Request $request, $e)
37			{
38			parent::__construct($request);
39			$this->_exception = $e;
40			}
41
42			/**
43			* Decide if debug output or 404 page should be rendered
44			*
45			* @return Response
46			*
47			* @codeCoverageIgnore
48			*/
49			public function displayError()
50			{
51			if (getenv('APPLICATION_ENV') === 'dev') {
52			return $this->_renderDebugPage();
53			}
54
55			return $this->_renderNotFoundPage();
56			}
57
58			/**
59			* Render the debug output
60			*
61			* @return Response
62			*
63			* @codeCoverageIgnore
64			*/
65			private function _renderDebugPage()
66			{
67			$this->getView()->addStylesheet('/core/css/main.css');
68			$this->getView()->addScript('/core/js/namespace.js');
69			$this->getView()->addScript('/core/js/engine.js');
70			$this->getView()->setTemplatePath(__DIR__ . '/../../template');
71
72			$raiser = [
73			'function'=> $this->_exception->getTrace()[0]['function'] ?? 'unknown',
74			'message' => $this->_exception->getMessage(),
75			'type' => $this->_exception->getCode(),
76			'file' => $this->_exception->getFile(),
77			'line' => $this->_exception->getLine()
78			];
79
80			$trace = $this->_exception->getTrace();
81
82			if (isset($trace[0]['line']) && $trace[0]['line'] !== $raiser['line']) {
83			array_unshift($trace, $raiser);
84			} else {
85			array_shift($trace);
86			array_unshift($trace, $raiser);
87			}
88
89			return $this->render(
90			'/debug.phtml',
91			[
92			'exception' => $this->_exception,
93			'trace' => $trace
94			]
95			);
96			}
97
98			/**
99			* Render a 404 page
100			*
101			* @return Response
102			*/
103			private function _renderNotFoundPage()
104			{
105			/** @var Config $config */
106			$config = $errorController = $this->getServiceLocator()->get(Config::class);
			0 ignored issues – show Unused Code introduced 2017-08-30 22:27 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$errorController` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
107
108			/** @var ErrorControllerInterface $errorController */
109			$errorController = $config->get('customErrorController');
110
111			if (in_array(ErrorControllerInterface::class, class_implements($errorController) ?? [])) {
112			return (new $errorController($this->request))->notFoundAction();
113			}
114
115			die();
116			}
117
118			}

FloKnapp / faulancer

Issues (56)

Security Analysis not enabled

src/Controller/ErrorController.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like