ArgumentParser::__construct() - Code Metrics - Inspection of "Merge pull request #13 from FloKnapp/feature-optim..." - FloKnapp/faulancer - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 4006e3...35fa08 )

by Flo

created 2017-01-20 11:38 UTC

ArgumentParser::__construct() A

↳ Parent: ArgumentParser

Complexity

Conditions	1
Paths	1

Size

Total Lines	5
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	5
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	3
nc	1
nop	2

<?php
/**
 * Class ArgumentParser | ArgumentParser.php
 * @package ORM\Console
 * @author  Florian Knapp <[email protected]>
 */
namespace Faulancer\Console;

use Faulancer\Service\Config;

/**
 * Class ArgumentParser
 */
class ArgumentParser
{

    /** @var array */
    protected $arguments = [];

    /** @var array */
    protected $config;

    /**
     * ArgumentParser constructor.
     * @param array $argv
     * @param Config $config
     * @codeCoverageIgnore
     */
    public function __construct($argv, $config)
    {
        $this->config = $config;

        $this->parseInput($argv);
    }

    /**
     * @param array $argv
     * @return ConsoleInterface
     * @throws \Exception
     * @codeCoverageIgnore
     */
    protected function parseInput(array $argv)
    {
        $args = array_splice($argv, 1, count($argv));

        if (empty($args)) {
            throw new \Exception('Not enough parameters given.');
        }

        for ($i = 0; $i < count($args); $i++) {
for ($i=0; $i<count($array); $i++) { // calls count() on each iteration
}

// Better
for ($i=0, $c=count($array); $i<$c; $i++) { // calls count() just once
}

            if (strpos($args[$i], '-') === false) {
                continue;
            } else if (empty($args[$i+1])) {
                break;
            }

            $this->set(str_replace('-', '', $args[$i]), $args[$i+1]);

        }

        if (strpos($args[0], ':') !== false) {

            $parts  = explode(':', $args[0]);
            $class  = $parts[0];
            $method = $parts[1] . 'Action';
            $ns     = '\Faulancer\Console\Handler\\' . ucfirst($class);

            $class = new $ns($this->config, $this);

            return call_user_func([$class, $method], $this);

        }

        throw new \Exception('No matching handler found');

    }

    /**
     * @param string $arg
     * @param string $value
     * @codeCoverageIgnore
     */
    public function set($arg, $value)
    {
        $this->arguments[$arg] = $value;
    }

    /**
     * @param string $arg
     * @return string
     * @codeCoverageIgnore
     */
    public function get($arg)
    {
        if (empty($this->arguments[$arg])) {
            return '';
        }

        return $this->arguments[$arg];
    }

}

1			<?php
2			/**
3			* Class ArgumentParser \| ArgumentParser.php
4			* @package ORM\Console
5			* @author Florian Knapp <[email protected]>
6			*/
7			namespace Faulancer\Console;
8
9			use Faulancer\Service\Config;
10
11			/**
12			* Class ArgumentParser
13			*/
14			class ArgumentParser
15			{
16
17			/** @var array */
18			protected $arguments = [];
19
20			/** @var array */
21			protected $config;
22
23			/**
24			* ArgumentParser constructor.
25			* @param array $argv
26			* @param Config $config
27			* @codeCoverageIgnore
28			*/
29			public function __construct($argv, $config)
30			{
31			$this->config = $config;
			0 ignored issues – show Documentation Bug introduced 2017-01-20 11:46 UTC by Report Bug Copy Issue Report It seems like `$config` of type `object<Faulancer\Service\Config>` is incompatible with the declared type `array` of property `$config`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
32			$this->parseInput($argv);
33			}
34
35			/**
36			* @param array $argv
37			* @return ConsoleInterface
38			* @throws \Exception
39			* @codeCoverageIgnore
40			*/
41			protected function parseInput(array $argv)
42			{
43			$args = array_splice($argv, 1, count($argv));
44
45			if (empty($args)) {
46			throw new \Exception('Not enough parameters given.');
47			}
48
49			for ($i = 0; $i < count($args); $i++) {
			0 ignored issues – show Performance Best Practice introduced 2017-01-20 11:46 UTC by Report Bug Copy Issue Report It seems like you are calling the size function `count()` as part of the test condition. You might want to compute the size beforehand, and not on each iteration. If the size of the collection does not change during the iteration, it is generally a good practice to compute it beforehand, and not on each iteration: for ($i=0; $i<count($array); $i++) { // calls count() on each iteration } // Better for ($i=0, $c=count($array); $i<$c; $i++) { // calls count() just once } Loading history...
50
51			if (strpos($args[$i], '-') === false) {
52			continue;
53			} else if (empty($args[$i+1])) {
54			break;
55			}
56
57			$this->set(str_replace('-', '', $args[$i]), $args[$i+1]);
58
59			}
60
61			if (strpos($args[0], ':') !== false) {
62
63			$parts = explode(':', $args[0]);
64			$class = $parts[0];
65			$method = $parts[1] . 'Action';
66			$ns = '\Faulancer\Console\Handler\\' . ucfirst($class);
67
68			$class = new $ns($this->config, $this);
69
70			return call_user_func([$class, $method], $this);
71
72			}
73
74			throw new \Exception('No matching handler found');
75
76			}
77
78			/**
79			* @param string $arg
80			* @param string $value
81			* @codeCoverageIgnore
82			*/
83			public function set($arg, $value)
84			{
85			$this->arguments[$arg] = $value;
86			}
87
88			/**
89			* @param string $arg
90			* @return string
91			* @codeCoverageIgnore
92			*/
93			public function get($arg)
94			{
95			if (empty($this->arguments[$arg])) {
96			return '';
97			}
98
99			return $this->arguments[$arg];
100			}
101
102			}

FloKnapp / faulancer

Push — master ( 4006e3...35fa08 )

ArgumentParser::__construct() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like