docs/assets/js/routing/dispatcher.js - Code Metrics - Inspection of "Feature docs" - FloKnapp/faulancer - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#9)

by Flo

created 2017-01-08 21:52 UTC

docs/assets/js/routing/dispatcher.js B

↳ Parent: Project

Complexity

Conditions	1
Paths	1

Size

Total Lines

141

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	141
cc	1
nc	1
rs	8.2857
nop	1

8 Functions

Rating	Name	Size	Complexity
A	ns.dispatcher.init	21	3
A	_helpers.detectPathChanges	10	2
A	_events.onDocumentLoad	3	1
A	_helpers.getPath	3	1
A	_private.getAction	19	3
A	_private.run	18	3
A	_events.onLinkClick	7	1
A	_helpers.addPath	6	1

How to fix Long Method

(function(controller) {

    'use strict';

    /** @namespace faulancer.routing */
    var ns = faulancer.namespace('docs.routing');


    var _fields = {
        paths: [],
        basePath: 'faulancer',
        currentPath: '/'
    };

    var _private = {

        /**
         * Get the action
         *
         * @param {String} path
         * @returns {Function}
         */
        getAction: function(path) {

            if (controller.hasOwnProperty(path + 'Action')) {

                var ctrl   = 'controller';
                var method = path + 'Action';
                var target = faulancer['docs'][ctrl][method];


                if (typeof target === 'function') {
function isBig(a) {
    if (a > 5000) {
        return "yes";
    }
}

console.log(isBig(5001)); //returns yes
console.log(isBig(42)); //returns undefined
                    return target();
                }

            } else {

                return controller.errorAction();

            }

        },

        /**
         * Run dispatcher
         *
         * @param {String} path
         * @returns {Function}
         */
        run: function(path) {

            if (path.substr(0,1) === '/') {
                path = path.substr(1, path.length);
            }

            if (document.querySelector('a.selected')) {
                document.querySelector('a.selected').classList.remove('selected');
            }

            document.querySelector('[href="/' + path + '"]').classList.add('selected');


            return this.getAction(path);



        }

    };

    var _events = {

        onDocumentLoad: function() {
            _private.run('/documentation');
        },

        onLinkClick: function(e) {
            e.preventDefault();
            _helpers.addPath(e.target);
            _private.run(_helpers.getPath());
            _fields.currentPath = _helpers.getPath();
            return false;
        }

    };

    var _helpers = {

        addPath: function(item) {

            var path = item.getAttribute('href');
            window.history.pushState(null, 'Site', _fields.basePath + path);

        },

        getPath: function() {
            return window.location.pathname.replace(_fields.basePath, '');
        },

        detectPathChanges: function() {

            if (_fields.currentPath !== _helpers.getPath()) {

                _fields.currentPath = _helpers.getPath();
                _private.run(_helpers.getPath());

            }

        }

    };

    ns.dispatcher = {

        init: function() {

            _fields.basePath = document.querySelector('base').getAttribute('href');

            var links = document.querySelectorAll('a');

            for (var link in links) {

                if (!links.hasOwnProperty(link)) {
                    continue;
                }

                links[link].addEventListener('click', _events.onLinkClick);

            }

            _events.onDocumentLoad();

            //setInterval(_helpers.detectPathChanges, 500);

        }

    };

    window.addEventListener('load', ns.dispatcher.init);



})(faulancer.namespace('docs.controller'));


1			(function(controller) {
2
3			'use strict';
4
5			/** @namespace faulancer.routing */
6			var ns = faulancer.namespace('docs.routing');
			0 ignored issues – show Bug introduced 2017-01-08 21:54 UTC by Report Bug Copy Issue Report The variable `faulancer` seems to be never declared. If this is a global, consider adding a `/** global: faulancer */` comment. This checks looks for references to variables that have not been declared. This is most likey a typographical error or a variable has been renamed. To learn more about declaring variables in Javascript, see the MDN. Loading history...
7
8			var _fields = {
9			paths: [],
10			basePath: 'faulancer',
11			currentPath: '/'
12			};
13
14			var _private = {
15
16			/**
17			* Get the action
18			*
19			* @param {String} path
20			* @returns {Function}
21			*/
22			getAction: function(path) {
23
24			if (controller.hasOwnProperty(path + 'Action')) {
25
26			var ctrl = 'controller';
27			var method = path + 'Action';
28			var target = faulancer['docs'][ctrl][method];
			0 ignored issues – show Bug introduced 2017-01-08 21:54 UTC by Report Bug Copy Issue Report The variable `faulancer` seems to be never declared. If this is a global, consider adding a `/** global: faulancer */` comment. This checks looks for references to variables that have not been declared. This is most likey a typographical error or a variable has been renamed. To learn more about declaring variables in Javascript, see the MDN. Loading history...
29
30			if (typeof target === 'function') {
			0 ignored issues – show Complexity Best Practice introduced 2017-01-08 21:54 UTC by Report Bug Copy Issue Report There is no return statement if `typeof target === "function"` is `false`. Are you sure this is correct? If so, consider adding `return;` explicitly. This check looks for functions where a `return` statement is found in some execution paths, but not in all. Consider this little piece of code function isBig(a) { if (a > 5000) { return "yes"; } } console.log(isBig(5001)); //returns yes console.log(isBig(42)); //returns undefined The function `isBig` will only return a specific value when its parameter is bigger than 5000. In any other case, it will implicitly return `undefined`. This behaviour may not be what you had intended. In any case, you can add a `return undefined` to the other execution path to make the return value explicit. Loading history...
31			return target();
32			}
33
34			} else {
35
36			return controller.errorAction();
37
38			}
39
40			},
41
42			/**
43			* Run dispatcher
44			*
45			* @param {String} path
46			* @returns {Function}
47			*/
48			run: function(path) {
49
50			if (path.substr(0,1) === '/') {
51			path = path.substr(1, path.length);
52			}
53
54			if (document.querySelector('a.selected')) {
55			document.querySelector('a.selected').classList.remove('selected');
56			}
57
58			document.querySelector('[href="/' + path + '"]').classList.add('selected');
59
60
61			return this.getAction(path);
62
63
64
65			}
66
67			};
68
69			var _events = {
70
71			onDocumentLoad: function() {
72			_private.run('/documentation');
73			},
74
75			onLinkClick: function(e) {
76			e.preventDefault();
77			_helpers.addPath(e.target);
78			_private.run(_helpers.getPath());
79			_fields.currentPath = _helpers.getPath();
80			return false;
81			}
82
83			};
84
85			var _helpers = {
86
87			addPath: function(item) {
88
89			var path = item.getAttribute('href');
90			window.history.pushState(null, 'Site', _fields.basePath + path);
91
92			},
93
94			getPath: function() {
95			return window.location.pathname.replace(_fields.basePath, '');
96			},
97
98			detectPathChanges: function() {
99
100			if (_fields.currentPath !== _helpers.getPath()) {
101
102			_fields.currentPath = _helpers.getPath();
103			_private.run(_helpers.getPath());
104
105			}
106
107			}
108
109			};
110
111			ns.dispatcher = {
112
113			init: function() {
114
115			_fields.basePath = document.querySelector('base').getAttribute('href');
116
117			var links = document.querySelectorAll('a');
118
119			for (var link in links) {
120
121			if (!links.hasOwnProperty(link)) {
122			continue;
123			}
124
125			links[link].addEventListener('click', _events.onLinkClick);
126
127			}
128
129			_events.onDocumentLoad();
130
131			//setInterval(_helpers.detectPathChanges, 500);
132
133			}
134
135			};
136
137			window.addEventListener('load', ns.dispatcher.init);
138
139
140
141			})(faulancer.namespace('docs.controller'));
			0 ignored issues – show Bug introduced 2017-01-08 21:54 UTC by Report Bug Copy Issue Report The variable `faulancer` seems to be never declared. If this is a global, consider adding a `/** global: faulancer */` comment. This checks looks for references to variables that have not been declared. This is most likey a typographical error or a variable has been renamed. To learn more about declaring variables in Javascript, see the MDN. Loading history...

FloKnapp / faulancer

Pull Request — master (#9)

docs/assets/js/routing/dispatcher.js B

Complexity

Size

Duplication

Importance

8 Functions

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like