GenericViewHelper::route() - Code Metrics - Inspection of "Feature optimization" - FloKnapp/faulancer - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#11)

by Flo

created 2017-01-15 23:50 UTC

GenericViewHelper::route() A

↳ Parent: GenericViewHelper

Complexity

Conditions	3
Paths	3

Size

Total Lines	16
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	16
rs	9.4285
c	0
b	0
f	0
cc	3
eloc	7
nc	3
nop	1

<?php
/**
 * Class GenericViewHelper
 *
 * @package Faulancer\View
 * @author Florian Knapp <[email protected]>
 */
namespace Faulancer\View;

use Faulancer\Security\Csrf;
use Faulancer\Service\Config;
use Faulancer\ServiceLocator\ServiceLocator;
use Faulancer\Session\SessionManager;
use Faulancer\Translate\Translator;

/**
 * Class GenericViewHelper
 */
class GenericViewHelper
{

    /**
     * Instance of view controller
     * @var ViewController $view
     */
    private $view;

    /**
     * The block name
     * @var string $blockName
     */
    private $blockName;

    /**
     * The block content
     * @var string $blockContent
     */
    private $blockContent;

    /**
     * ViewFunctions constructor.
     * @param ViewController $view
     */
    public function __construct(ViewController $view)
    {
        $this->view = $view;
    }

    /**
     * Render view
     * @param string $template
     * @param array $variables
     * @return string
     */
    public function render(string $template = "", array $variables = [])
    {
        $view = new ViewController();
        $view->setTemplate( $template );
        $view->setVariables( $variables );
        return $view->render();
    }

    /**
     * Set parent template
     * @param string $template
     */
    public function extendsTemplate(string $template)
    {
        $view = new ViewController();
        $view->setTemplate($template);
        $this->view->setExtendedTemplate($view);
    }

    /**
     * Set block
     * @param string $name The block name
     */
    public function block(string $name = "")
    {

        if (!empty($name)) {

            $this->blockName = $name;
            ob_start();

        } else {

            $this->blockContent = ob_get_flush();
            $this->view->getExtendedTemplate()->setVariable($this->blockName, $this->blockContent);
            unset($this->blockName);

        }

    }

    /**
     * Return block contents
     * @param string $name    The block name
     * @param string $default The default value
     * @return string
     */
    public function renderBlock(string $name, string $default = "")
    {
        if($this->view->getVariable($name) == null) {
            return $default;
        }
        return trim($this->view->getVariable( $name ));
    }

    /**
     * Strip slashes from value
     * @param string $string
     * @return string
     */
    public function escape(string $string)
    {
        return stripslashes( strip_tags( $string ) );
    }

    /**
     * Get assets by type
     * @param $type
     * @return string
     */
    public function getAssets($type)
    {
        $result  = '';
        $pattern = '';

        switch ($type) {

            case 'js':
                $pattern = '<script src="%s"></script>';
                break;

            case 'css':
                $pattern = '<link rel="stylesheet" type="text/css" href="%s">';
                break;

        }

        $files = $this->view->getVariable('assets'.ucfirst($type));

        foreach ($files AS $file) {
$collection = json_decode($data, true);
if ( ! is_array($collection)) {
    throw new \RuntimeException('$collection must be an array.');
}

foreach ($collection as $item) { /** ... */ }
            $result .= sprintf($pattern, $file). "\n";
        }

        return $result;
    }

    /**
     * Generate a CSRF token
     * @return string
     */
    public function generateCsrfToken()
    {
        return Csrf::getToken();
    }

    /**
     * Get form error by input field
     * @param $field
     * @return bool|string
     */
    public function getFormError($field)
    {
        $error = SessionManager::instance()->getFlashbagError($field);

        if (!empty($error)) {

            $result = '<div class="form-error ' . $field . '">';

            foreach ($error as $err) {
$collection = json_decode($data, true);
if ( ! is_array($collection)) {
    throw new \RuntimeException('$collection must be an array.');
}

foreach ($collection as $item) { /** ... */ }
                $result .= '<span>' . $this->translate($err['message']) . '</span>';
            }

            $result .= '</div>';

            return $result;

        }

        return false;
    }

    /**
     * Check if form error exists
     * @param $field
     * @return boolean
     */
    public function hasFormError($field)
    {
        return SessionManager::instance()->hasFlashbagErrorsKey($field);
    }

    /**
     * Get form data for specific input field
     * @param $key
     * @return array|null|string
     */
    public function getFormData($key)
    {
        return SessionManager::instance()->getFlashbagFormData($key);
    }

    /**
     * @param string $name
     * @return string
     * @throws \Exception
     */
    public function route($name)
    {
        /** @var Config $config */
        $config = ServiceLocator::instance()->get(Config::class);
        $routes = require $config->get('routeFile');

        foreach ($routes as $routeName => $data) {

            if ($routeName === $name) {
                return $data['path'];
            }

        }

        throw new \Exception('No route for name "' . $name . '" found');
    }

    /**
     * Translate key
     * @param string $string The key which holds the translated value
     * @param array  $value  The variable content for the placeholder
     * @return string
     */
    public function translate($string, $value = [])
    {
        $translator = new Translator();
        return $translator->translate($string, $value);
    }

}

1			<?php
2			/**
3			* Class GenericViewHelper
4			*
5			* @package Faulancer\View
6			* @author Florian Knapp <[email protected]>
7			*/
8			namespace Faulancer\View;
9
10			use Faulancer\Security\Csrf;
11			use Faulancer\Service\Config;
12			use Faulancer\ServiceLocator\ServiceLocator;
13			use Faulancer\Session\SessionManager;
14			use Faulancer\Translate\Translator;
15
16			/**
17			* Class GenericViewHelper
18			*/
19			class GenericViewHelper
20			{
21
22			/**
23			* Instance of view controller
24			* @var ViewController $view
25			*/
26			private $view;
27
28			/**
29			* The block name
30			* @var string $blockName
31			*/
32			private $blockName;
33
34			/**
35			* The block content
36			* @var string $blockContent
37			*/
38			private $blockContent;
39
40			/**
41			* ViewFunctions constructor.
42			* @param ViewController $view
43			*/
44			public function __construct(ViewController $view)
45			{
46			$this->view = $view;
47			}
48
49			/**
50			* Render view
51			* @param string $template
52			* @param array $variables
53			* @return string
54			*/
55			public function render(string $template = "", array $variables = [])
56			{
57			$view = new ViewController();
58			$view->setTemplate( $template );
59			$view->setVariables( $variables );
60			return $view->render();
61			}
62
63			/**
64			* Set parent template
65			* @param string $template
66			*/
67			public function extendsTemplate(string $template)
68			{
69			$view = new ViewController();
70			$view->setTemplate($template);
71			$this->view->setExtendedTemplate($view);
72			}
73
74			/**
75			* Set block
76			* @param string $name The block name
77			*/
78			public function block(string $name = "")
79			{
80
81			if (!empty($name)) {
82
83			$this->blockName = $name;
84			ob_start();
85
86			} else {
87
88			$this->blockContent = ob_get_flush();
89			$this->view->getExtendedTemplate()->setVariable($this->blockName, $this->blockContent);
90			unset($this->blockName);
91
92			}
93
94			}
95
96			/**
97			* Return block contents
98			* @param string $name The block name
99			* @param string $default The default value
100			* @return string
101			*/
102			public function renderBlock(string $name, string $default = "")
103			{
104			if($this->view->getVariable($name) == null) {
105			return $default;
106			}
107			return trim($this->view->getVariable( $name ));
108			}
109
110			/**
111			* Strip slashes from value
112			* @param string $string
113			* @return string
114			*/
115			public function escape(string $string)
116			{
117			return stripslashes( strip_tags( $string ) );
118			}
119
120			/**
121			* Get assets by type
122			* @param $type
123			* @return string
124			*/
125			public function getAssets($type)
126			{
127			$result = '';
128			$pattern = '';
129
130			switch ($type) {
131
132			case 'js':
133			$pattern = '<script src="%s"></script>';
134			break;
135
136			case 'css':
137			$pattern = '<link rel="stylesheet" type="text/css" href="%s">';
138			break;
139
140			}
141
142			$files = $this->view->getVariable('assets'.ucfirst($type));
143
144			foreach ($files AS $file) {
			0 ignored issues – show Bug introduced 2017-01-08 02:45 UTC by Report Bug Copy Issue Report The expression `$files` of type `boolean\|string\|array` is not guaranteed to be traversable. How about adding an additional type check? There are different options of fixing this problem. If you want to be on the safe side, you can add an additional type-check: $collection = json_decode($data, true); if ( ! is_array($collection)) { throw new \RuntimeException('$collection must be an array.'); } foreach ($collection as $item) { /** ... / } If you are sure that the expression is traversable, you might want to add a doc comment cast* to improve IDE auto-completion and static analysis: /** @var array $collection / $collection = json_decode($data, true); foreach ($collection as $item) { /* .. / } Mark the issue as a false-positive*: Just hover the remove button, in the top-right corner of this issue for more options. Loading history...
145			$result .= sprintf($pattern, $file). "\n";
146			}
147
148			return $result;
149			}
150
151			/**
152			* Generate a CSRF token
153			* @return string
154			*/
155			public function generateCsrfToken()
156			{
157			return Csrf::getToken();
158			}
159
160			/**
161			* Get form error by input field
162			* @param $field
163			* @return bool\|string
164			*/
165			public function getFormError($field)
166			{
167			$error = SessionManager::instance()->getFlashbagError($field);
168
169			if (!empty($error)) {
170
171			$result = '<div class="form-error ' . $field . '">';
172
173			foreach ($error as $err) {
			0 ignored issues – show Bug introduced 2017-01-08 02:45 UTC by Report Bug Copy Issue Report The expression `$error` of type `string\|array` is not guaranteed to be traversable. How about adding an additional type check? There are different options of fixing this problem. If you want to be on the safe side, you can add an additional type-check: $collection = json_decode($data, true); if ( ! is_array($collection)) { throw new \RuntimeException('$collection must be an array.'); } foreach ($collection as $item) { /** ... / } If you are sure that the expression is traversable, you might want to add a doc comment cast* to improve IDE auto-completion and static analysis: /** @var array $collection / $collection = json_decode($data, true); foreach ($collection as $item) { /* .. / } Mark the issue as a false-positive*: Just hover the remove button, in the top-right corner of this issue for more options. Loading history...
174			$result .= '<span>' . $this->translate($err['message']) . '</span>';
175			}
176
177			$result .= '</div>';
178
179			return $result;
180
181			}
182
183			return false;
184			}
185
186			/**
187			* Check if form error exists
188			* @param $field
189			* @return boolean
190			*/
191			public function hasFormError($field)
192			{
193			return SessionManager::instance()->hasFlashbagErrorsKey($field);
194			}
195
196			/**
197			* Get form data for specific input field
198			* @param $key
199			* @return array\|null\|string
200			*/
201			public function getFormData($key)
202			{
203			return SessionManager::instance()->getFlashbagFormData($key);
204			}
205
206			/**
207			* @param string $name
208			* @return string
209			* @throws \Exception
210			*/
211			public function route($name)
212			{
213			/** @var Config $config */
214			$config = ServiceLocator::instance()->get(Config::class);
215			$routes = require $config->get('routeFile');
216
217			foreach ($routes as $routeName => $data) {
218
219			if ($routeName === $name) {
220			return $data['path'];
221			}
222
223			}
224
225			throw new \Exception('No route for name "' . $name . '" found');
226			}
227
228			/**
229			* Translate key
230			* @param string $string The key which holds the translated value
231			* @param array $value The variable content for the placeholder
232			* @return string
233			*/
234			public function translate($string, $value = [])
235			{
236			$translator = new Translator();
237			return $translator->translate($string, $value);
238			}
239
240			}

FloKnapp / faulancer

Pull Request — master (#11)

GenericViewHelper::route() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like