AbstractControllerServiceFactory::createService() - Code Metrics - Inspection of "Feature formbuilder" - FloKnapp/faulancer - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Pull Request — master (#19)

by Flo

created 2017-06-21 00:08 UTC

AbstractControllerServiceFactory::createService() A

↳ Parent: AbstractControllerServiceFactory

Complexity

Conditions	3
Paths	2

Size

Total Lines	13
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	13
rs	9.4285
c	0
b	0
f	0
cc	3
eloc	8
nc	2
nop	1

<?php
/**
 * Class AbstractControllerServiceFactory | AbstractControllerServiceFactory.phptory.php
 * @package Faulancer\Service\Factory
 * @author  Florian Knapp <[email protected]>
 */
namespace Faulancer\Service\Factory;

use Faulancer\Http\Request;
use Faulancer\Service\AbstractControllerService;
use Faulancer\ServiceLocator\FactoryInterface;
use Faulancer\ServiceLocator\ServiceLocatorInterface;

/**
 * Class AbstractControllerServiceFactory
 * @codeCoverageIgnore
 */
class AbstractControllerServiceFactory implements FactoryInterface
{

    /**
     * @param ServiceLocatorInterface $serviceLocator
     * @return AbstractControllerService
     * @codeCoverageIgnore
     */
    public function createService(ServiceLocatorInterface $serviceLocator)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $request = new Request();

        if (empty($_SERVER['REQUEST_URI']) && empty($_SERVER['REQUEST_METHOD'])) {
            $request->setMethod('GET');
            $request->setUri('/');
        } else {
            $request->createFromHeaders();
        }

        return new AbstractControllerService($request);
    }

}

1			<?php
2			/**
3			* Class AbstractControllerServiceFactory \| AbstractControllerServiceFactory.phptory.php
4			* @package Faulancer\Service\Factory
5			* @author Florian Knapp <[email protected]>
6			*/
7			namespace Faulancer\Service\Factory;
8
9			use Faulancer\Http\Request;
10			use Faulancer\Service\AbstractControllerService;
11			use Faulancer\ServiceLocator\FactoryInterface;
12			use Faulancer\ServiceLocator\ServiceLocatorInterface;
13
14			/**
15			* Class AbstractControllerServiceFactory
16			* @codeCoverageIgnore
17			*/
18			class AbstractControllerServiceFactory implements FactoryInterface
19			{
20
21			/**
22			* @param ServiceLocatorInterface $serviceLocator
23			* @return AbstractControllerService
24			* @codeCoverageIgnore
25			*/
26			public function createService(ServiceLocatorInterface $serviceLocator)
			0 ignored issues – show Coding Style introduced 2017-02-06 19:54 UTC by Report Bug Copy Issue Report `createService` uses the super-global variable `$_SERVER` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
27			{
28			$request = new Request();
29
30			if (empty($_SERVER['REQUEST_URI']) && empty($_SERVER['REQUEST_METHOD'])) {
31			$request->setMethod('GET');
32			$request->setUri('/');
33			} else {
34			$request->createFromHeaders();
35			}
36
37			return new AbstractControllerService($request);
38			}
39
40			}

FloKnapp / faulancer

Pull Request — master (#19)

AbstractControllerServiceFactory::createService() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like