Observer::trigger() - Code Metrics - Inspection of "Feature formbuilder" - FloKnapp/faulancer - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Pull Request — master (#19)

by Flo

created 2017-10-24 23:29 UTC

Observer::trigger() B

↳ Parent: Observer

Complexity

Conditions	4
Paths	4

Size

Total Lines	22
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	22
rs	8.9197
c	0
b	0
f	0
cc	4
eloc	6
nc	4
nop	1

<?php

namespace Faulancer\Event;

use Faulancer\Service\Config;
use Faulancer\ServiceLocator\ServiceLocator;

/**
 * Class Observer
 * @package Faulancer\Event
 * @author  Florian Knapp <[email protected]>
 */
class Observer
{

    /** @var self */
    protected static $instance;

    /** @var AbstractListener[] */
    protected static $listener = [];

    /**
     * Observer constructor (private).
     */
    private function __construct() {}

    /**
     * Yeah... singleton... i know
     *
     * @return self
     */
    public static function instance()
    {
        if (!self::$instance) {

            /** @var Config $config */
            $config = ServiceLocator::instance()->get(Config::class);
            self::$listener = $config->get('eventListener');

            self::$instance = new self();

        }

        return self::$instance;
    }

    /**
     * Trigger listeners if registered for the type
     *
     * @param AbstractEventType $eventType
     */
    public function trigger(AbstractEventType $eventType)
    {
        foreach (self::$listener as $typeName => $listenerList) {

            /** @var AbstractListener[] $listenerList */
            foreach ($listenerList as $listener) {

                if ($typeName === $eventType::EVENT_TYPE) {

                    /** @var AbstractListener $listener */
                    $listener = new $listener($eventType);
                    $listener->create()->getCallback()->execute($eventType);


                }

            }



        }

    }

}

1			<?php
2
3			namespace Faulancer\Event;
4
5			use Faulancer\Service\Config;
6			use Faulancer\ServiceLocator\ServiceLocator;
7
8			/**
9			* Class Observer
10			* @package Faulancer\Event
11			* @author Florian Knapp <[email protected]>
12			*/
13			class Observer
14			{
15
16			/** @var self */
17			protected static $instance;
18
19			/** @var AbstractListener[] */
20			protected static $listener = [];
21
22			/**
23			* Observer constructor (private).
24			*/
25			private function __construct() {}
26
27			/**
28			* Yeah... singleton... i know
29			*
30			* @return self
31			*/
32			public static function instance()
33			{
34			if (!self::$instance) {
35
36			/** @var Config $config */
37			$config = ServiceLocator::instance()->get(Config::class);
38			self::$listener = $config->get('eventListener');
			0 ignored issues – show Documentation Bug introduced 2017-10-24 15:55 UTC by Report Bug Copy Issue Report It seems like `$config->get('eventListener')` of type `*` is incompatible with the declared type `array<integer,object<Fau...vent\AbstractListener>>` of property `$listener`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
39			self::$instance = new self();
40
41			}
42
43			return self::$instance;
44			}
45
46			/**
47			* Trigger listeners if registered for the type
48			*
49			* @param AbstractEventType $eventType
50			*/
51			public function trigger(AbstractEventType $eventType)
52			{
53			foreach (self::$listener as $typeName => $listenerList) {
54
55			/** @var AbstractListener[] $listenerList */
56			foreach ($listenerList as $listener) {
57
58			if ($typeName === $eventType::EVENT_TYPE) {
59
60			/** @var AbstractListener $listener */
61			$listener = new $listener($eventType);
62			$listener->create()->getCallback()->execute($eventType);
			0 ignored issues – show Bug introduced 2017-10-24 23:02 UTC by Report Bug Copy Issue Report The method `execute` cannot be called on `$listener->create()->getCallback()` (of type `callable`). Methods can only be called on objects. This check looks for methods being called on variables that have been inferred to never be objects. Loading history...
63
64			}
65
66			}
67
68
69
70			}
71
72			}
73
74			}

FloKnapp / faulancer

Pull Request — master (#19)

Observer::trigger() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like