Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 13 | class Client |
||
| 14 | { |
||
| 15 | |||
| 16 | /** @var AbstractAdapter */ |
||
| 17 | protected $adapter; |
||
| 18 | |||
| 19 | /** |
||
| 20 | * Client constructor. |
||
| 21 | * |
||
| 22 | * @param AbstractAdapter $adapter |
||
| 23 | */ |
||
| 24 | public function __construct(AbstractAdapter $adapter) |
||
| 28 | |||
| 29 | /** |
||
| 30 | * Send a get request |
||
| 31 | * |
||
| 32 | * @param string $uri The uri |
||
| 33 | * @param string[] $headers Custom headers |
||
| 34 | * @return string |
||
| 35 | */ |
||
| 36 | View Code Duplication | public function get(string $uri, array $headers = []) :string |
|
| 47 | |||
| 48 | /** |
||
| 49 | * Send a post request |
||
| 50 | * |
||
| 51 | * @param string $uri |
||
| 52 | * @param array $headers |
||
| 53 | * @param array $data |
||
| 54 | * |
||
| 55 | * @return string |
||
| 56 | */ |
||
| 57 | View Code Duplication | public function post(string $uri, array $headers = [], array $data = []) :string |
|
| 69 | |||
| 70 | } |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.