Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
12 | class Client extends AbstractApi |
||
13 | { |
||
14 | |||
15 | /** Receiver constants */ |
||
16 | const ACTIVITY = 'Activity'; |
||
17 | const ENTERPRISE = 'Enterprise'; |
||
18 | const GISTS = 'Gists'; |
||
19 | const GIT_DATA = 'GitData'; |
||
20 | const ISSUES = 'Issues'; |
||
21 | const MISCELLANEOUS = 'Miscellaneous'; |
||
22 | const ORGANIZATIONS = 'Organizations'; |
||
23 | const PULL_REQUESTS = 'PullRequests'; |
||
24 | const REPOSITORIES = 'Repositories'; |
||
25 | const SEARCH = 'Search'; |
||
26 | const USERS = 'Users'; |
||
27 | |||
28 | /** |
||
29 | * Returns receiver object |
||
30 | * |
||
31 | * @param string $receiver |
||
32 | * |
||
33 | * @return null|AbstractReceiver |
||
34 | */ |
||
35 | View Code Duplication | public function getReceiver(string $receiver) |
|
45 | |||
46 | } |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.