bot.*Context.GetRoles - Code Metrics - Inspection of "Now server owner is bot server admin" - FlameInTheDark/dtbot - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( f73fa3...235add )

by Viktor

created 2019-03-30 16:17 UTC

bot.*Context.GetRoles B

↳ Parent: bot/role.go

Complexity

Conditions

Size

Total Lines	14
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	7
eloc	10
nop	0
dl	0
loc	14
rs	8
c	0
b	0
f	0

package bot

import (
	"fmt"

	"github.com/bwmarrin/discordgo"
)

// UserRoles struct with array of user roles in guild
type UserRoles struct {
	Roles []*discordgo.Role
}

// IsAdmin returns true if user is admin
func (ctx *Context) IsAdmin() bool {
	return ctx.User.ID == ctx.Conf.General.AdminID
}

func (ctx *Context) IsServerAdmin() bool {

	if ctx.User.ID == ctx.Guild.OwnerID || ctx.GetRoles().ExistsName("bot.admin") || ctx.IsAdmin() {
		return true
	}
	return false
}

// GetRoles returns UserRoles struct pointer
func (ctx *Context) GetRoles() *UserRoles {
	var userRoles = new(UserRoles)
	memb, err := ctx.Discord.GuildMember(ctx.Guild.ID, ctx.User.ID)
	if err != nil {
		fmt.Println("Getting member error: " + err.Error())
	}
	for _, grole := range ctx.Guild.Roles {
		for _, urole := range memb.Roles {
			if grole.ID == urole {
				userRoles.Roles = append(userRoles.Roles, grole)
			}
		}
	}
	return userRoles
}

// ExistsName checks if user role nema exists on user
func (r *UserRoles) ExistsName(name string) bool {
	for _, val := range r.Roles {
		if val.Name == name {
			return true
		}
	}
	return false
}


1			package bot
2
3			import (
4			"fmt"
5
6			"github.com/bwmarrin/discordgo"
7			)
8
9			// UserRoles struct with array of user roles in guild
10			type UserRoles struct {
11			Roles []*discordgo.Role
12			}
13
14			// IsAdmin returns true if user is admin
15			func (ctx *Context) IsAdmin() bool {
16			return ctx.User.ID == ctx.Conf.General.AdminID
17			}
18
19			func (ctx *Context) IsServerAdmin() bool {
			0 ignored issues – show introduced 2019-03-30 16:18 UTC by Report Bug Copy Issue Report exported method Context.IsServerAdmin should have comment or be unexported Loading history...
20			if ctx.User.ID == ctx.Guild.OwnerID \|\| ctx.GetRoles().ExistsName("bot.admin") \|\| ctx.IsAdmin() {
21			return true
22			}
23			return false
24			}
25
26			// GetRoles returns UserRoles struct pointer
27			func (ctx Context) GetRoles() UserRoles {
28			var userRoles = new(UserRoles)
29			memb, err := ctx.Discord.GuildMember(ctx.Guild.ID, ctx.User.ID)
30			if err != nil {
31			fmt.Println("Getting member error: " + err.Error())
32			}
33			for _, grole := range ctx.Guild.Roles {
34			for _, urole := range memb.Roles {
35			if grole.ID == urole {
36			userRoles.Roles = append(userRoles.Roles, grole)
37			}
38			}
39			}
40			return userRoles
41			}
42
43			// ExistsName checks if user role nema exists on user
44			func (r *UserRoles) ExistsName(name string) bool {
45			for _, val := range r.Roles {
46			if val.Name == name {
47			return true
48			}
49			}
50			return false
51			}
52

FlameInTheDark / dtbot

Push — master ( f73fa3...235add )

bot.*Context.GetRoles B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like