Flagbit /
akeneo-table-attribute-bundle
| Conditions | 1 |
| Paths | 1 |
| Total Lines | 134 |
| Code Lines | 55 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 2 | ||
| Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | define( |
||
| 10 | function( |
||
| 11 | JsonGeneratorObserver, |
||
| 12 | JsonGeneratorRendererNumber, |
||
| 13 | JsonGeneratorRendererSelect, |
||
| 14 | JsonGeneratorRendererSelectFromUrl, |
||
| 15 | JsonGeneratorRendererConstraint, |
||
| 16 | JsonGeneratorRendererDefault |
||
| 17 | ) { |
||
| 18 | |||
| 19 | /** |
||
| 20 | * @class |
||
| 21 | * @param {Boolean} $editable |
||
| 22 | * @param {HTMLElement} $container |
||
| 23 | */ |
||
| 24 | var JsonGeneratorRenderer = function($editable, $container, $types) { |
||
| 25 | |||
| 26 | /** |
||
| 27 | * @public |
||
| 28 | * @type {JsonGeneratorObserver} |
||
| 29 | */ |
||
| 30 | this.observer = new JsonGeneratorObserver(); |
||
| 31 | |||
| 32 | var $renderer = null; |
||
| 33 | |||
| 34 | |||
| 35 | /** |
||
| 36 | * @public |
||
| 37 | */ |
||
| 38 | this.render = function($data) { |
||
| 39 | |||
| 40 | return getRenderer().render($data); |
||
| 41 | }; |
||
| 42 | |||
| 43 | |||
| 44 | /** |
||
| 45 | * @public |
||
| 46 | * @returns {Object} |
||
| 47 | */ |
||
| 48 | this.read = function() { |
||
| 49 | |||
| 50 | return getRenderer().read(); |
||
| 51 | }; |
||
| 52 | |||
| 53 | |||
| 54 | /** |
||
| 55 | * @protected |
||
| 56 | * @returns {*} |
||
| 57 | */ |
||
| 58 | var getRenderer = function() { |
||
| 59 | |||
| 60 | var renderers = { |
||
| 61 | 'select': JsonGeneratorRendererSelect, |
||
| 62 | 'select_from_url': JsonGeneratorRendererSelectFromUrl, |
||
| 63 | 'text': JsonGeneratorRendererDefault, |
||
| 64 | 'number': JsonGeneratorRendererNumber |
||
| 65 | }; |
||
| 66 | |||
| 67 | if($renderer === null) { |
||
| 68 | if($container.querySelector('.json-select-generator')) { |
||
| 69 | $renderer = new JsonGeneratorRendererSelect($editable, $container); |
||
| 70 | } |
||
| 71 | else if($container.querySelector('.json-select_from_url-generator')) { |
||
| 72 | $renderer = new JsonGeneratorRendererSelectFromUrl($editable, $container); |
||
| 73 | } |
||
| 74 | else if($container.querySelector('.json-number-generator')) { |
||
| 75 | $renderer = new JsonGeneratorRendererNumber($editable, $container); |
||
| 76 | } |
||
| 77 | else if($container.querySelector('.json-constraint-generator')) { |
||
| 78 | $renderer = new JsonGeneratorRendererConstraint($editable, $container); |
||
| 79 | } |
||
| 80 | else if($container.querySelector('.json-text-generator')) { |
||
| 81 | $renderer = new JsonGeneratorRendererDefault($editable, $container); |
||
| 82 | } |
||
| 83 | else { |
||
| 84 | $renderer = new renderers[$types[0].type]($editable, $container); |
||
| 85 | } |
||
| 86 | } |
||
| 87 | |||
| 88 | return $renderer; |
||
| 89 | }.bind(this); |
||
|
unused-code
introduced
by
|
|||
| 90 | |||
| 91 | |||
| 92 | /** |
||
| 93 | * @protected |
||
| 94 | */ |
||
| 95 | var persist = function() { |
||
| 96 | |||
| 97 | this.observer.notify('persist'); |
||
| 98 | }.bind(this); |
||
| 99 | |||
| 100 | |||
| 101 | /** |
||
| 102 | * @protected |
||
| 103 | */ |
||
| 104 | var save = function() { |
||
| 105 | |||
| 106 | this.observer.notify('save'); |
||
| 107 | }.bind(this); |
||
| 108 | |||
| 109 | |||
| 110 | /** |
||
| 111 | * @protected |
||
| 112 | */ |
||
| 113 | var addObserver = function() { |
||
| 114 | |||
| 115 | getRenderer().observer.watch('update', persist); |
||
| 116 | getRenderer().observer.watch('update', callDebounce(save)); |
||
| 117 | }.bind(this); |
||
| 118 | |||
| 119 | |||
| 120 | /** |
||
| 121 | * @protected |
||
| 122 | * @param {Function} $callable |
||
| 123 | */ |
||
| 124 | var callDebounce = function($callable) { |
||
| 125 | |||
| 126 | var $debounceTimer = null; |
||
| 127 | |||
| 128 | return function() { |
||
| 129 | |||
| 130 | if($debounceTimer) { |
||
| 131 | window.clearTimeout($debounceTimer); |
||
| 132 | } |
||
| 133 | |||
| 134 | $debounceTimer = window.setTimeout($callable, 300); |
||
| 135 | }.bind(this) |
||
| 136 | }.bind(this); |
||
| 137 | |||
| 138 | |||
| 139 | addObserver(); |
||
| 140 | }; |
||
| 141 | |||
| 142 | return JsonGeneratorRenderer; |
||
| 143 | }); |
||
| 144 |
Loading history...