Constraint.js ➔ define - Code Metrics - Inspection of "bin/console and cache" - Flagbit/akeneo-table-attribute-bundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#5)

by Ronan

created 2018-09-11 09:04 UTC

Constraint.js ➔ define B

↳ Parent: src/Resources/public/js/Json/Renderer/Constraint.js

Complexity

Conditions	1
Paths	1

Size

Total Lines	105
Code Lines	40

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
eloc	40
dl	0
loc	105
rs	8.92
c	1
b	0
f	0
cc	1
nc	1
nop	2

1 Function

Rating	Name	Duplication	Size	Complexity
B	Constraint.js ➔ ... ➔ JsonGeneratorRendererConstraint	0	97	1

How to fix Long Method

define(
    [
        'flagbit/JsonGenerator/Observer',
        'jquery'
    ],
    function(JsonGeneratorObserver, jQuery) {

        /**
         * @class
         */
        var JsonGeneratorRendererConstraint = function($editable, $container) {

            /**
             * @public
             * @type {JsonGeneratorObserver}
             */
            this.observer = new JsonGeneratorObserver();

            /**
             * @public
             * @param {Object} $data
             */
            this.render = function($data) {

                var $options = ['NotBlank', 'Blank', 'NotNull', 'IsNull', 'IsTrue', 'IsFalse', 'Email', 'Url', 'Ip', 'Uuid', 'Date', 'DateTime', 'Time', 'Language', 'Locale', 'Country', 'Currency', 'Luhn', 'Iban', 'Isbn', 'Issn'];

                var $dropdown = createDropdown();

                $options.forEach(function($value) {

                    var $option = document.createElement('option');
                    $option.value = $value;
                    $option.innerText = $value;

                    if($value in $data) {
                        $option.selected = true;
                    }

                    $dropdown.appendChild($option);
                });

                var $select2 = jQuery($dropdown).select2();

                observeChanges($select2);
            };


            /**
             * @public
             * @returns {Object}
             */
            this.read = function() {

                var $data = {};

                var $collection = $container.querySelector('select').querySelectorAll('option');

                for(var $i in $collection) {
                    if($collection.hasOwnProperty($i)) {
                        var $option = $collection[$i];
                        if($option.selected) {
                            $data[$option.value] = {};
                        }
                    }
                }

                return $data;
            };


            /**
             * @protected
             * @param {String} $name
             * @return {HTMLSelectElement}
             */
            var createDropdown = function() {

                var $dropdown = document.createElement('select');
                $dropdown.style.display = 'block';
                $dropdown.multiple = true;
                $container.appendChild($dropdown);

                if(!$editable) {
                    $dropdown.disabled = true;
                }

                return $dropdown;
            }.bind(this);



            /**
             * @protected
             * @param {HTMLSelectElement} $dropdown
             */
            var observeChanges = function($select) {
                $select.on('change', notify);
            }.bind(this);



            /**
             * @protected
             */
            var notify = function() {

                this.observer.notify('update');
            }.bind(this);
        };

        return JsonGeneratorRendererConstraint;
    }
);

1			define(
2			[
3			'flagbit/JsonGenerator/Observer',
4			'jquery'
5			],
6			function(JsonGeneratorObserver, jQuery) {
7
8			/**
9			* @class
10			*/
11			var JsonGeneratorRendererConstraint = function($editable, $container) {
12
13			/**
14			* @public
15			* @type {JsonGeneratorObserver}
16			*/
17			this.observer = new JsonGeneratorObserver();
18
19			/**
20			* @public
21			* @param {Object} $data
22			*/
23			this.render = function($data) {
24
25			var $options = ['NotBlank', 'Blank', 'NotNull', 'IsNull', 'IsTrue', 'IsFalse', 'Email', 'Url', 'Ip', 'Uuid', 'Date', 'DateTime', 'Time', 'Language', 'Locale', 'Country', 'Currency', 'Luhn', 'Iban', 'Isbn', 'Issn'];
26
27			var $dropdown = createDropdown();
28
29			$options.forEach(function($value) {
30
31			var $option = document.createElement('option');
32			$option.value = $value;
33			$option.innerText = $value;
34
35			if($value in $data) {
36			$option.selected = true;
37			}
38
39			$dropdown.appendChild($option);
40			});
41
42			var $select2 = jQuery($dropdown).select2();
43
44			observeChanges($select2);
45			};
46
47
48			/**
49			* @public
50			* @returns {Object}
51			*/
52			this.read = function() {
53
54			var $data = {};
55
56			var $collection = $container.querySelector('select').querySelectorAll('option');
57
58			for(var $i in $collection) {
59			if($collection.hasOwnProperty($i)) {
60			var $option = $collection[$i];
61			if($option.selected) {
62			$data[$option.value] = {};
63			}
64			}
65			}
66
67			return $data;
68			};
69
70
71			/**
72			* @protected
73			* @param {String} $name
74			* @return {HTMLSelectElement}
75			*/
76			var createDropdown = function() {
77
78			var $dropdown = document.createElement('select');
79			$dropdown.style.display = 'block';
80			$dropdown.multiple = true;
81			$container.appendChild($dropdown);
82
83			if(!$editable) {
84			$dropdown.disabled = true;
85			}
86
87			return $dropdown;
88			}.bind(this);
			0 ignored issues – show unused-code introduced 2018-06-15 08:29 UTC by Report Bug Copy Issue Report The call to `bind` does not seem necessary since the function does not use `this`. Consider calling it directly. Loading history...
89
90
91			/**
92			* @protected
93			* @param {HTMLSelectElement} $dropdown
94			*/
95			var observeChanges = function($select) {
96			$select.on('change', notify);
97			}.bind(this);
			0 ignored issues – show unused-code introduced 2018-06-15 08:29 UTC by Report Bug Copy Issue Report The call to `bind` does not seem necessary since the function does not use `this`. Consider calling it directly. Loading history...
98
99
100			/**
101			* @protected
102			*/
103			var notify = function() {
104
105			this.observer.notify('update');
106			}.bind(this);
107			};
108
109			return JsonGeneratorRendererConstraint;
110			}
111			);

Flagbit / akeneo-table-attribute-bundle

Pull Request — master (#5)

Constraint.js ➔ define B

Complexity

Size

Duplication

Importance

1 Function

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like