T_STRING_LITERAL - Code Metrics - Inspection of "bin/console and cache" - Flagbit/akeneo-table-attribute-bundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#5)

by Ronan

created 2018-09-11 09:04 UTC

T_STRING_LITERAL B

↳ Parent: src/Resources/public/js/product/field/table-field.js

Complexity

Total Complexity	46
Complexity/F	1.39

Size

Lines of Code	1
Function Count	33

Duplication

Duplicated Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
wmc	46
dl	0
loc	1
rs	8.3999
c	1
b	0
f	0
cc	0
nc	4
mnd	3
bc	40
fnc	33
bpm	1.2121
cpm	1.3939
noi	5

How to fix Complexity

'use strict';
define([
        'pim/field',
        'underscore',
        'jquery',
        'flagbit/template/product/field/table',
        'routing',
        'flagbit/inittable',
        'pim/user-context',
        'pim/i18n'
    ], function (
        Field,
        _,
        $,
        fieldTemplate,
        Routing,
        initTable,
        UserContext,
        i18n
    ) {
        return Field.extend({
            fieldTemplate: _.template(fieldTemplate),
            events: {
                'change .field-input:first .table-data': 'updateModel',
                'change .field-input:first .flagbit-table-values': 'updateJson',
                'click .field-input:first .flagbit-table-values .delete-row': 'deleteItem',
                'click .field-input:first .flagbit-table-attribute .item-add': 'addItem'
            },
            columns: {},
            renderInput: function (context) {
                return this.fieldTemplate(context);
            },
            postRender: function() {
                this.getColumnUrl().then(function (columnUrl) {

                    $.ajax(
                        {
                            async: true,
                            type: 'GET',
                            url: columnUrl,
                            success: function (response) {
                                if (response) {
                                    this.columns = {};
                                    _.each(response, function (value) {
                                        var column = this.convertBackendItem(value);
                                        this.columns[column.id] = column;
                                    }.bind(this));
                                    initTable.init(this.$('.flagbit-table-attribute'), this.columns);
                                    // initialize dran & drop sorting
                                    this.$('.flagbit-table-values tbody').sortable({
                                        handle: ".handle",
                                        stop: function() {
                                            this.updateJson();
                                        }.bind(this)
                                    });
                                }
                            }.bind(this)
                        }
                    );
                }.bind(this));
            },
            getColumnUrl: function () {
                return $.Deferred().resolve(
                    Routing.generate(
                        'pim_enrich_attributeoption_get',
                        {
                            identifier: this.attribute.code
                        }
                    )
                ).promise();
            },
            updateModel: function () {
                var data = this.$('.field-input:first .table-data').val();

                this.setCurrentValue(data);
            },
            updateJson: function () {
                var rows = this.$('.flagbit-table-values tr.flagbit-table-row');

                var values = [];
                var columns = this.columns;
                _.each(rows, function(row) {
                    var fields = {};

                    _.each($('td[data-code]', row), function(td) {
                        var id = $(td).data('code');
                        fields[id] = columns[id].func.parseValue($(td));
                    });

                    values.push(fields);
                });

                var valuesAsJson = JSON.stringify(values);
                this.$('.field-input:first .table-data').val(valuesAsJson);
                this.setCurrentValue(valuesAsJson);
            },
            deleteItem: function (event) {
                $(event.currentTarget).closest('tr').remove();
                this.updateJson();
            },
            addItem: function () {
                this.$('table.flagbit-table-values').append(initTable.createEmptyRow(this.columns));
            },
            convertBackendItem: function (item) {
                return {
                    id: item.code,
                    text: i18n.getLabel(item.labels, UserContext.get('catalogLocale'), item.code),
                    config: item.type_config,
                    type: item.type,
                    func: this.createColumnFunctions(item)
                };
            },
            createColumnFunctions: function(item) {
                // TODO Move this mapping to Symfony tags for every type to make this extendable
                var fieldTemplate;
                var parser = function (td) {
                    return $('input', td).val();
                };
                var init = function (td, column, value) {

                };
                var formTypeValue = function (value) {
                    if (typeof value === 'undefined' || null === value) {
                        return '';
                    }

                    return value.toString();
                };

                switch (item.type) {
                    case "text":
                        fieldTemplate = "<input data-type='<%= column.type %>' type='text' name='<%= column.id %>' class='<%= column.id %> AknTextField' value='<%= _.escape(column.func.formTypeValue(value)) %>' />";
                        break;
                    case "number":
                        fieldTemplate = "<input data-type='<%= column.type %>' type='number' name='<%= column.id %>' class='<%= column.id %> AknTextField' value='<%= _.escape(column.func.formTypeValue(value)) %>' step='<%= \'is_decimal\' in column.config && true === column.config.is_decimal ? 0.1 : 1 %>' />";
                        if ('is_decimal' in item.type_config && item.type_config.is_decimal === true) {
                            parser = function (td) {
                                return parseFloat($('input', td).val());
                            };
                        } else {
                            parser = function (td) {
                                return parseInt($('input', td).val());
                            };
                        }
                        break;
                    case "select":
                        fieldTemplate = "<input data-type='<%= column.type %>' type='text' name='<%= column.id %>' class='<%= column.id %>' value='<%= _.escape(column.func.formTypeValue(value)) %>' />";

                        parser = function (td) {
                            var option = $('input', td).select2('data');
                            return option.id;
                        };

                        init = function (td, column, value) {

                            var select2Config = {
                                placeholder: ' '
                            };
                            if ('options' in column.config) {
                                var options = [];
                                _.each(column.config.options, function(option, key) {
                                    options.push({ id: key, text: option });
                                });
                                select2Config.data = options;
                            }

                            var select2 = $('input', td).select2(select2Config);
                            select2.on('select2-close', function () {
                                this.updateJson();
                            }.bind(this));
                        }.bind(this);
                        break;
                    case "select_from_url":
                        fieldTemplate = "<input data-type='<%= column.type %>' type='text' name='<%= column.id %>' class='<%= column.id %>' value='<%= _.escape(column.func.formTypeValue(value)) %>' />";

                        parser = function (td) {
                            var option = $('input', td).select2('data');
                            return option.id;
                        };

                        init = function (td, column, value) {

                            var select2Config = {
                                placeholder: ' '
                            };
                            if ('options_url' in column.config) {
                                select2Config.ajax = {
                                    url: column.config.options_url,
                                    cache: true,
                                    minimumInputLength: 0,
                                    dataType: 'json',
                                    quietMillis: 1000,
                                    results: function (data) {
                                        return data;
                                    },
                                    data: function (term) {
                                        return {
                                            q: term
                                        };
                                    }
                                };
                                // initSelection needs to be cleaned up in the future without forcing a whole API
                                select2Config.initSelection = function(element, callback) {
                                    var option = $(element).val();

                                    if (option !== '') {
                                        $.ajax(column.config.options_url, {
                                            dataType: "json",
                                            cache: true
                                        }).done(function (data) {
                                            var selected = _.find(data.results, function (row) {
                                                return row.id === option;
                                            });
                                            callback(selected);
                                        });
                                    }
                                };
                            }

                            var select2 = $('input', td).select2(select2Config);
                            select2.on('select2-close', function () {
                                this.updateJson();
                            }.bind(this));
                        }.bind(this);
                        break;
                    default:
                        throw "Unknown type '"+item.type+"'";
                }

                return {
                    renderField: _.template(fieldTemplate), // renders the template of the field
                    parseValue: parser, // parses the value into the proper type for the json result
                    init: init, // an optional function that allows to initialize third party plugins
                    formTypeValue: formTypeValue // changes the value when it is put to the form field(s)
                };
            }
        });
    }
);


1			'use strict';
2			define([
3			'pim/field',
4			'underscore',
5			'jquery',
6			'flagbit/template/product/field/table',
7			'routing',
8			'flagbit/inittable',
9			'pim/user-context',
10			'pim/i18n'
11			], function (
12			Field,
13			_,
14			$,
15			fieldTemplate,
16			Routing,
17			initTable,
18			UserContext,
19			i18n
20			) {
21			return Field.extend({
22			fieldTemplate: _.template(fieldTemplate),
23			events: {
24			'change .field-input:first .table-data': 'updateModel',
25			'change .field-input:first .flagbit-table-values': 'updateJson',
26			'click .field-input:first .flagbit-table-values .delete-row': 'deleteItem',
27			'click .field-input:first .flagbit-table-attribute .item-add': 'addItem'
28			},
29			columns: {},
30			renderInput: function (context) {
31			return this.fieldTemplate(context);
32			},
33			postRender: function() {
34			this.getColumnUrl().then(function (columnUrl) {
35
36			$.ajax(
37			{
38			async: true,
39			type: 'GET',
40			url: columnUrl,
41			success: function (response) {
42			if (response) {
43			this.columns = {};
44			_.each(response, function (value) {
45			var column = this.convertBackendItem(value);
46			this.columns[column.id] = column;
47			}.bind(this));
48			initTable.init(this.$('.flagbit-table-attribute'), this.columns);
49			// initialize dran & drop sorting
50			this.$('.flagbit-table-values tbody').sortable({
51			handle: ".handle",
52			stop: function() {
53			this.updateJson();
54			}.bind(this)
55			});
56			}
57			}.bind(this)
58			}
59			);
60			}.bind(this));
61			},
62			getColumnUrl: function () {
63			return $.Deferred().resolve(
64			Routing.generate(
65			'pim_enrich_attributeoption_get',
66			{
67			identifier: this.attribute.code
68			}
69			)
70			).promise();
71			},
72			updateModel: function () {
73			var data = this.$('.field-input:first .table-data').val();
74
75			this.setCurrentValue(data);
76			},
77			updateJson: function () {
78			var rows = this.$('.flagbit-table-values tr.flagbit-table-row');
79
80			var values = [];
81			var columns = this.columns;
82			_.each(rows, function(row) {
83			var fields = {};
84
85			_.each($('td[data-code]', row), function(td) {
86			var id = $(td).data('code');
87			fields[id] = columns[id].func.parseValue($(td));
88			});
89
90			values.push(fields);
91			});
92
93			var valuesAsJson = JSON.stringify(values);
94			this.$('.field-input:first .table-data').val(valuesAsJson);
95			this.setCurrentValue(valuesAsJson);
96			},
97			deleteItem: function (event) {
98			$(event.currentTarget).closest('tr').remove();
99			this.updateJson();
100			},
101			addItem: function () {
102			this.$('table.flagbit-table-values').append(initTable.createEmptyRow(this.columns));
103			},
104			convertBackendItem: function (item) {
105			return {
106			id: item.code,
107			text: i18n.getLabel(item.labels, UserContext.get('catalogLocale'), item.code),
108			config: item.type_config,
109			type: item.type,
110			func: this.createColumnFunctions(item)
111			};
112			},
113			createColumnFunctions: function(item) {
114			// TODO Move this mapping to Symfony tags for every type to make this extendable
115			var fieldTemplate;
116			var parser = function (td) {
117			return $('input', td).val();
118			};
119			var init = function (td, column, value) {
			0 ignored issues – show Unused Code introduced 2018-06-15 08:29 UTC by Report Bug Copy Issue Report The parameter `column` is not used and could be removed. This check looks for parameters in functions that are not used in the function body and are not followed by other parameters which are used inside the function. Loading history... Unused Code introduced 2018-06-15 08:29 UTC by Report Bug Copy Issue Report The parameter `value` is not used and could be removed. This check looks for parameters in functions that are not used in the function body and are not followed by other parameters which are used inside the function. Loading history... Unused Code introduced 2018-06-15 08:29 UTC by Report Bug Copy Issue Report The parameter `td` is not used and could be removed. This check looks for parameters in functions that are not used in the function body and are not followed by other parameters which are used inside the function. Loading history...
120			};
121			var formTypeValue = function (value) {
122			if (typeof value === 'undefined' \|\| null === value) {
123			return '';
124			}
125
126			return value.toString();
127			};
128
129			switch (item.type) {
130			case "text":
131			fieldTemplate = "<input data-type='<%= column.type %>' type='text' name='<%= column.id %>' class='<%= column.id %> AknTextField' value='<%= _.escape(column.func.formTypeValue(value)) %>' />";
132			break;
133			case "number":
134			fieldTemplate = "<input data-type='<%= column.type %>' type='number' name='<%= column.id %>' class='<%= column.id %> AknTextField' value='<%= _.escape(column.func.formTypeValue(value)) %>' step='<%= \'is_decimal\' in column.config && true === column.config.is_decimal ? 0.1 : 1 %>' />";
135			if ('is_decimal' in item.type_config && item.type_config.is_decimal === true) {
136			parser = function (td) {
137			return parseFloat($('input', td).val());
138			};
139			} else {
140			parser = function (td) {
141			return parseInt($('input', td).val());
142			};
143			}
144			break;
145			case "select":
146			fieldTemplate = "<input data-type='<%= column.type %>' type='text' name='<%= column.id %>' class='<%= column.id %>' value='<%= _.escape(column.func.formTypeValue(value)) %>' />";
147
148			parser = function (td) {
149			var option = $('input', td).select2('data');
150			return option.id;
151			};
152
153			init = function (td, column, value) {
			0 ignored issues – show Unused Code introduced 2018-06-15 08:29 UTC by Report Bug Copy Issue Report The parameter `value` is not used and could be removed. This check looks for parameters in functions that are not used in the function body and are not followed by other parameters which are used inside the function. Loading history...
154			var select2Config = {
155			placeholder: ' '
156			};
157			if ('options' in column.config) {
158			var options = [];
159			_.each(column.config.options, function(option, key) {
160			options.push({ id: key, text: option });
161			});
162			select2Config.data = options;
163			}
164
165			var select2 = $('input', td).select2(select2Config);
166			select2.on('select2-close', function () {
167			this.updateJson();
168			}.bind(this));
169			}.bind(this);
170			break;
171			case "select_from_url":
172			fieldTemplate = "<input data-type='<%= column.type %>' type='text' name='<%= column.id %>' class='<%= column.id %>' value='<%= _.escape(column.func.formTypeValue(value)) %>' />";
173
174			parser = function (td) {
175			var option = $('input', td).select2('data');
176			return option.id;
177			};
178
179			init = function (td, column, value) {
			0 ignored issues – show Unused Code introduced 2018-06-15 08:29 UTC by Report Bug Copy Issue Report The parameter `value` is not used and could be removed. This check looks for parameters in functions that are not used in the function body and are not followed by other parameters which are used inside the function. Loading history...
180			var select2Config = {
181			placeholder: ' '
182			};
183			if ('options_url' in column.config) {
184			select2Config.ajax = {
185			url: column.config.options_url,
186			cache: true,
187			minimumInputLength: 0,
188			dataType: 'json',
189			quietMillis: 1000,
190			results: function (data) {
191			return data;
192			},
193			data: function (term) {
194			return {
195			q: term
196			};
197			}
198			};
199			// initSelection needs to be cleaned up in the future without forcing a whole API
200			select2Config.initSelection = function(element, callback) {
201			var option = $(element).val();
202
203			if (option !== '') {
204			$.ajax(column.config.options_url, {
205			dataType: "json",
206			cache: true
207			}).done(function (data) {
208			var selected = _.find(data.results, function (row) {
209			return row.id === option;
210			});
211			callback(selected);
212			});
213			}
214			};
215			}
216
217			var select2 = $('input', td).select2(select2Config);
218			select2.on('select2-close', function () {
219			this.updateJson();
220			}.bind(this));
221			}.bind(this);
222			break;
223			default:
224			throw "Unknown type '"+item.type+"'";
225			}
226
227			return {
228			renderField: _.template(fieldTemplate), // renders the template of the field
229			parseValue: parser, // parses the value into the proper type for the json result
230			init: init, // an optional function that allows to initialize third party plugins
231			formTypeValue: formTypeValue // changes the value when it is put to the form field(s)
232			};
233			}
234			});
235			}
236			);
237

Flagbit / akeneo-table-attribute-bundle

Pull Request — master (#5)

T_STRING_LITERAL B

Complexity

Size

Duplication

Importance

How to fix Complexity

Complexity

Duplication Side-by-Side

Filter issues like