Flagbit\Bundle\ProductClonerBundle\Controller\ProductController::cloneAction()

Complexity

Conditions	7
Paths	14

Size

Total Lines	55
Code Lines	32

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public function cloneAction(Request $request) : JsonResponse
    {
        $data = json_decode($request->getContent(), true);

        // check 'code_to_clone' is provided otherwise HTTP bad request
        if (false === isset($data['code_to_clone'])) {
            return new JsonResponse('Field "code_to_clone" is missing.', Response::HTTP_BAD_REQUEST);
        }

        // check whether product to be cloned is found otherwise not found HTTP
        $product = $this->productRepository->findOneByIdentifier($data['code_to_clone']);
        if (null === $product) {
            return new JsonResponse(
                sprintf('Product model with code %s could not be found.', $data['code_to_clone']),
                Response::HTTP_NOT_FOUND
            );
        }
        unset($data['code_to_clone']);
        if (isset($data['parent'])) {
            // TODO: remove this as soon as support of 2.1 is dropped
            $cloneProduct = $this->variantProductBuilder->createProduct();
        } else {
            $cloneProduct = $this->productBuilder->createProduct(
                $data['code']
            );
            unset($data['code']);
        }

        // clone product using Akeneo normalizer
        $normalizedProduct = $this->normalizeProduct($product);

        $normalizedProduct = $this->removeIdentifierAttributeValue($normalizedProduct);

It seems like $normalizedProduct can also be of type boolean and double and integer and string; however, parameter $data of Flagbit\Bundle\ProductClonerBundle\Controller\ProductController::removeIdentifierAttributeValue() does only seem to accept array, maybe add an additional type check?

        $this->productUpdater->update($cloneProduct, $normalizedProduct);
        if (!empty($data['values'])) {
            $this->updateProduct($cloneProduct, $data);
        }
        // validate product model clone and return violations if found
        $violations = $this->validator->validate($cloneProduct);
        if (count($violations) > 0) {
            $normalizedViolations = [];
            foreach ($violations as $violation) {
                $violation = $this->constraintViolationNormalizer->normalize(
                    $violation,
                    'internal_api',
                    ['product' => $cloneProduct]
                );
                $normalizedViolations[] = $violation;
            }

            return new JsonResponse(['values' => $normalizedViolations], Response::HTTP_BAD_REQUEST);
        }

        $this->productSaver->save($cloneProduct);

        return new JsonResponse();
    }