Flagbit\Bundle\ProductClonerBundle\Controller\ProductModelController::cloneAction()

Complexity

Conditions	7
Paths	28

Size

Total Lines	56
Code Lines	36

Duplication

Lines	0
Ratio	0 %

Importance

Changes	3
Bugs	0	Features	0

<?php
    public function cloneAction(Request $request) : JsonResponse
    {
        $content = json_decode($request->getContent(), true);

        try {
            // check 'code_to_clone' is provided otherwise HTTP bad request
            if (false === isset($content['code_to_clone'])) {
                $message = [['message' => 'Field "code_to_clone" is missing.']];
                return new JsonResponse(['values' => $message], Response::HTTP_BAD_REQUEST);
            }

            // check 'code' is provided otherwise HTTP bad request
            if (false === isset($content['code'])) {
                $message = [['message' => 'Failed "Code" is missing.']];
                return new JsonResponse(['values' => $message], Response::HTTP_BAD_REQUEST);
            }

            // check whether product to be cloned is found otherwise not found HTTP
            $productModel = $this->productModelRepository->findOneByIdentifier($content['code_to_clone']);
            if (null === $productModel) {
                $message = [['message' => sprintf(
                    'Product model with code %s could not be found.',
                    $content['code_to_clone']
                )]];
                return new JsonResponse(
                    ['values' => $message],
                    Response::HTTP_NOT_FOUND
                );
            }
            unset($content['code_to_clone']);
            // create a new product model
            $cloneProductModel = $this->productModelFactory->create();

            // clone product using Akeneo normalizer and updater for reusing code
            $normalizedProduct = $this->normalizeProduct($productModel);
            $this->productModelUpdater->update($cloneProductModel, $normalizedProduct);

It seems like $normalizedProduct can also be of type boolean and double and integer and null and string; however, parameter $data of Akeneo\Tool\Component\StorageUtils\Updater\ObjectUpdaterInterface::update() does only seem to accept array, maybe add an additional type check?

            $this->productModelUpdater->update($cloneProductModel, $content);
            $cloneProductModel->setCode($content['code']);
            // validate product model clone and return violations if found
            $violations = $this->validator->validate($cloneProductModel);
            if (count($violations) > 0) {
                $normalizedViolations = [];
                foreach ($violations as $violation) {
                    $violation = $this->violationNormalizer->normalize(
                        $violation,
                        'internal_api',
                        ['product_model' => $cloneProductModel]
                    );
                    $normalizedViolations[] = $violation;
                }
                return new JsonResponse(['values' => $normalizedViolations], Response::HTTP_BAD_REQUEST);
            }
            $this->productModelSaver->save($cloneProductModel);
            return new JsonResponse();
        } catch (\Exception $e) {
            return new JsonResponse(['values' => [['message' => $e->getMessage()]]], Response::HTTP_BAD_REQUEST);
        }