TestKernel - Code Metrics - Inspection of "Prepare ProductClonerBundle to be used with Akeneo..." - Flagbit/akeneo-product-cloner - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#33)

by Pascal

created 2021-09-07 15:24 UTC

TestKernel A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	37
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
eloc	8
c	1
b	0
f	0
dl	0
loc	37
rs	10
wmc	5

3 Methods

Rating	Name	Size	Complexity
A	registerBundles()	8	3
A	getProjectDir()	3	1
A	getRootDir()	3	1

<?php

declare(strict_types=1);

namespace Flagbit\Bundle\ProductClonerBundle\Test\Kernel;

require_once __DIR__.'/../../vendor/akeneo/pim-community-dev/src/Kernel.php';

use Kernel;

/**
 * Test kernel used for integration tests
 */
class TestKernel extends Kernel
{
    /**
     * {@inheritDoc}
     *
     * @return iterable
     */
    public function registerBundles(): iterable
    {
        $bundles = require __DIR__ . '/../../vendor/akeneo/pim-community-dev/config/bundles.php';
        $bundles += require __DIR__ . '/config/bundles.php';

        foreach ($bundles as $class => $envs) {
            if ($envs[$this->environment] ?? $envs['all'] ?? false) {
                yield new $class();
interface HasName {
    /** @return string */
    public function getName();
}

class Name {
    public $name;
}

class User implements HasName {
    /** @return string|Name */
    public function getName() {
        return new Name('foo'); // This is a violation of the ``HasName`` interface
                                // which only allows a string value to be returned.
    }
}
            }
        }
    }

    /**
     * {@inheritDoc}
     *
     * @return string
     */
    public function getRootDir(): string
    {
        return __DIR__;
    }

    /**
     * {@inheritDoc}
     *
     * @return string
     */
    public function getProjectDir(): string
    {
        return __DIR__;
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace Flagbit\Bundle\ProductClonerBundle\Test\Kernel;
6
7			require_once __DIR__.'/../../vendor/akeneo/pim-community-dev/src/Kernel.php';
8
9			use Kernel;
10
11			/**
12			* Test kernel used for integration tests
13			*/
14			class TestKernel extends Kernel
15			{
16			/**
17			* {@inheritDoc}
18			*
19			* @return iterable
20			*/
21			public function registerBundles(): iterable
22			{
23			$bundles = require __DIR__ . '/../../vendor/akeneo/pim-community-dev/config/bundles.php';
24			$bundles += require __DIR__ . '/config/bundles.php';
25
26			foreach ($bundles as $class => $envs) {
27			if ($envs[$this->environment] ?? $envs['all'] ?? false) {
28			yield new $class();
			0 ignored issues – show Bug Best Practice introduced 2021-09-07 14:52 UTC by Report Bug Copy Issue Report The expression `yield new $class()` returns the type `Generator` which is incompatible with the return type mandated by `Symfony\Component\HttpKe...face::registerBundles()` of `Symfony\Component\HttpKe...dleInterface[]\|iterable`. In the issue above, the returned value is violating the contract defined by the mentioned interface. Let's take a look at an example: interface HasName { /** @return string / public function getName(); } class Name { public $name; } class User implements HasName { /* @return string\|Name */ public function getName() { return new Name('foo'); // This is a violation of the ``HasName`` interface // which only allows a string value to be returned. } } Loading history...
29			}
30			}
31			}
32
33			/**
34			* {@inheritDoc}
35			*
36			* @return string
37			*/
38			public function getRootDir(): string
39			{
40			return __DIR__;
41			}
42
43			/**
44			* {@inheritDoc}
45			*
46			* @return string
47			*/
48			public function getProjectDir(): string
49			{
50			return __DIR__;
51			}
52			}
53

Flagbit / akeneo-product-cloner

Pull Request — master (#33)

TestKernel A

Complexity

Size/Duplication

Importance

3 Methods

Duplication Side-by-Side

Filter issues like