ProductModelController::__construct() - Code Metrics - Inspection of "Configure a blacklist of attributes that shouldn't..." - Flagbit/akeneo-product-cloner - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#23)

by Claudio

created 2020-02-17 13:09 UTC

ProductModelController::__construct() A

↳ Parent: ProductModelController

Complexity

Conditions	1
Paths	1

Size

Total Lines	20
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
eloc	9
c	1
b	0
f	0
dl	0
loc	20
rs	9.9666
cc	1
nc	1
nop	9

How to fix Many Parameters

<?php

namespace Flagbit\Bundle\ProductClonerBundle\Controller;

use Akeneo\Tool\Component\StorageUtils\Factory\SimpleFactoryInterface;
use Akeneo\Tool\Component\StorageUtils\Saver\SaverInterface;
use Akeneo\Tool\Component\StorageUtils\Updater\ObjectUpdaterInterface;
use Oro\Bundle\SecurityBundle\Annotation\AclAncestor;
use Akeneo\Pim\Structure\Component\Repository\AttributeRepositoryInterface;
use Akeneo\Pim\Enrichment\Component\Product\Repository\ProductModelRepositoryInterface;
use Symfony\Component\HttpFoundation\JsonResponse;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\Response;
use Symfony\Component\Serializer\Normalizer\NormalizerInterface;
use Symfony\Component\Validator\Validator\ValidatorInterface;

class ProductModelController extends AbstractController
{
    /**
     * @var ProductModelRepositoryInterface
     */
    private $productModelRepository;

    /**
     * @var NormalizerInterface
     */
    private $normalizer;

    /**
     * @var SimpleFactoryInterface
     */
    private $productModelFactory;

    /**
     * @var ObjectUpdaterInterface
     */
    private $productModelUpdater;

    /**
     * @var SaverInterface
     */
    private $productModelSaver;

    /**
     * @var ValidatorInterface
     */
    private $validator;

    /**
     * @var NormalizerInterface
     */
    private $violationNormalizer;

    /**
     * @var AttributeRepositoryInterface
     */
    private $attributeRepository;

    /**
     * @var string[]
     */
    private $attributeCodeBlacklist;

    public function __construct(
        ProductModelRepositoryInterface $productModelRepository,
        AttributeRepositoryInterface $attributeRepository,
        NormalizerInterface $normalizer,
        SimpleFactoryInterface $productModelFactory,
        ObjectUpdaterInterface $productModelUpdater,
        SaverInterface $productModelSaver,
        ValidatorInterface $validator,
        NormalizerInterface $violationNormalizer,
        array $attributeCodeBlacklist = []
    ) {
        $this->productModelRepository = $productModelRepository;
        $this->normalizer = $normalizer;
        $this->productModelFactory = $productModelFactory;
        $this->productModelUpdater = $productModelUpdater;
        $this->productModelSaver = $productModelSaver;
        $this->validator = $validator;
        $this->violationNormalizer = $violationNormalizer;
        $this->attributeRepository = $attributeRepository;
        $this->attributeCodeBlacklist = $attributeCodeBlacklist;
    }

    /**
     * @param Request $request
     *
     * @AclAncestor("pim_enrich_product_model_create")
     *
     * @return JsonResponse
     */
    public function cloneAction(Request $request) : JsonResponse
    {
        $content = json_decode($request->getContent(), true);

        try {
            // check 'code_to_clone' is provided otherwise HTTP bad request
            if (false === isset($content['code_to_clone'])) {
                $message = [['message' => 'Field "code_to_clone" is missing.']];
                return new JsonResponse(['values' => $message], Response::HTTP_BAD_REQUEST);
            }

            // check 'code' is provided otherwise HTTP bad request
            if (false === isset($content['code'])) {
                $message = [['message' => 'Failed "Code" is missing.']];
                return new JsonResponse(['values' => $message], Response::HTTP_BAD_REQUEST);
            }

            // check whether product to be cloned is found otherwise not found HTTP
            $productModel = $this->productModelRepository->findOneByIdentifier($content['code_to_clone']);
            if (null === $productModel) {
                $message = [['message' => sprintf(
                    'Product model with code %s could not be found.',
                    $content['code_to_clone']
                )]];
                return new JsonResponse(
                    ['values' => $message],
                    Response::HTTP_NOT_FOUND
                );
            }
            unset($content['code_to_clone']);
            // create a new product model
            $cloneProductModel = $this->productModelFactory->create();

            // clone product using Akeneo normalizer and updater for reusing code
            $normalizedProduct = $this->normalizeProduct($productModel);
            $this->productModelUpdater->update($cloneProductModel, $normalizedProduct);
            $this->productModelUpdater->update($cloneProductModel, /** @scrutinizer ignore-type */ $normalizedProduct);
            $this->productModelUpdater->update($cloneProductModel, $content);
            $cloneProductModel->setCode($content['code']);
            // validate product model clone and return violations if found
            $violations = $this->validator->validate($cloneProductModel);
            if (count($violations) > 0) {
                $normalizedViolations = [];
                foreach ($violations as $violation) {
                    $violation = $this->violationNormalizer->normalize(
                        $violation,
                        'internal_api',
                        ['product_model' => $cloneProductModel]
                    );
                    $normalizedViolations[] = $violation;
                }
                return new JsonResponse(['values' => $normalizedViolations], Response::HTTP_BAD_REQUEST);
            }
            $this->productModelSaver->save($cloneProductModel);
            return new JsonResponse();
        } catch (\Exception $e) {
            return new JsonResponse(['values' => [['message' => $e->getMessage()]]], Response::HTTP_BAD_REQUEST);
        }
    }

    /**
     * @return string[]
     */
    protected function getAttributeCodeBlacklist() : array
    {
        return $this->attributeCodeBlacklist;
    }

    protected function getNormalizer() : NormalizerInterface
    {
        return $this->normalizer;
    }

    protected function getAttributeRepository() : AttributeRepositoryInterface
    {
        return $this->attributeRepository;
    }
}


Flagbit / akeneo-product-cloner

Pull Request — master (#23)

ProductModelController::__construct() A

Complexity

Size

Duplication

Importance

How to fix Many Parameters

Many Parameters

Duplication Side-by-Side

Filter issues like