Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 7 | class CollectorCollectionTest extends TestCase |
||
| 8 | { |
||
| 9 | /** |
||
| 10 | * @var CollectorCollection |
||
| 11 | */ |
||
| 12 | private $collectorCollection; |
||
| 13 | |||
| 14 | /** |
||
| 15 | * @var \PHPUnit_Framework_MockObject_MockObject |
||
| 16 | */ |
||
| 17 | private $collector; |
||
| 18 | |||
| 19 | protected function setUp() |
||
| 25 | |||
| 26 | public function testIncrement() |
||
| 37 | |||
| 38 | public function testDecrement() |
||
| 49 | |||
| 50 | View Code Duplication | public function testTiming() |
|
| 62 | |||
| 63 | View Code Duplication | public function testMeasure() |
|
| 75 | |||
| 76 | public function testFlush() |
||
| 84 | } |
||
| 85 |
It seems like the type of the argument is not accepted by the function/method which you are calling.
In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug.
We suggest to add an explicit type cast like in the following example: