CurrencyTest::testDefaultCurrencyName() - Code Metrics - Flagbit/FlagbitCurrencyBundle - Measure and Improve Code Quality continuously with Scrutinizer

CurrencyTest::testDefaultCurrencyName() A
last analyzed 2018-07-23 08:42 UTC

↳ Parent: CurrencyTest

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	10
Ratio	100 %

Importance

Changes

Metric	Value
dl	10
loc	10
rs	9.9332
c	0
b	0
f	0
cc	1
nc	1
nop	0

<?php

namespace Flagbit\Bundle\CurrencyBundle\Tests\Service;

use Flagbit\Bundle\CurrencyBundle\Service\Currency;
use PHPUnit\Framework\TestCase;
use PHPUnit_Framework_MockObject_MockObject;

class CurrencyTest extends TestCase
{
    /**
     * @var PHPUnit_Framework_MockObject_MockObject
     */
    private $currencyBundle;

    /**
     * @var Currency
     */
    private $currency;

    protected function setUp()
    {
        $this->currencyBundle = $this->getMockBuilder('Symfony\Component\Intl\ResourceBundle\CurrencyBundleInterface')
            ->getMockForAbstractClass();
        $this->currency = new Currency($this->currencyBundle, 'EUR');
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    public function testDefaultCurrency()
    {
        $this->assertEquals('EUR', $this->currency->getDefaultCurrency());
    }

    public function testDefaultCurrencySymbol()

    {
        $this->currencyBundle
            ->expects($this->once())
            ->method('getCurrencySymbol')
            ->with('EUR')
            ->will($this->returnValue('€'));

        $this->assertEquals('€', $this->currency->getCurrencySymbol());
    }

    public function testCurrencySymbol()

    {
        $this->currencyBundle
            ->expects($this->once())
            ->method('getCurrencySymbol')
            ->with('USD')
            ->will($this->returnValue('$'));

        $this->assertEquals('$', $this->currency->getCurrencySymbol('USD'));
    }

    public function testDefaultCurrencyName()

    {
        $this->currencyBundle
            ->expects($this->once())
            ->method('getCurrencyName')
            ->with('EUR')
            ->will($this->returnValue('Euro'));

        $this->assertEquals('Euro', $this->currency->getCurrencyName());
    }

    public function testCurrencyName()

    {
        $this->currencyBundle
            ->expects($this->once())
            ->method('getCurrencyName')
            ->with('USD')
            ->will($this->returnValue('US Dollar'));

        $this->assertEquals('US Dollar', $this->currency->getCurrencyName('USD'));
    }
}


1		<?php
2
3		namespace Flagbit\Bundle\CurrencyBundle\Tests\Service;
4
5		use Flagbit\Bundle\CurrencyBundle\Service\Currency;
6		use PHPUnit\Framework\TestCase;
7		use PHPUnit_Framework_MockObject_MockObject;
8
9		class CurrencyTest extends TestCase
10		{
11		/**
12		* @var PHPUnit_Framework_MockObject_MockObject
13		*/
14		private $currencyBundle;
15
16		/**
17		* @var Currency
18		*/
19		private $currency;
20
21		protected function setUp()
22		{
23		$this->currencyBundle = $this->getMockBuilder('Symfony\Component\Intl\ResourceBundle\CurrencyBundleInterface')
24		->getMockForAbstractClass();
25		$this->currency = new Currency($this->currencyBundle, 'EUR');
		0 ignored issues – show Documentation introduced 2018-07-23 08:11 UTC by Report Bug Copy Issue Report `$this->currencyBundle` is of type `object<PHPUnit\Framework\MockObject\MockObject>`, but the function expects a `object<Symfony\Component...urrencyBundleInterface>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
26		}
27
28		public function testDefaultCurrency()
29		{
30		$this->assertEquals('EUR', $this->currency->getDefaultCurrency());
31		}
32
33	View Code Duplication	public function testDefaultCurrencySymbol()
		0 ignored issues – show Duplication introduced 2018-07-23 08:11 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
34		{
35		$this->currencyBundle
36		->expects($this->once())
37		->method('getCurrencySymbol')
38		->with('EUR')
39		->will($this->returnValue('€'));
40
41		$this->assertEquals('€', $this->currency->getCurrencySymbol());
42		}
43
44	View Code Duplication	public function testCurrencySymbol()
		0 ignored issues – show Duplication introduced 2018-07-23 08:11 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
45		{
46		$this->currencyBundle
47		->expects($this->once())
48		->method('getCurrencySymbol')
49		->with('USD')
50		->will($this->returnValue('$'));
51
52		$this->assertEquals('$', $this->currency->getCurrencySymbol('USD'));
53		}
54
55	View Code Duplication	public function testDefaultCurrencyName()
		0 ignored issues – show Duplication introduced 2018-07-23 08:11 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
56		{
57		$this->currencyBundle
58		->expects($this->once())
59		->method('getCurrencyName')
60		->with('EUR')
61		->will($this->returnValue('Euro'));
62
63		$this->assertEquals('Euro', $this->currency->getCurrencyName());
64		}
65
66	View Code Duplication	public function testCurrencyName()
		0 ignored issues – show Duplication introduced 2018-07-23 08:11 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
67		{
68		$this->currencyBundle
69		->expects($this->once())
70		->method('getCurrencyName')
71		->with('USD')
72		->will($this->returnValue('US Dollar'));
73
74		$this->assertEquals('US Dollar', $this->currency->getCurrencyName('USD'));
75		}
76		}
77

Flagbit / FlagbitCurrencyBundle

CurrencyTest::testDefaultCurrencyName() A last analyzed 2018-07-23 08:42 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

CurrencyTest::testDefaultCurrencyName() A
last analyzed 2018-07-23 08:42 UTC