Issues in Serializer.php (master) - Issues in master - FiveLab/Resource - Measure and Improve Code Quality continuously with Scrutinizer

Issues (33)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Serializer/Serializer.php (10 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

declare(strict_types = 1);

/*
 * This file is part of the FiveLab Resource package
 *
 * (c) FiveLab
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code
 */

namespace FiveLab\Component\Resource\Serializer;

use FiveLab\Component\Resource\Resource\ResourceInterface;
use FiveLab\Component\Resource\Serializer\Events\AfterDenormalizationEvent;
use FiveLab\Component\Resource\Serializer\Events\AfterNormalizationEvent;
use FiveLab\Component\Resource\Serializer\Events\BeforeDenormalizationEvent;
use FiveLab\Component\Resource\Serializer\Events\BeforeNormalizationEvent;
use Symfony\Component\EventDispatcher\EventDispatcherInterface;
use Symfony\Component\Serializer\Normalizer\DenormalizerAwareInterface;
use Symfony\Component\Serializer\Normalizer\DenormalizerInterface;
use Symfony\Component\Serializer\Normalizer\NormalizerAwareInterface;
use Symfony\Component\Serializer\Normalizer\NormalizerInterface;
use Symfony\Component\Serializer\Serializer as SymfonySerializer;

/**
 * Override the default serializer for add ability for adding dynamically
 * normalizers before serialization and deserialization processes.
 *
 * @author Vitaliy Zhuk <[email protected]>
 */
class Serializer extends SymfonySerializer implements SerializerInterface
{
    /**
     * @var EventDispatcherInterface
     */
    private $eventDispatcher;

    /**
     * Constructor.
     *
     * @param array                    $normalizers
     * @param array                    $encoders
     * @param EventDispatcherInterface $eventDispatcher
     */
    public function __construct(array $normalizers, array $encoders, EventDispatcherInterface $eventDispatcher)
    {
        parent::__construct($normalizers, $encoders);

        $this->eventDispatcher = $eventDispatcher;
    }

    /**
     * {@inheritdoc}
     *
     * @throws \Exception
     */
    public function normalize($data, $format = null, array $context = [])
    {
        if ($data instanceof ResourceInterface) {
            $event = new BeforeNormalizationEvent($data, (string) $format, $context);
            $this->eventDispatcher->dispatch(SerializationEvents::BEFORE_NORMALIZATION, $event);
        }

        $countNormalizers = 0;

        if (\array_key_exists('normalizers', $context)) {

            /** @var NormalizerInterface[] $normalizers */
            $normalizers = \array_reverse($context['normalizers']);

            foreach ($normalizers as $normalizer) {
                if ($normalizer instanceof NormalizerInterface) {
                    $countNormalizers++;

                    $this->prepareNormalizer($normalizer);
                    \array_unshift($this->normalizers, $normalizer);
                }
            }
        }

        try {
            $normalized = parent::normalize($data, $format, $context);
        } finally {
            for ($i = 0; $i < $countNormalizers; $i++) {
function fx() {
    try {
        doSomething();
        return true;
    }
    catch (\Exception $e) {
        return false;
    }

    return false;
}
                \array_shift($this->normalizers);
            }
        }

        if ($data instanceof ResourceInterface) {

            $event = new AfterNormalizationEvent($data, $normalized, (string) $format, $context);
            $this->eventDispatcher->dispatch(SerializationEvents::AFTER_NORMALIZATION, $event);
        }

        return $normalized;
    }

    /**
     * {@inheritdoc}
     */
    public function denormalize($data, $type, $format = null, array $context = [])
    {
        if (\is_a($type, ResourceInterface::class, true)) {

            $event = new BeforeDenormalizationEvent($data, $type, $format, $context);
            $this->eventDispatcher->dispatch(SerializationEvents::BEFORE_DENORMALIZATION, $event);
        }

        $countDenormalizers = 0;

        if (\array_key_exists('normalizers', $context)) {

            /** @var NormalizerInterface[] $normalizers */
            $normalizers = \array_reverse($context['normalizers']);

            foreach ($normalizers as $normalizer) {
                if ($normalizer instanceof DenormalizerInterface) {
                    $countDenormalizers++;

                    $this->prepareDenormalizer($normalizer);
                    \array_unshift($this->normalizers, $normalizer);
                }
            }
        }

        try {
            $denormalized = parent::denormalize($data, $type, $format, $context);
        } finally {
            for ($i = 0; $i < $countDenormalizers; $i++) {
function fx() {
    try {
        doSomething();
        return true;
    }
    catch (\Exception $e) {
        return false;
    }

    return false;
}
                \array_shift($this->normalizers);
            }
        }

        if (\is_a($type, ResourceInterface::class, true)) {

            $event = new AfterDenormalizationEvent($data, $denormalized, (string) $format, $context);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $this->eventDispatcher->dispatch(SerializationEvents::AFTER_DENORMALIZATION, $event);
        }

        return $denormalized;
    }

    /**
     * Prepare normalizer
     *
     * @param NormalizerInterface $normalizer
     */
    private function prepareNormalizer(NormalizerInterface $normalizer): void
    {
        if ($normalizer instanceof NormalizerAwareInterface) {
            $normalizer->setNormalizer($this);
        }
    }

    /**
     * Prepare denormalizer
     *
     * @param DenormalizerInterface $denormalizer
     */
    private function prepareDenormalizer(DenormalizerInterface $denormalizer): void
    {
        if ($denormalizer instanceof DenormalizerAwareInterface) {
            $denormalizer->setDenormalizer($this);
        }
    }
}


1			<?php
2
3			declare(strict_types = 1);
4
5			/*
6			* This file is part of the FiveLab Resource package
7			*
8			* (c) FiveLab
9			*
10			* For the full copyright and license information, please view the LICENSE
11			* file that was distributed with this source code
12			*/
13
14			namespace FiveLab\Component\Resource\Serializer;
15
16			use FiveLab\Component\Resource\Resource\ResourceInterface;
17			use FiveLab\Component\Resource\Serializer\Events\AfterDenormalizationEvent;
18			use FiveLab\Component\Resource\Serializer\Events\AfterNormalizationEvent;
19			use FiveLab\Component\Resource\Serializer\Events\BeforeDenormalizationEvent;
20			use FiveLab\Component\Resource\Serializer\Events\BeforeNormalizationEvent;
21			use Symfony\Component\EventDispatcher\EventDispatcherInterface;
22			use Symfony\Component\Serializer\Normalizer\DenormalizerAwareInterface;
23			use Symfony\Component\Serializer\Normalizer\DenormalizerInterface;
24			use Symfony\Component\Serializer\Normalizer\NormalizerAwareInterface;
25			use Symfony\Component\Serializer\Normalizer\NormalizerInterface;
26			use Symfony\Component\Serializer\Serializer as SymfonySerializer;
27
28			/**
29			* Override the default serializer for add ability for adding dynamically
30			* normalizers before serialization and deserialization processes.
31			*
32			* @author Vitaliy Zhuk <[email protected]>
33			*/
34			class Serializer extends SymfonySerializer implements SerializerInterface
35			{
36			/**
37			* @var EventDispatcherInterface
38			*/
39			private $eventDispatcher;
40
41			/**
42			* Constructor.
43			*
44			* @param array $normalizers
45			* @param array $encoders
46			* @param EventDispatcherInterface $eventDispatcher
47			*/
48	8		public function __construct(array $normalizers, array $encoders, EventDispatcherInterface $eventDispatcher)
49			{
50	8		parent::__construct($normalizers, $encoders);
51
52	8		$this->eventDispatcher = $eventDispatcher;
53	8		}
54
55			/**
56			* {@inheritdoc}
57			*
58			* @throws \Exception
59			*/
60	4		public function normalize($data, $format = null, array $context = [])
61			{
62	4		if ($data instanceof ResourceInterface) {
63	4		$event = new BeforeNormalizationEvent($data, (string) $format, $context);
64	4		$this->eventDispatcher->dispatch(SerializationEvents::BEFORE_NORMALIZATION, $event);
65			}
66
67	4		$countNormalizers = 0;
68
69	4	View Code Duplication	if (\array_key_exists('normalizers', $context)) {
			0 ignored issues – show Duplication introduced 2020-07-14 07:57 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
70			/** @var NormalizerInterface[] $normalizers */
71	2		$normalizers = \array_reverse($context['normalizers']);
72
73	2		foreach ($normalizers as $normalizer) {
74	2		if ($normalizer instanceof NormalizerInterface) {
75	2		$countNormalizers++;
76
77	2		$this->prepareNormalizer($normalizer);
78	2		\array_unshift($this->normalizers, $normalizer);
79			}
80			}
81			}
82
83			try {
84	4		$normalized = parent::normalize($data, $format, $context);
85	3		} finally {
86	4		for ($i = 0; $i < $countNormalizers; $i++) {
			0 ignored issues – show Unused Code introduced 2017-08-06 10:26 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$i = 0;` does not seem to be reachable. This check looks for unreachable code. It uses sophisticated control flow analysis techniques to find statements which will never be executed. Unreachable code is most often the result of `return`, `die` or `exit` statements that have been added for debug purposes. function fx() { try { doSomething(); return true; } catch (\Exception $e) { return false; } return false; } In the above example, the last `return false` will never be executed, because a return statement has already been met in every possible execution path. Loading history... Bug introduced 2017-08-06 10:26 UTC by Report Bug Copy Issue Report Show Similar Issues like this The variable `$i` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
87	2		\array_shift($this->normalizers);
88			}
89			}
90
91	3	View Code Duplication	if ($data instanceof ResourceInterface) {
			0 ignored issues – show Duplication introduced 2017-08-06 10:26 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
92	3		$event = new AfterNormalizationEvent($data, $normalized, (string) $format, $context);
93	3		$this->eventDispatcher->dispatch(SerializationEvents::AFTER_NORMALIZATION, $event);
94			}
95
96	3		return $normalized;
97			}
98
99			/**
100			* {@inheritdoc}
101			*/
102	4		public function denormalize($data, $type, $format = null, array $context = [])
103			{
104	4	View Code Duplication	if (\is_a($type, ResourceInterface::class, true)) {
			0 ignored issues – show Duplication introduced 2020-07-14 07:57 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
105	4		$event = new BeforeDenormalizationEvent($data, $type, $format, $context);
106	4		$this->eventDispatcher->dispatch(SerializationEvents::BEFORE_DENORMALIZATION, $event);
107			}
108
109	4		$countDenormalizers = 0;
110
111	4	View Code Duplication	if (\array_key_exists('normalizers', $context)) {
			0 ignored issues – show Duplication introduced 2020-07-14 07:57 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
112			/** @var NormalizerInterface[] $normalizers */
113	2		$normalizers = \array_reverse($context['normalizers']);
114
115	2		foreach ($normalizers as $normalizer) {
116	2		if ($normalizer instanceof DenormalizerInterface) {
117	2		$countDenormalizers++;
118
119	2		$this->prepareDenormalizer($normalizer);
120	2		\array_unshift($this->normalizers, $normalizer);
121			}
122			}
123			}
124
125			try {
126	4		$denormalized = parent::denormalize($data, $type, $format, $context);
127	3		} finally {
128	4		for ($i = 0; $i < $countDenormalizers; $i++) {
			0 ignored issues – show Unused Code introduced 2020-07-14 07:57 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$i = 0;` does not seem to be reachable. This check looks for unreachable code. It uses sophisticated control flow analysis techniques to find statements which will never be executed. Unreachable code is most often the result of `return`, `die` or `exit` statements that have been added for debug purposes. function fx() { try { doSomething(); return true; } catch (\Exception $e) { return false; } return false; } In the above example, the last `return false` will never be executed, because a return statement has already been met in every possible execution path. Loading history... Bug introduced 2020-07-14 07:57 UTC by Report Bug Copy Issue Report Show Similar Issues like this The variable `$i` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
129	2		\array_shift($this->normalizers);
130			}
131			}
132
133	3	View Code Duplication	if (\is_a($type, ResourceInterface::class, true)) {
			0 ignored issues – show Duplication introduced 2020-07-14 07:57 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
134	3		$event = new AfterDenormalizationEvent($data, $denormalized, (string) $format, $context);
			0 ignored issues – show Documentation introduced 2020-07-14 07:57 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$denormalized` is of type `object\|array`, but the function expects a `object<FiveLab\Component...urce\ResourceInterface>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
135	3		$this->eventDispatcher->dispatch(SerializationEvents::AFTER_DENORMALIZATION, $event);
136			}
137
138	3		return $denormalized;
139			}
140
141			/**
142			* Prepare normalizer
143			*
144			* @param NormalizerInterface $normalizer
145			*/
146	2		private function prepareNormalizer(NormalizerInterface $normalizer): void
147			{
148	2		if ($normalizer instanceof NormalizerAwareInterface) {
149	2		$normalizer->setNormalizer($this);
150			}
151	2		}
152
153			/**
154			* Prepare denormalizer
155			*
156			* @param DenormalizerInterface $denormalizer
157			*/
158	2		private function prepareDenormalizer(DenormalizerInterface $denormalizer): void
159			{
160	2		if ($denormalizer instanceof DenormalizerAwareInterface) {
161	2		$denormalizer->setDenormalizer($this);
162			}
163	2		}
164			}
165

FiveLab / Resource

Issues (33)

Security Analysis no request data

src/Serializer/Serializer.php (10 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like