FiveLab\Component\Resource\Serializers\Hateoas\Normalizer\ResourceCollectionObjectNormalizer

Complexity

Total Complexity

9

Size/Duplication

Total Lines	56
Duplicated Lines	12.5 %

Coupling/Cohesion

Components	1
Dependencies	3

Test Coverage

Coverage

100%

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
C	normalize()	7	36	7
A	supportsNormalization()	0	4	2

<?php

declare(strict_types = 1);

/*
 * This file is part of the FiveLab Resource package
 *
 * (c) FiveLab
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code
 */

namespace FiveLab\Component\Resource\Serializers\Hateoas\Normalizer;

use FiveLab\Component\Resource\Resource\ResourceCollection;
use Symfony\Component\Serializer\Normalizer\NormalizerAwareInterface;
use Symfony\Component\Serializer\Normalizer\NormalizerAwareTrait;
use Symfony\Component\Serializer\Normalizer\NormalizerInterface;

/**
 * The normalizer for normalize resource collection.
 *
 * @author Vitaliy Zhuk <v.zhuk@fivelab.org>
 */
class ResourceCollectionObjectNormalizer implements NormalizerInterface, NormalizerAwareInterface
{
    use NormalizerAwareTrait;

    /**
     * {@inheritdoc}
     *
     * @param ResourceCollection $object
     *
     * @throws \InvalidArgumentException
     */
    public function normalize($object, $format = null, array $context = [])
    {
        if (!$object instanceof ResourceCollection) {

This code seems to be duplicated across your project.

            throw new \InvalidArgumentException(sprintf(
                'The normalizer support only "%s" but "%s" given.',
                ResourceCollection::class,
                is_object($object) ? get_class($object) : gettype($object)
            ));
        }

        $data = [];
        $links = [];

        if (count($object->getRelations())) {
            $links = array_merge($links, $this->normalizer->normalize($object->getRelations(), $format, $context));

It seems like $object->getRelations() targeting FiveLab\Component\Resource\Resource\AbstractResourceSupport::getRelations() can also be of type array<integer,object<FiveLab\Component\Resource\Resource\Relation\RelationInterface>>; however, Symfony\Component\Serializer\Normalizer\NormalizerInterface::normalize() does only seem to accept object, maybe add an additional type check?

        }

        if (count($object->getActions())) {
            $links = array_merge($links, $this->normalizer->normalize($object->getActions(), $format, $context));

It seems like $object->getActions() targeting FiveLab\Component\Resource\Resource\AbstractResourceSupport::getActions() can also be of type array<integer,object<FiveLab\Component\Resource\Resource\Action\ActionInterface>>; however, Symfony\Component\Serializer\Normalizer\NormalizerInterface::normalize() does only seem to accept object, maybe add an additional type check?

        }

        foreach ($object as $resource) {
            $data[] = $this->normalizer->normalize($resource, $format, $context);

It seems like $resource defined by $resource on line 58 can also be of type false; however, Symfony\Component\Serializer\Normalizer\NormalizerInterface::normalize() does only seem to accept object, did you maybe forget to handle an error condition?

        }

        if (count($links)) {
            return [
                '_links' => $links,
                '_embedded' => [
                    'items' => $data,
                ],
            ];
        }

        return $data;
    }

    /**
     * {@inheritdoc}
     */
    public function supportsNormalization($data, $format = null): bool
    {
        return is_object($data) && $data instanceof ResourceCollection;
    }
}