YubikeyMemberAuthenticatorTest::testYubikeyAfterSuccess() - Code Metrics - Inspection of "Marco/master" - Firesphere/silverstripe-yubiauth - Measure and Improve Code Quality continuously with Scrutinizer

Passed
Pull Request — master (#13)

by Simon
created 2018-05-15 07:04 UTC
testYubikeyAfterSuccess() B

↳ Parent: YubikeyMemberAuthenticatorTest
Complexity

Conditions	1
Paths	1
Size

Total Lines	26
Code Lines	20
Duplication

Lines	0
Ratio	0 %
Importance

Changes
Metric	Value
cc	1
eloc	20
nc	1
nop	0
dl	0
loc	26
rs	8.8571
c	0
b	0
f	0
<?php

namespace Firesphere\YubiAuth\Tests;

use Firesphere\YubiAuth\Authenticators\YubikeyMemberAuthenticator;
use Firesphere\YubiAuth\Forms\YubikeyForm;
use Firesphere\YubiAuth\Forms\YubikeyLoginForm;
use Firesphere\YubiAuth\Handlers\YubikeyLoginHandler;
use Firesphere\YubiAuth\Providers\YubikeyAuthProvider;
use SilverStripe\Control\HTTPRequest;
use SilverStripe\Control\Session;
use SilverStripe\Core\Injector\Injector;
use SilverStripe\Dev\SapphireTest;
use SilverStripe\ORM\ValidationResult;
use SilverStripe\Security\IdentityStore;
use SilverStripe\Security\Member;
use SilverStripe\Security\Security;
use Yubikey\Validate;

class YubikeyMemberAuthenticatorTest extends SapphireTest
{
    protected static $fixture_file = '../fixtures/Member.yml';

    /**
     * @var YubikeyLoginHandler
     */
    protected $handler;
    /**
     * @var YubikeyLoginForm
     */
    protected $form;

    /**
     * @var YubikeyMemberAuthenticator
     */
    protected $authenticator;

    protected $request;

    public function setUp()
    {
        parent::setUp();
        $this->objFromFixture(Member::class, 'admin');
        $validator = new MockYubiValidate('apikey', '1234');
        $this->authenticator = Injector::inst()->get(YubikeyMemberAuthenticator::class);
        $this->handler = Injector::inst()->createWithArgs(
            YubikeyLoginHandler::class,
            [Security::login_url(), $this->authenticator]
        );
        $this->form = Injector::inst()->get(
            YubikeyLoginForm::class,
            true,
            [$this->handler, YubikeyMemberAuthenticator::class, '']
        );
        Injector::inst()->registerService($validator, Validate::class);
    }

    public function tearDown()
    {
        parent::tearDown();
    }

    public function testNoYubikey()
    {
        $request = new HTTPRequest('POST', '/');
        $request->setSession(new Session(['hi' => 'bye']));
        $this->handler->setRequest($request);

        $this->handler->doLogin(
            [
                'Email'    => '[email protected]',
                'Password' => 'password',
            ],
            $this->form,
            $request
        );
        $this->handler->validateYubikey(
            ['yubiauth' => ''],
            YubikeyForm::create($this->handler),
            $request
        );
        $member = Member::get()->filter(['Email' => '[email protected]'])->first();
        $this->assertGreaterThan(0, $member->NoYubikeyCount);
        $this->assertEquals(null, $member->Yubikey);
    }

    public function testNoYubikeySuccess()
    {
        /** @var Member $member */
        $member = Member::get()->filter(['Email' => '[email protected]'])->first();
        $member->NoYubikeyCount = 0;
        $member->YubiAuthEnabled = false;
        $member->write();
        $request = new HTTPRequest('POST', '/');
        $request->setSession(new Session(['hi' => 'bye']));
        $this->handler->setRequest($request);
        $this->handler->doLogin(
            [

                'Email'    => '[email protected]',
                'Password' => 'password',
            ],
            $this->form,
            $request
        );
        $this->handler->validateYubikey(
            ['yubiauth' => ''],
            YubikeyForm::create($this->handler),
            $request
        );
        $member = Member::get()->filter(['Email' => '[email protected]'])->first();
        $this->assertEquals(0, $member->FailedLoginCount);
    }

    public function testNoYubikeyLockout()
    {
        /** @var Member $member */
        $member = Member::get()->filter(['Email' => '[email protected]'])->first();
        $failedCount = $member->FailedLoginCount;
        $member->NoYubikeyCount = 25;
        $member->YubiAuthEnabled = false;
        $member->write();
        $request = new HTTPRequest('POST', '/');
        $request->setSession(new Session(['hi' => 'bye']));
        $this->handler->setRequest($request);
        $this->handler->doLogin(
            [

                'Email'    => '[email protected]',
                'Password' => 'password',
            ],
            $this->form,
            $request
        );
        $result = $this->handler->validateYubikey(
            ['yubiauth' => ''],
            YubikeyForm::create($this->handler),
            $request
        );
        $member = Member::get()->filter(['Email' => '[email protected]'])->first();
        $this->assertGreaterThan($failedCount, $member->FailedLoginCount);
        $this->assertFalse($result->isValid());
        $this->assertFalse($result->/** @scrutinizer ignore-call */ isValid());
    }

    public function testNoYubikeyDays()
    {
        /** @var Member $member */
        $member = Member::get()->filter(['Email' => '[email protected]'])->first();
        $failedCount = $member->FailedLoginCount;
        $member->NoYubikeyCount = 26;
        $member->Created = date('Y-m-d', strtotime('-1 year'));
        $member->YubiAuthEnabled = false;
        $member->write();
        $request = new HTTPRequest('POST', '/');
        $request->setSession(new Session(['hi' => 'bye']));
        $this->handler->setRequest($request);
        $this->handler->doLogin(
            [

                'Email'    => '[email protected]',
                'Password' => 'password',
            ],
            $this->form,
            $request
        );
        $result = $this->handler->validateYubikey(
            ['yubiauth' => ''],
            YubikeyForm::create($this->handler),
            $request
        );
        $member = Member::get()->filter(['Email' => '[email protected]'])->first();
        $this->assertGreaterThan($failedCount, $member->FailedLoginCount);
        $this->assertFalse($result->isValid());
    }

    /**
     * @todo The mock currently always returns success
     *
     * public function testDifferentYubikey()
     * {
     * $newMember = Member::create([
     * 'FirstName'       => 'Pete',
     * 'Surname'         => 'Lister',
     * 'Password'        => 'IronMan2005!',
     * 'YubiAuthEnabled' => true,
     * 'Yubikey'         => '1234567890abcdef'
     * ]);
     * $newMember->write();
     *
     * $member = Member::get()->filter(['Email' => '[email protected]'])->first();
     * $failedCount = $member->FailedLoginCount;
     * $member->YubiAuthEnabled = true;
     * $member->write();
     *
     * $request = new HTTPRequest('POST', '/');
     * $request->setSession(new Session(['hi' => 'bye']));
     * $this->handler->setRequest($request);
     * $this->handler->doLogin(
     * [
     *
     * 'Email'    => '[email protected]',
     * 'Password' => 'password',
     * ],
     * $this->form,
     * $request
     * );
     * $this->handler->validateYubikey(
     * ['yubiauth' => '1234567890abcdefyhde.cybcpnbiixcjkbbyd.ydenhnjkn'],
     * YubikeyForm::create($this->handler),
     * $request
     * );
     * $member = Member::get()->filter(['Email' => '[email protected]'])->first();
     * $this->assertGreaterThan($failedCount, $member->FailedLoginCount);
     * }
     */

    public function testYubikeyAfterSuccess()
    {
        $request = new HTTPRequest('POST', '/');
        $request->setSession(new Session(['hi' => 'bye']));
        $this->handler->setRequest($request);
        $member = Member::get()->filter(['Email' => '[email protected]'])->first();
        $member->YubiAuthEnabled = true;
        $member->Yubikey = 'ccccccfinfgr';
        $member->NoYubikeyCount = 50;
        $member->write();
        Injector::inst()->get(IdentityStore::class)->logOut();
        $failedLoginCount = $member->FailedLoginCount;
        $this->handler->doLogin(
            [

                'Email'    => '[email protected]',
                'Password' => 'password',
            ],
            $this->form,
            $request
        );
        $this->handler->validateYubikey(['yubiauth' => ''], YubikeyForm::create($this->handler), $request);
        $resultNoYubi = Security::getCurrentUser();
        $this->assertEquals(null, $resultNoYubi);
        $member = Member::get()->filter(array('Email' => '[email protected]'))->first();
        $this->assertGreaterThan($failedLoginCount, $member->FailedLoginCount);
    }

    public function testYubikey()
    {
        $request = new HTTPRequest('POST', '/');
        $request->setSession(new Session(['hi' => 'bye']));
        $this->handler->setRequest($request);
        $this->handler->doLogin(
            [

                'Email'    => '[email protected]',
                'Password' => 'password',
            ],
            $this->form,
            $request
        );
        $this->handler->validateYubikey(
            [
                // This OTP is _not_ valid in real situations
                'yubiauth' => 'jjjjjjucbuipyhde.cybcpnbiixcjkbbyd.ydenhnjkn'
            ],
            YubikeyForm::create($this->handler),
            $request
        );
        $result = Security::getCurrentUser();
        $this->assertEquals(Member::class, $result->ClassName);
        $this->assertEquals('ccccccfinfgr', $result->Yubikey);
        $this->assertEquals(1, $result->YubiAuthEnabled);
        $this->assertEquals('[email protected]', $result->Email);
        $this->assertEquals(true, $result->YubiAuthEnabled);
        $result->write();
    }

    public function testName()
    {
        $this->assertEquals('Yubikey 2 factor login', YubikeyMemberAuthenticator::get_name());
    }

    public function testGetLoginHandler()
    {
        $authenticator = new YubikeyMemberAuthenticator();

        $handler = $authenticator->getLoginHandler(Security::login_url());

        $this->assertInstanceOf(YubikeyLoginHandler::class, $handler);
    }

    public function testGetSetProvider()
    {
        /** @var YubikeyMemberAuthenticator $authenticator */
        $authenticator = new YubikeyMemberAuthenticator();

        /** @var YubikeyAuthProvider $provider */
        $provider = Injector::inst()->get(YubikeyAuthProvider::class);

        $authenticator->setProvider($provider);

        $this->assertInstanceOf(YubikeyAuthProvider::class, $authenticator->getProvider());
    }

    public function testSupportedServices()
    {
        /** @var YubikeyMemberAuthenticator $authenticator */
        $authenticator = new YubikeyMemberAuthenticator();

        $this->assertEquals(47, $authenticator->supportedServices());
    }
}

Firesphere / silverstripe-yubiauth

Pull Request — master (#13)

testYubikeyAfterSuccess() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like
