Firesphere\YubiAuth\MemberExtension

Complexity

Total Complexity

5

Size/Duplication

Total Lines	67
Duplicated Lines	0 %

Importance

Changes	2
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	onBeforeWrite()	0	6	2
A	updateFieldLabels()	0	4	1
A	updateCMSFields()	0	17	2

<?php

namespace Firesphere\YubiAuth\Extensions;

use SilverStripe\Forms\CheckboxField;
use SilverStripe\Forms\FieldList;
use SilverStripe\Forms\NumericField;
use SilverStripe\ORM\DataExtension;

/**
 * Class YubiAuthMemberExtension
 *
 * Enable yubikey authentication disabling temporarily
 *
 * @property \Firesphere\YubiAuth\Extensions\MemberExtension $owner
 * @property string $Yubikey
 * @property int $NoYubikeyCount
 */
class MemberExtension extends DataExtension
{
    private static $db = [

The private property $db is not used, and could be removed.

        'Yubikey'        => 'Varchar(255)',
        'NoYubikeyCount' => 'Int'
    ];

    private static $indexes = [

The private property $indexes is not used, and could be removed.

        'Yubikey' => 'unique("Yubikey")' // The Yubikey Signature is unique for every Yubikey.
    ];

    /**
     * @inheritdoc
     * @param array $labels
     */
    public function updateFieldLabels(&$labels)
    {
        $labels['Yubikey'] = _t('YubikeyAuthenticator.YUBIKEY', 'Yubikey code');
        $labels['NoYubikeyCount'] = _t('YubikeyAuthenticator.NOYUBIKEYCOUNT', 'Login count without yubikey');
    }

    /**
     * @inheritdoc
     * @param FieldList $fields
     */
    public function updateCMSFields(FieldList $fields)
    {
        $fields->removeByName(['NoYubikeyCount', 'Yubikey', 'YubiAuthEnabled']);
        $yubiCount = NumericField::create('NoYubikeyCount');
        if ($this->owner->YubiAuthEnabled) {

The property YubiAuthEnabled does not exist on Firesphere\YubiAuth\Extensions\MemberExtension. Did you maybe forget to declare it?

            $yubiCount->setReadonly(true);
        }
        $yubiAuth = CheckboxField::create('YubiAuthEnabled');
        $yubiAuth->setDescription(
            _t(
                'YubikeyAuthenticator.ENABLEDDESCRIPTION',
                'If the user is new and doesn\'t have a Yubikey yet, you can disable the auth temporarily'
            )
        );
        $fields->addFieldsToTab('Root.MFA', [$yubiCount, $yubiAuth]);

        return $fields;
    }

    /**
     * @inheritdoc
     */
    public function onBeforeWrite()
    {
        // Empty the yubikey field on member write, if the yubiauth is not required
        // Maybe the user lost the key? So a new one will be set next time it's logged in with key
        if (!$this->owner->MFAEnabled) {

The property MFAEnabled does not exist on Firesphere\YubiAuth\Extensions\MemberExtension. Did you maybe forget to declare it?

            $this->owner->Yubikey = '';
        }
    }
}