Firesphere\StripeSlack\Controller\SlackStatusController

Complexity

Total Complexity

18

Size/Duplication

Total Lines	147
Duplicated Lines	0 %

Importance

Changes

0

8 Methods

Rating	Name	Duplication	Size	Complexity
A	getRequestParams()	0	8	1
A	getClient()	0	6	2
A	usercount()	0	11	4
A	validateResponse()	0	11	3
A	getStatus()	0	18	3
A	getSVGSettings()	0	14	3
A	getSlackCount()	0	9	1
A	badge()	0	12	1

<?php

namespace Firesphere\StripeSlack\Controller;

use Firesphere\StripeSlack\Model\SlackUserCount;
use GuzzleHttp\Client;
use SilverStripe\Control\Controller;
use SilverStripe\Control\HTTPResponse;
use SilverStripe\Core\Convert;
use SilverStripe\ORM\FieldType\DBDatetime;
use SilverStripe\ORM\ValidationException;
use SilverStripe\SiteConfig\SiteConfig;

/**
 * Class SlackStatusController
 *
 */
class SlackStatusController extends Controller
{
    private static $allowed_actions = [

The private property $allowed_actions is not used, and could be removed.

        'usercount',
        'badge'
    ];

    /**
     * @return int
     * @throws ValidationException
     */
    public function usercount()
    {
        /** @var SiteConfig $config */
        $config = SiteConfig::current_site_config();
        // Break if there is a configuration error
        if (!$config->SlackURL || !$config->SlackToken || !$config->SlackChannel) {
            return '';

The expression return '' returns the type string which is incompatible with the documented return type integer.

        }
        $params = $this->getRequestParams($config);

        return $this->getStatus($config, $params);
    }

    /**
     * @return HTTPResponse
     * @throws ValidationException
     */
    public function badge()
    {
        $config = SiteConfig::current_site_config();
        $params = $this->getRequestParams($config);
        $count = $this->getStatus($config, $params);
        list($width, $pos) = $this->getSVGSettings($count);

        $body = $this->renderWith('SVGTemplate', ['Count' => $count, 'Width' => $width, 'Pos' => $pos]);
        $response = new HTTPResponse($body);
        $response->addHeader('Content-Type', 'image/svg+xml');

        return $response;
    }


    protected function getRequestParams($config)
    {
        return [
            'form_params' => [
                'token'   => $config->SlackToken,
                'type'    => 'post',
                'channel' => $config->SlackChannel,
                'scope'   => 'identify,read,post,client',
            ]
        ];
    }

    /**
     * @param SiteConfig $config
     * @param array $params
     * @return int
     * @throws ValidationException
     */
    public function getStatus($config, $params = [])
    {
        /** @var SlackUserCount $count */
        $count = SlackUserCount::get()->first();
        // To limit the amount of API requests, only update the count
        // once every 3 hours
        if ($count) {
            $dateTime = DBDatetime::create();
            $dateTime->setValue($count->LastEdited);
            $diff = explode(' ', $dateTime->TimeDiffIn('hours'));
            if ($diff[0] < 3) {
                return $count->UserCount;
            }
        } else {
            $count = SlackUserCount::create();
        }

        return $this->getSlackCount($config, $params, $count);
    }

    /**
     * @param SiteConfig $config
     * @param array $params
     * @param SlackUserCount $count
     * @return int
     * @throws ValidationException
     */
    protected function getSlackCount($config, $params, $count)
    {
        $service = $this->getClient($config);
        $url = 'api/channels.info?t=' . time();

        $response = $service->request('POST', $url, $params);
        $result = Convert::json2array($response->getBody());

        return $this->validateResponse($count, $result);

It seems like $result can also be of type boolean; however, parameter $result of Firesphere\StripeSlack\Controller\SlackStatusController::validateResponse() does only seem to accept array, maybe add an additional type check?

    }

    /**
     * @param $count
     * @return array
     */
    public function getSVGSettings($count)
    {
        if ($count < 100) {
            $width = 25;
            $pos = 60;
        } elseif ($count < 1000) {
            $width = 35;
            $pos = 65;
        } else {
            $width = 45;
            $pos = 70;
        }

        return [$width, $pos];
    }

    /**
     * @param $config
     * @return Client
     */
    public function getClient($config)
    {
        $baseURL = $config->SlackURL;
        $baseURL = (substr($baseURL, -1) === '/') ? $baseURL : $baseURL . '/';

        return new Client(['base_uri' => $baseURL]);
    }

    /**
     * @param SlackUserCount $count
     * @param array $result
     * @return int
     */
    public function validateResponse($count, $result)
    {
        if (isset($result['ok']) && $result['ok']) {
            $userCount = count($result['channel']['members']);
            $count->UserCount = $userCount;
            $count->write();

            return $userCount;
        }

        return 0;
    }
}