QueryComponentFacetTrait::buildFacetQuery() - Code Metrics - Inspection of "Fixes: Coming from peer review" - Firesphere/silverstripe-solr-search - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — sheepy/introspection ( 000d40...b6b869 )

by Marco

created 2019-07-18 03:03 UTC

QueryComponentFacetTrait::buildFacetQuery() A

↳ Parent: QueryComponentFacetTrait

Complexity

Conditions	5
Paths	8

Size

Total Lines	14
Code Lines	11

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	5
CRAP Score	9.9614

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
eloc	11
dl	0
loc	14
ccs	5
cts	12
cp	0.4167
rs	9.6111
c	1
b	0
f	0
cc	5
nc	8
nop	0
crap	9.9614

<?php


namespace Firesphere\SolrSearch\Traits;

use Firesphere\SolrSearch\Indexes\BaseIndex;
use Firesphere\SolrSearch\Queries\BaseQuery;
use Minimalcode\Search\Criteria;
use SilverStripe\Control\Controller;
use Solarium\QueryType\Select\Query\Query;

trait QueryComponentFacetTrait
{
    /**
     * @var BaseIndex
     */
    protected $index;
    /**
     * @var BaseQuery
     */
    protected $query;
    /**
     * @var Query
     */
    protected $clientQuery;

    /**
     * Add facets from the index
     */
    protected function buildFacets(): void
    {
        $facets = $this->clientQuery->getFacetSet();
        // Facets should be set from the index configuration
        foreach ($this->index->getFacetFields() as $class => $config) {
            $facets->createFacetField('facet-' . $config['Title'])->setField($config['Field']);
        }
        // Count however, comes from the query
        $facets->setMinCount($this->query->getFacetsMinCount());
    }

    /**
     * Add facet filters based on the current request
     */
    protected function buildFacetQuery()
    {
        $filterFacets = [];
        if (Controller::has_curr()) {
            $filterFacets = Controller::curr()->getRequest()->requestVars();
        }
        foreach ($this->index->getFacetFields() as $class => $config) {
            if (array_key_exists($config['Title'], $filterFacets)) {
                $filter = array_filter($filterFacets[$config['Title']], 'strlen');
                if (count($filter)) {
                    $criteria = Criteria::where($config['Field'])->in($filter);
                    $this->clientQuery
                        ->createFilterQuery('facet-' . $config['Title'])
                        ->setQuery($criteria->getQuery());
                }
            }
        }
    }
}


1		<?php
2
3
4		namespace Firesphere\SolrSearch\Traits;
5
6		use Firesphere\SolrSearch\Indexes\BaseIndex;
7		use Firesphere\SolrSearch\Queries\BaseQuery;
8		use Minimalcode\Search\Criteria;
9		use SilverStripe\Control\Controller;
10		use Solarium\QueryType\Select\Query\Query;
11
12		trait QueryComponentFacetTrait
13		{
14		/**
15		* @var BaseIndex
16		*/
17		protected $index;
18		/**
19		* @var BaseQuery
20		*/
21		protected $query;
22		/**
23		* @var Query
24		*/
25		protected $clientQuery;
26
27		/**
28		* Add facets from the index
29		*/
30	4	protected function buildFacets(): void
31		{
32	4	$facets = $this->clientQuery->getFacetSet();
33		// Facets should be set from the index configuration
34	4	foreach ($this->index->getFacetFields() as $class => $config) {
35		$facets->createFacetField('facet-' . $config['Title'])->setField($config['Field']);
36		}
37		// Count however, comes from the query
38	4	$facets->setMinCount($this->query->getFacetsMinCount());
39	4	}
40
41		/**
42		* Add facet filters based on the current request
43		*/
44	4	protected function buildFacetQuery()
45		{
46	4	$filterFacets = [];
47	4	if (Controller::has_curr()) {
48	4	$filterFacets = Controller::curr()->getRequest()->requestVars();
49		}
50	4	foreach ($this->index->getFacetFields() as $class => $config) {
51		if (array_key_exists($config['Title'], $filterFacets)) {
52		$filter = array_filter($filterFacets[$config['Title']], 'strlen');
53		if (count($filter)) {
54		$criteria = Criteria::where($config['Field'])->in($filter);
55		$this->clientQuery
56		->createFilterQuery('facet-' . $config['Title'])
57		->setQuery($criteria->getQuery());
58		}
59		}
60		}
61	4	}
62		}
63

Firesphere / silverstripe-solr-search

Push — sheepy/introspection ( 000d40...b6b869 )

QueryComponentFacetTrait::buildFacetQuery() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like