BaseQueryTest::testGetSet() - Code Metrics - Inspection of "Test the right task" - Firesphere/silverstripe-solr-search - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — hans/logtests ( 76c086...71695d )

by Simon

created 2019-08-24 21:53 UTC

BaseQueryTest::testGetSet() A

↳ Parent: Project

Complexity

Conditions	1
Paths	1

Size

Total Lines	54
Code Lines	52

Duplication

Lines	0
Ratio	0 %

Importance

Changes	4
Bugs	0	Features	0

Metric	Value
eloc	52
c	4
b	0
f	0
dl	0
loc	54
rs	9.0472
cc	1
nc	1
nop	0

How to fix Long Method

<?php


namespace Firesphere\SolrSearch\Tests;

use Firesphere\SolrSearch\Extensions\DataObjectExtension;
use Firesphere\SolrSearch\Queries\BaseQuery;
use Page;
use SilverStripe\Core\Config\Config;
use SilverStripe\Core\Injector\Injector;
use SilverStripe\Dev\SapphireTest;

class BaseQueryTest extends SapphireTest
{
    protected static $fixture_file = '../fixtures/DataResolver.yml';
    protected static $extra_dataobjects = [
        TestObject::class,
        TestPage::class,
        TestRelationObject::class,
    ];

    /**
     * @var BaseQuery
     */
    protected $query;

    public function testGetSet()
    {
        $this->assertEquals(0, $this->query->getStart());
        $this->query->setStart(1);
        $this->assertEquals(1, $this->query->getStart());
        $this->assertEquals(10, $this->query->getRows());
        $this->query->setRows(20);
        $this->assertEquals(20, $this->query->getRows());
        $this->assertEmpty($this->query->getClasses());
        $this->query->addClass('test');
        $this->assertCount(1, $this->query->getClasses());
        $this->query->setClasses([]);
        $this->assertCount(0, $this->query->getClasses());
        $this->assertEmpty($this->query->getExclude());
        $this->query->setExclude(['test']);
        $this->assertEquals(['test'], $this->query->getExclude());
        $this->query->addExclude('test', 'test');
        $this->assertEquals(['test', 'test' => 'test'], $this->query->getExclude());
        $this->query->addField('test');
        $this->assertEquals(['test'], $this->query->getFields());
        $this->assertEquals(0, $this->query->getFacetsMinCount());
        $this->query->setFacetsMinCount(15);
        $this->assertEquals(15, $this->query->getFacetsMinCount());
        $this->query->setFields(['Field1', 'Field2']);
        $this->assertCount(2, $this->query->getFields());
        $this->query->setSort(['Field1']);
        $this->assertCount(1, $this->query->getSort());
        $this->query->setTerms(['Term' => 'Test']);
        $this->assertCount(1, $this->query->getTerms());
        $this->query->addTerm('String', ['Field1'], 2);
        $this->assertCount(2, $this->query->getTerms());
        $this->query->addFilter('Field1', 'test');
        $this->assertCount(1, $this->query->getFilter());
        $this->query->setFields([['Field1' => 'testing']]);
        $this->assertCount(1, $this->query->getFilter());
        $this->query->setFilter([['Field1' => 'Test']]);
        $this->assertCount(1, $this->query->getFilter());
        $this->query->setSpellcheck(false);
        $this->assertFalse($this->query->hasSpellcheck());
        $this->query->addBoostedField('Field1', 2);
        $this->assertEquals(2, $this->query->getBoostedFields()['Field1']);
        $this->query->setBoostedFields(['Field' => 2]);
        $this->assertEquals(2, $this->query->getBoostedFields()['Field']);
        $this->query->setHighlight(['test']);
        $this->assertEquals(['test'], $this->query->getHighlight());
        $this->query->addHighlight('test');
        $this->assertEquals(['test', 'test'], $this->query->getHighlight());
        $this->assertFalse($this->query->shouldFollowSpellcheck());
        $this->query->setFollowSpellcheck(true);
        $this->assertTrue($this->query->shouldFollowSpellcheck());
        $this->query->addFacetFilter('Test', 'test');
        $this->assertEquals(['Test' => ['test']], $this->query->getFacetFilter());
        $this->query->setFacetFilter(['Testing' => [1, 2]]);
        $this->assertEquals(['Testing' => [1, 2]], $this->query->getFacetFilter());
    }

    protected function setUp()
    {
        $this->query = Injector::inst()->get(BaseQuery::class);
        parent::setUp();
        Injector::inst()->get(Page::class)->requireDefaultRecords();
        foreach (self::$extra_dataobjects as $className) {
            Config::modify()->merge($className, 'extensions', [DataObjectExtension::class]);
        }
    }
}


1			<?php
2
3
4			namespace Firesphere\SolrSearch\Tests;
5
6			use Firesphere\SolrSearch\Extensions\DataObjectExtension;
7			use Firesphere\SolrSearch\Queries\BaseQuery;
8			use Page;
9			use SilverStripe\Core\Config\Config;
10			use SilverStripe\Core\Injector\Injector;
11			use SilverStripe\Dev\SapphireTest;
12
13			class BaseQueryTest extends SapphireTest
14			{
15			protected static $fixture_file = '../fixtures/DataResolver.yml';
16			protected static $extra_dataobjects = [
17			TestObject::class,
18			TestPage::class,
19			TestRelationObject::class,
20			];
21
22			/**
23			* @var BaseQuery
24			*/
25			protected $query;
26
27			public function testGetSet()
28			{
29			$this->assertEquals(0, $this->query->getStart());
30			$this->query->setStart(1);
31			$this->assertEquals(1, $this->query->getStart());
32			$this->assertEquals(10, $this->query->getRows());
33			$this->query->setRows(20);
34			$this->assertEquals(20, $this->query->getRows());
35			$this->assertEmpty($this->query->getClasses());
36			$this->query->addClass('test');
37			$this->assertCount(1, $this->query->getClasses());
38			$this->query->setClasses([]);
39			$this->assertCount(0, $this->query->getClasses());
40			$this->assertEmpty($this->query->getExclude());
41			$this->query->setExclude(['test']);
42			$this->assertEquals(['test'], $this->query->getExclude());
43			$this->query->addExclude('test', 'test');
44			$this->assertEquals(['test', 'test' => 'test'], $this->query->getExclude());
45			$this->query->addField('test');
46			$this->assertEquals(['test'], $this->query->getFields());
47			$this->assertEquals(0, $this->query->getFacetsMinCount());
48			$this->query->setFacetsMinCount(15);
49			$this->assertEquals(15, $this->query->getFacetsMinCount());
50			$this->query->setFields(['Field1', 'Field2']);
51			$this->assertCount(2, $this->query->getFields());
52			$this->query->setSort(['Field1']);
53			$this->assertCount(1, $this->query->getSort());
54			$this->query->setTerms(['Term' => 'Test']);
55			$this->assertCount(1, $this->query->getTerms());
56			$this->query->addTerm('String', ['Field1'], 2);
57			$this->assertCount(2, $this->query->getTerms());
58			$this->query->addFilter('Field1', 'test');
59			$this->assertCount(1, $this->query->getFilter());
60			$this->query->setFields([['Field1' => 'testing']]);
61			$this->assertCount(1, $this->query->getFilter());
62			$this->query->setFilter([['Field1' => 'Test']]);
63			$this->assertCount(1, $this->query->getFilter());
64			$this->query->setSpellcheck(false);
65			$this->assertFalse($this->query->hasSpellcheck());
66			$this->query->addBoostedField('Field1', 2);
67			$this->assertEquals(2, $this->query->getBoostedFields()['Field1']);
68			$this->query->setBoostedFields(['Field' => 2]);
69			$this->assertEquals(2, $this->query->getBoostedFields()['Field']);
70			$this->query->setHighlight(['test']);
71			$this->assertEquals(['test'], $this->query->getHighlight());
72			$this->query->addHighlight('test');
73			$this->assertEquals(['test', 'test'], $this->query->getHighlight());
74			$this->assertFalse($this->query->shouldFollowSpellcheck());
75			$this->query->setFollowSpellcheck(true);
76			$this->assertTrue($this->query->shouldFollowSpellcheck());
77			$this->query->addFacetFilter('Test', 'test');
78			$this->assertEquals(['Test' => ['test']], $this->query->getFacetFilter());
79			$this->query->setFacetFilter(['Testing' => [1, 2]]);
80			$this->assertEquals(['Testing' => [1, 2]], $this->query->getFacetFilter());
81			}
82
83			protected function setUp()
84			{
85			$this->query = Injector::inst()->get(BaseQuery::class);
86			parent::setUp();
87			Injector::inst()->get(Page::class)->requireDefaultRecords();
88			foreach (self::$extra_dataobjects as $className) {
89			Config::modify()->merge($className, 'extensions', [DataObjectExtension::class]);
90			}
91			}
92			}
93

Firesphere / silverstripe-solr-search

Push — hans/logtests ( 76c086...71695d )

BaseQueryTest::testGetSet() A

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like