PartialFormSubmissionTest::testCanView() - Code Metrics - Inspection of "Up the coverage a bit(?)" - Firesphere/silverstripe-partial-userforms - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 8ce830...28470d )

by Simon

created 2018-06-08 01:07 UTC

PartialFormSubmissionTest::testCanView() A

↳ Parent: PartialFormSubmissionTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	9
Code Lines	5

Duplication

Lines	9
Ratio	100 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	9
loc	9
rs	9.6666
cc	1
eloc	5
nc	1
nop	0

<?php

namespace Firesphere\PartialUserforms\Tests;

use Firesphere\PartialUserforms\Models\PartialFormSubmission;
use SilverStripe\Core\Injector\Injector;
use SilverStripe\Dev\SapphireTest;
use SilverStripe\Forms\GridField\GridField;
use SilverStripe\UserForms\Model\UserDefinedForm;

class PartialFormSubmissionTest extends SapphireTest
{
    /**
     * @var PartialFormSubmission
     */
    protected $submission;

    public function testGetCMSFields()
    {
        $fields = $this->submission->getCMSFields();

        $this->assertNull($fields->dataFieldByName('Values'));
        $this->assertNull($fields->dataFieldByName('IsSend'));
        $this->assertInstanceOf(GridField::class, $fields->dataFieldByName('PartialFields'));
    }

    public function testCanCreate()

    {
        $this->assertTrue($this->submission->canCreate());

        $this->submission->ParentID = $this->submission->UserDefinedFormID;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $this->submission->UserDefinedFormID = 0;

        $this->assertTrue($this->submission->canCreate());
    }

    public function testCanView()

    {
        $this->assertTrue($this->submission->canView());

        $this->submission->ParentID = $this->submission->UserDefinedFormID;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $this->submission->UserDefinedFormID = 0;

        $this->assertTrue($this->submission->canView());
    }

    public function testCanEdit()

    {
        $this->assertTrue($this->submission->canEdit());

        $this->submission->ParentID = $this->submission->UserDefinedFormID;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $this->submission->UserDefinedFormID = 0;

        $this->assertTrue($this->submission->canEdit());
    }

    public function testCanDelete()

    {
        $this->assertTrue($this->submission->canDelete());

        $this->submission->ParentID = $this->submission->UserDefinedFormID;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $this->submission->UserDefinedFormID = 0;

        $this->assertTrue($this->submission->canDelete());
    }

    public function testGetParent()
    {
        $parent = $this->submission->getParent();

        $this->assertInstanceOf(UserDefinedForm::class, $parent);
    }

    protected function setUp()
    {
        $this->submission = Injector::inst()->get(PartialFormSubmission::class);
        $form = UserDefinedForm::create(['Title' => 'Test']);
        $formID = $form->write();
        $this->submission->UserDefinedFormID = $formID;
        $this->submission->UserDefinedFormClass = UserDefinedForm::class;
        $this->submission->write();
        $this->usesDatabase = true;

        return parent::setUp();
    }
}


1		<?php
2
3		namespace Firesphere\PartialUserforms\Tests;
4
5		use Firesphere\PartialUserforms\Models\PartialFormSubmission;
6		use SilverStripe\Core\Injector\Injector;
7		use SilverStripe\Dev\SapphireTest;
8		use SilverStripe\Forms\GridField\GridField;
9		use SilverStripe\UserForms\Model\UserDefinedForm;
10
11		class PartialFormSubmissionTest extends SapphireTest
12		{
13		/**
14		* @var PartialFormSubmission
15		*/
16		protected $submission;
17
18		public function testGetCMSFields()
19		{
20		$fields = $this->submission->getCMSFields();
21
22		$this->assertNull($fields->dataFieldByName('Values'));
23		$this->assertNull($fields->dataFieldByName('IsSend'));
24		$this->assertInstanceOf(GridField::class, $fields->dataFieldByName('PartialFields'));
25		}
26
27	View Code Duplication	public function testCanCreate()
		0 ignored issues – show Duplication introduced 2018-06-08 01:09 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
28		{
29		$this->assertTrue($this->submission->canCreate());
30
31		$this->submission->ParentID = $this->submission->UserDefinedFormID;
		0 ignored issues – show Documentation introduced 2018-06-08 01:09 UTC by Report Bug Copy Issue Report The property `ParentID` does not exist on `object<Firesphere\Partia...\PartialFormSubmission>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
32		$this->submission->UserDefinedFormID = 0;
33
34		$this->assertTrue($this->submission->canCreate());
35		}
36
37	View Code Duplication	public function testCanView()
		0 ignored issues – show Duplication introduced 2018-06-08 01:09 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
38		{
39		$this->assertTrue($this->submission->canView());
40
41		$this->submission->ParentID = $this->submission->UserDefinedFormID;
		0 ignored issues – show Documentation introduced 2018-06-08 01:09 UTC by Report Bug Copy Issue Report The property `ParentID` does not exist on `object<Firesphere\Partia...\PartialFormSubmission>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
42		$this->submission->UserDefinedFormID = 0;
43
44		$this->assertTrue($this->submission->canView());
45		}
46
47	View Code Duplication	public function testCanEdit()
		0 ignored issues – show Duplication introduced 2018-06-08 01:09 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
48		{
49		$this->assertTrue($this->submission->canEdit());
50
51		$this->submission->ParentID = $this->submission->UserDefinedFormID;
		0 ignored issues – show Documentation introduced 2018-06-08 01:09 UTC by Report Bug Copy Issue Report The property `ParentID` does not exist on `object<Firesphere\Partia...\PartialFormSubmission>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
52		$this->submission->UserDefinedFormID = 0;
53
54		$this->assertTrue($this->submission->canEdit());
55		}
56
57	View Code Duplication	public function testCanDelete()
		0 ignored issues – show Duplication introduced 2018-06-08 00:25 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
58		{
59		$this->assertTrue($this->submission->canDelete());
60
61		$this->submission->ParentID = $this->submission->UserDefinedFormID;
		0 ignored issues – show Documentation introduced 2018-06-08 01:09 UTC by Report Bug Copy Issue Report The property `ParentID` does not exist on `object<Firesphere\Partia...\PartialFormSubmission>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
62		$this->submission->UserDefinedFormID = 0;
63
64		$this->assertTrue($this->submission->canDelete());
65		}
66
67		public function testGetParent()
68		{
69		$parent = $this->submission->getParent();
70
71		$this->assertInstanceOf(UserDefinedForm::class, $parent);
72		}
73
74		protected function setUp()
75		{
76		$this->submission = Injector::inst()->get(PartialFormSubmission::class);
77		$form = UserDefinedForm::create(['Title' => 'Test']);
78		$formID = $form->write();
79		$this->submission->UserDefinedFormID = $formID;
80		$this->submission->UserDefinedFormClass = UserDefinedForm::class;
81		$this->submission->write();
82		$this->usesDatabase = true;
83
84		return parent::setUp();
85		}
86		}
87

Firesphere / silverstripe-partial-userforms

Push — master ( 8ce830...28470d )

PartialFormSubmissionTest::testCanView() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like