PartialFileFieldSubmission::canView() - Code Metrics - Inspection of "Solves #15 Safe files to partial submissions" - Firesphere/silverstripe-partial-userforms - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#16)

by Simon

created 2019-08-23 05:10 UTC

PartialFileFieldSubmission::canView() A

↳ Parent: PartialFileFieldSubmission

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	4
rs	10
c	0
b	0
f	0
cc	1
nc	1
nop	1

<?php

namespace Firesphere\PartialUserforms\Models;

use SilverStripe\Security\Member;
use SilverStripe\UserForms\Model\Submission\SubmittedFileField;

/**
 * Class \Firesphere\PartialUserforms\Models\PartialFileFieldSubmission
 *
 * @property int $SubmittedFormID
 * @method PartialFormSubmission SubmittedForm()
 */
class PartialFileFieldSubmission extends SubmittedFileField
{
    private static $table_name = 'PartialFileFieldSubmission';


    private static $has_one = [

        'SubmittedForm' => PartialFormSubmission::class,
    ];


    /**
     * @param Member $member
     * @param array $context
     * @return boolean|string
     */
    public function canCreate($member = null, $context = [])
    {
        return $this->SubmittedForm()->canCreate();
    }

    /**
     * @param Member $member
     *
     * @return bool
     */
    public function canView($member = null)
    {
        return $this->SubmittedForm()->canView();

    }

    /**
     * @param Member $member
     *
     * @return bool
     */
    public function canEdit($member = null)
    {
        return $this->SubmittedForm()->canEdit();

    }

    /**
     * @param Member $member
     *
     * @return bool
     */
    public function canDelete($member = null)
    {
        return $this->SubmittedForm()->canDelete();

    }
}


1			<?php
2
3			namespace Firesphere\PartialUserforms\Models;
4
5			use SilverStripe\Security\Member;
6			use SilverStripe\UserForms\Model\Submission\SubmittedFileField;
7
8			/**
9			* Class \Firesphere\PartialUserforms\Models\PartialFileFieldSubmission
10			*
11			* @property int $SubmittedFormID
12			* @method PartialFormSubmission SubmittedForm()
13			*/
14			class PartialFileFieldSubmission extends SubmittedFileField
15			{
16			private static $table_name = 'PartialFileFieldSubmission';
			0 ignored issues – show Comprehensibility introduced 2018-05-08 23:26 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history...
17
18			private static $has_one = [
			0 ignored issues – show Comprehensibility introduced 2018-05-08 23:26 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history...
19			'SubmittedForm' => PartialFormSubmission::class,
20			];
21
22
23			/**
24			* @param Member $member
25			* @param array $context
26			* @return boolean\|string
27			*/
28			public function canCreate($member = null, $context = [])
29			{
30			return $this->SubmittedForm()->canCreate();
31			}
32
33			/**
34			* @param Member $member
35			*
36			* @return bool
37			*/
38			public function canView($member = null)
39			{
40			return $this->SubmittedForm()->canView();
			0 ignored issues – show Bug Compatibility introduced 2019-08-22 04:04 UTC by Report Bug Copy Issue Report The expression `$this->SubmittedForm()->canView();` of type `boolean\|string` adds the type `string` to the return on line 40 which is incompatible with the return type of the parent method `SilverStripe\UserForms\M...ittedFormField::canView` of type `boolean`. Loading history...
41			}
42
43			/**
44			* @param Member $member
45			*
46			* @return bool
47			*/
48			public function canEdit($member = null)
49			{
50			return $this->SubmittedForm()->canEdit();
			0 ignored issues – show Bug Compatibility introduced 2019-08-22 04:04 UTC by Report Bug Copy Issue Report The expression `$this->SubmittedForm()->canEdit();` of type `boolean\|string` adds the type `string` to the return on line 50 which is incompatible with the return type of the parent method `SilverStripe\UserForms\M...ittedFormField::canEdit` of type `boolean`. Loading history...
51			}
52
53			/**
54			* @param Member $member
55			*
56			* @return bool
57			*/
58			public function canDelete($member = null)
59			{
60			return $this->SubmittedForm()->canDelete();
			0 ignored issues – show Bug Compatibility introduced 2019-08-22 04:04 UTC by Report Bug Copy Issue Report The expression `$this->SubmittedForm()->canDelete();` of type `boolean\|string` adds the type `string` to the return on line 60 which is incompatible with the return type of the parent method `SilverStripe\UserForms\M...tedFormField::canDelete` of type `boolean`. Loading history...
61			}
62			}
63

Firesphere / silverstripe-partial-userforms

Pull Request — master (#16)

PartialFileFieldSubmission::canView() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like