Firesphere\PartialUserforms\Controllers\PartialUserFormVerifyController

Complexity

Total Complexity

7

Size/Duplication

Total Lines	89
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	7

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	init()	0	17	2
A	getForm()	0	4	1
A	doValidate()	0	16	2
A	getPartialFormSubmission()	0	4	1
A	setPartialFormSubmission()	0	4	1

<?php


namespace Firesphere\PartialUserforms\Controllers;


use Firesphere\PartialUserforms\Forms\PasswordForm;
use Firesphere\PartialUserforms\Models\PartialFormSubmission;
use Page;
use PageController;
use SilverStripe\Control\HTTPResponse;
use SilverStripe\Control\HTTPResponse_Exception;
use SilverStripe\UserForms\Model\UserDefinedForm;

/**
 * Class \Firesphere\PartialUserforms\Controllers\PartialUserFormVerifyController
 *
 */
class PartialUserFormVerifyController extends PageController
{

    /**
     * @var array
     */
    private static $allowed_actions = [

Consider using a different property name as you override a private property of the parent class.

        'getForm'
    ];
    /**
     * @var PartialFormSubmission
     */
    protected $partialFormSubmission;

    /**
     * @var PasswordForm
     */
    protected $form;

    /**
     * @return PartialUserFormVerifyController|void
     * @throws HTTPResponse_Exception
     */
    public function init()
    {
        parent::init();
        $session = $this->getRequest()->getSession();
        // Set the session if the last session has expired
        if (!$session->get(PartialSubmissionController::SESSION_KEY)) {
            return $this->httpError(404);
        }

        /** @var PartialFormSubmission $partial */
        $partial = PartialFormSubmission::get()->byID($session->get(PartialSubmissionController::SESSION_KEY));

        $this->setPartialFormSubmission($partial);
        // Set data record and load the form
        /** @var UserDefinedForm dataRecord */
        $this->dataRecord = Page::create();
    }

    /**
     * @return PasswordForm
     */
    public function getForm()
    {
        return PasswordForm::create($this, __FUNCTION__);
    }


    /**
     * @param array $data
     * @param self $form
     * @return HTTPResponse
     */
    public function doValidate($data, $form)

The parameter $form is not used and could be removed.

    {
        /** @var PartialFormSubmission $partial */
        $partial = $this->getPartialFormSubmission();

        $password = hash_pbkdf2('SHA256', $data['Password'], $partial->TokenSalt, 1000);
        if (hash_equals($password, $partial->Password)) {
            $request = $this->getRequest();
            $request->getSession()->set(PasswordForm::PASSWORD_SESSION_KEY, true);
        }

        $token = $partial->Token;
        $key = $partial->generateKey($token);

It seems like $token defined by $partial->Token on line 85 can also be of type boolean; however, Firesphere\PartialUserforms\Models\PartialFormSubmission::generateKey() does only seem to accept string, maybe add an additional type check?

        return $this->redirect(sprintf('/%s/%s/%s', 'partial', $key, $token));
    }

    /**
     * @return mixed
     */
    public function getPartialFormSubmission()
    {
        return $this->partialFormSubmission;
    }

    /**
     * @param mixed $partialFormSubmission
     */
    public function setPartialFormSubmission($partialFormSubmission): void
    {
        $this->partialFormSubmission = $partialFormSubmission;
    }

}