PartialUserFormVerifyController::getForm() - Code Metrics - Inspection of "Add password protection selection to the form" - Firesphere/silverstripe-partial-userforms - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#12)

by Simon

created 2019-08-29 04:24 UTC

PartialUserFormVerifyController::getForm() A

↳ Parent: PartialUserFormVerifyController

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	4
rs	10
c	0
b	0
f	0
cc	1
nc	1
nop	0

<?php


namespace Firesphere\PartialUserforms\Controllers;

use Firesphere\PartialUserforms\Forms\PasswordForm;
use Firesphere\PartialUserforms\Models\PartialFormSubmission;
use Page;
use PageController;
use SilverStripe\Control\HTTPResponse;
use SilverStripe\Control\HTTPResponse_Exception;
use SilverStripe\UserForms\Model\UserDefinedForm;

/**
 * Class \Firesphere\PartialUserforms\Controllers\PartialUserFormVerifyController
 *
 */
class PartialUserFormVerifyController extends PageController
{
    public const PASSWORD_KEY = 'FormPassword';

    /**
     * @var array
     */
    private static $allowed_actions = [

        'getForm'
    ];
    /**
     * @var PartialFormSubmission
     */
    protected $partialFormSubmission;

    /**
     * @var PasswordForm
     */
    protected $form;

    /**
     * @return PartialUserFormVerifyController|void
     * @throws HTTPResponse_Exception
     */
    public function init()
    {
        parent::init();
        $session = $this->getRequest()->getSession();
        $sessionKey = PartialSubmissionController::SESSION_KEY;
        // Set the session if the last session has expired
        if (!$session->get($sessionKey)) {
            return $this->httpError(404);
        }

        /** @var PartialFormSubmission $partial */
        $partial = PartialFormSubmission::get()->byID($session->get($sessionKey));

        $this->setPartialFormSubmission($partial);
        // Set data record and load the form
        /** @var UserDefinedForm dataRecord */
        $this->dataRecord = Page::create();
    }

    /**
     * @return PasswordForm
     */
    public function getForm()
    {
        return PasswordForm::create($this, __FUNCTION__);
    }


    /**
     * @param array $data
     * @param PasswordForm $form
     * @return HTTPResponse
     * @throws \Exception
     */
    public function doValidate($data, $form)
    {
        /** @var PartialFormSubmission $partial */
        $partial = $this->getPartialFormSubmission();

        $password = hash_pbkdf2('SHA256', $data['Password'], $partial->TokenSalt, 1000);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        if (false) {//!hash_equals($password, $partial->Password)) {
            $form->sessionError(
                _t(
                    PasswordForm::class . '.PASSWORDERROR',
                    'Password incorrect, please check your password and try again'
                )
            );

            return $this->redirectBack();
        }

        $request = $this->getRequest();
        $request->getSession()->set(PasswordForm::PASSWORD_SESSION_KEY, $partial->ID);
        $request->getSession()->set(self::PASSWORD_KEY, $data['Password']);

        return $this->redirect($partial->getPartialLink());
    }

    /**
     * @return PartialFormSubmission
     */
    public function getPartialFormSubmission()
    {
        return $this->partialFormSubmission;
    }

    /**
     * @param PartialFormSubmission $partialFormSubmission
     */
    public function setPartialFormSubmission($partialFormSubmission): void
    {
        $this->partialFormSubmission = $partialFormSubmission;
    }
}


1			<?php
2
3
4			namespace Firesphere\PartialUserforms\Controllers;
5
6			use Firesphere\PartialUserforms\Forms\PasswordForm;
7			use Firesphere\PartialUserforms\Models\PartialFormSubmission;
8			use Page;
9			use PageController;
10			use SilverStripe\Control\HTTPResponse;
11			use SilverStripe\Control\HTTPResponse_Exception;
12			use SilverStripe\UserForms\Model\UserDefinedForm;
13
14			/**
15			* Class \Firesphere\PartialUserforms\Controllers\PartialUserFormVerifyController
16			*
17			*/
18			class PartialUserFormVerifyController extends PageController
19			{
20			public const PASSWORD_KEY = 'FormPassword';
21
22			/**
23			* @var array
24			*/
25			private static $allowed_actions = [
			1 ignored issue – show Comprehensibility introduced 2019-08-23 03:55 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history...
26			'getForm'
27			];
28			/**
29			* @var PartialFormSubmission
30			*/
31			protected $partialFormSubmission;
32
33			/**
34			* @var PasswordForm
35			*/
36			protected $form;
37
38			/**
39			* @return PartialUserFormVerifyController\|void
40			* @throws HTTPResponse_Exception
41			*/
42			public function init()
43			{
44			parent::init();
45			$session = $this->getRequest()->getSession();
46			$sessionKey = PartialSubmissionController::SESSION_KEY;
47			// Set the session if the last session has expired
48			if (!$session->get($sessionKey)) {
49			return $this->httpError(404);
50			}
51
52			/** @var PartialFormSubmission $partial */
53			$partial = PartialFormSubmission::get()->byID($session->get($sessionKey));
54
55			$this->setPartialFormSubmission($partial);
56			// Set data record and load the form
57			/** @var UserDefinedForm dataRecord */
58			$this->dataRecord = Page::create();
59			}
60
61			/**
62			* @return PasswordForm
63			*/
64			public function getForm()
65			{
66			return PasswordForm::create($this, __FUNCTION__);
67			}
68
69
70			/**
71			* @param array $data
72			* @param PasswordForm $form
73			* @return HTTPResponse
74			* @throws \Exception
75			*/
76			public function doValidate($data, $form)
77			{
78			/** @var PartialFormSubmission $partial */
79			$partial = $this->getPartialFormSubmission();
80
81			$password = hash_pbkdf2('SHA256', $data['Password'], $partial->TokenSalt, 1000);
			0 ignored issues – show Unused Code introduced 2019-08-29 04:25 UTC by Report Bug Copy Issue Report `$password` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
82			if (false) {//!hash_equals($password, $partial->Password)) {
83			$form->sessionError(
84			_t(
85			PasswordForm::class . '.PASSWORDERROR',
86			'Password incorrect, please check your password and try again'
87			)
88			);
89
90			return $this->redirectBack();
91			}
92
93			$request = $this->getRequest();
94			$request->getSession()->set(PasswordForm::PASSWORD_SESSION_KEY, $partial->ID);
95			$request->getSession()->set(self::PASSWORD_KEY, $data['Password']);
96
97			return $this->redirect($partial->getPartialLink());
98			}
99
100			/**
101			* @return PartialFormSubmission
102			*/
103			public function getPartialFormSubmission()
104			{
105			return $this->partialFormSubmission;
106			}
107
108			/**
109			* @param PartialFormSubmission $partialFormSubmission
110			*/
111			public function setPartialFormSubmission($partialFormSubmission): void
112			{
113			$this->partialFormSubmission = $partialFormSubmission;
114			}
115			}
116

Firesphere / silverstripe-partial-userforms

Pull Request — master (#12)

PartialUserFormVerifyController::getForm() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like