PartialUserFormVerifyControllerTest - Code Metrics - Inspection of "Add password protection selection to the form" - Firesphere/silverstripe-partial-userforms - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#12)

by Simon

created 2019-08-29 04:24 UTC

PartialUserFormVerifyControllerTest A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	70
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	8

Importance

Changes

Metric	Value
wmc	3
lcom	1
cbo	8
dl	0
loc	70
rs	10
c	0
b	0
f	0

3 Methods

Rating	Name	Size	Complexity
A	testInit()	10	1
A	testInitSuccess()	12	1
A	testDoValidate()	38	1

<?php

namespace Firesphere\PartialUserforms\Tests;

use Firesphere\PartialUserforms\Controllers\PartialSubmissionController;
use Firesphere\PartialUserforms\Controllers\PartialUserFormVerifyController;
use Firesphere\PartialUserforms\Forms\PasswordForm;
use Firesphere\PartialUserforms\Models\PartialFormSubmission;
use SilverStripe\Control\NullHTTPRequest;
use SilverStripe\Control\Session;
use SilverStripe\Dev\FunctionalTest;
use SilverStripe\Dev\SapphireTest;

class PartialUserFormVerifyControllerTest extends FunctionalTest
{
    protected static $fixture_file = '../fixtures/partialformtest.yml';

    /**
     * @expectedException  \SilverStripe\Control\HTTPResponse_Exception
     */
    public function testInit()
    {
        $request = new NullHTTPRequest();
        $session = new Session(['hi' => 'bye']);
        $request->setSession($session);
        $controller = PartialUserFormVerifyController::create();
        $controller->setRequest($request);

        $controller->init();
    }

    public function testInitSuccess()
    {
        $partialForm = $this->objFromFixture(PartialFormSubmission::class, 'submission1');
        $request = new NullHTTPRequest();
        $session = new Session(['hi' => 'bye', PartialSubmissionController::SESSION_KEY => $partialForm->ID]);
        $request->setSession($session);
        $controller = PartialUserFormVerifyController::create();
        $controller->setRequest($request);

        $controller->init();
        $this->assertEquals(200, $controller->getResponse()->getStatusCode());
    }

    public function testDoValidate()
    {
        $request = new NullHTTPRequest();
        /** @var PartialFormSubmission $partialForm */
        $partialForm = $this->objFromFixture(PartialFormSubmission::class, 'submission1');
        $parent = $partialForm->getParent();
        $parent->PasswordProtected = true;
        $parent->write();
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
        $parent->publishRecursive();
        $partialForm->ParentID = $parent->ID;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $partialForm->write();
        $session = new Session(['hi' => 'bye', PartialSubmissionController::SESSION_KEY => $partialForm->ID]);
        $request->setSession($session);
        $controller = PartialUserFormVerifyController::create();
        $controller->setRequest($request);

        $this->assertNotNull($partialForm->Password);

        $testPwd = hash_pbkdf2('SHA256', '1234567890', $partialForm->TokenSalt, 1000);

        $partialForm->Password = $testPwd;
        $partialForm->write();

        $controller->init();
        $form = new PasswordForm($controller, __FUNCTION__);
        $result = $controller->doValidate(['Password' => '1234567890'], $form);

        $this->assertEquals($partialForm->ID, $session->get('PartialFormSession'));
        $this->assertContains('/partial/', $result->getHeader('Location'));

        $controller = new PartialUserFormVerifyController();
        $controller->setRequest($request);
        $controller->init();
        $result = $controller->doValidate(['Password' => '0987654321'], $form);

        // It uses redirect back, so it's unclear what the 'back' is at this stage
        $this->assertNotContains('/partial', $result->getHeader('Location'));
    }
}


1			<?php
2
3			namespace Firesphere\PartialUserforms\Tests;
4
5			use Firesphere\PartialUserforms\Controllers\PartialSubmissionController;
6			use Firesphere\PartialUserforms\Controllers\PartialUserFormVerifyController;
7			use Firesphere\PartialUserforms\Forms\PasswordForm;
8			use Firesphere\PartialUserforms\Models\PartialFormSubmission;
9			use SilverStripe\Control\NullHTTPRequest;
10			use SilverStripe\Control\Session;
11			use SilverStripe\Dev\FunctionalTest;
12			use SilverStripe\Dev\SapphireTest;
13
14			class PartialUserFormVerifyControllerTest extends FunctionalTest
15			{
16			protected static $fixture_file = '../fixtures/partialformtest.yml';
17
18			/**
19			* @expectedException \SilverStripe\Control\HTTPResponse_Exception
20			*/
21			public function testInit()
22			{
23			$request = new NullHTTPRequest();
24			$session = new Session(['hi' => 'bye']);
25			$request->setSession($session);
26			$controller = PartialUserFormVerifyController::create();
27			$controller->setRequest($request);
28
29			$controller->init();
30			}
31
32			public function testInitSuccess()
33			{
34			$partialForm = $this->objFromFixture(PartialFormSubmission::class, 'submission1');
35			$request = new NullHTTPRequest();
36			$session = new Session(['hi' => 'bye', PartialSubmissionController::SESSION_KEY => $partialForm->ID]);
37			$request->setSession($session);
38			$controller = PartialUserFormVerifyController::create();
39			$controller->setRequest($request);
40
41			$controller->init();
42			$this->assertEquals(200, $controller->getResponse()->getStatusCode());
43			}
44
45			public function testDoValidate()
46			{
47			$request = new NullHTTPRequest();
48			/** @var PartialFormSubmission $partialForm */
49			$partialForm = $this->objFromFixture(PartialFormSubmission::class, 'submission1');
50			$parent = $partialForm->getParent();
51			$parent->PasswordProtected = true;
52			$parent->write();
			0 ignored issues – show Bug introduced 2019-08-28 04:06 UTC by Report Bug Copy Issue Report The method `write` does only exist in `SilverStripe\ORM\DataObject`, but not in `SilverStripe\UserForms\Model\UserDefinedForm`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
53			$parent->publishRecursive();
54			$partialForm->ParentID = $parent->ID;
			0 ignored issues – show Documentation introduced 2019-08-28 04:06 UTC by Report Bug Copy Issue Report The property `ParentID` does not exist on `object<Firesphere\Partia...\PartialFormSubmission>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
55			$partialForm->write();
56			$session = new Session(['hi' => 'bye', PartialSubmissionController::SESSION_KEY => $partialForm->ID]);
57			$request->setSession($session);
58			$controller = PartialUserFormVerifyController::create();
59			$controller->setRequest($request);
60
61			$this->assertNotNull($partialForm->Password);
62
63			$testPwd = hash_pbkdf2('SHA256', '1234567890', $partialForm->TokenSalt, 1000);
64
65			$partialForm->Password = $testPwd;
66			$partialForm->write();
67
68			$controller->init();
69			$form = new PasswordForm($controller, __FUNCTION__);
70			$result = $controller->doValidate(['Password' => '1234567890'], $form);
71
72			$this->assertEquals($partialForm->ID, $session->get('PartialFormSession'));
73			$this->assertContains('/partial/', $result->getHeader('Location'));
74
75			$controller = new PartialUserFormVerifyController();
76			$controller->setRequest($request);
77			$controller->init();
78			$result = $controller->doValidate(['Password' => '0987654321'], $form);
79
80			// It uses redirect back, so it's unclear what the 'back' is at this stage
81			$this->assertNotContains('/partial', $result->getHeader('Location'));
82			}
83			}
84

Firesphere / silverstripe-partial-userforms

Pull Request — master (#12)

PartialUserFormVerifyControllerTest A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

3 Methods

Available Fixes

Duplication Side-by-Side

Filter issues like