Firesphere\PartialUserforms\Models\PartialFormSubmission

Complexity

Total Complexity

20

Size/Duplication

Total Lines	232
Duplicated Lines	0 %

Coupling/Cohesion

Components	2
Dependencies	15

Test Coverage

Coverage

97.18%

Importance

Changes

0

12 Methods

Rating	Name	Duplication	Size	Complexity
A	getCMSFields()	0	49	1
A	getParent()	0	4	1
A	canCreate()	0	4	1
A	canView()	0	8	2
A	canEdit()	0	8	2
A	canDelete()	0	8	2
A	getPartialLink()	0	13	2
A	onBeforeWrite()	0	9	2
A	generateToken()	0	6	1
A	generateKey()	0	4	1
A	getFields()	0	7	1
A	validateKeyToken()	0	13	4

<?php

namespace Firesphere\PartialUserforms\Models;

use Exception;
use SilverStripe\Control\Controller;
use SilverStripe\Control\Director;
use SilverStripe\Forms\FieldList;
use SilverStripe\Forms\GridField\GridField;
use SilverStripe\Forms\GridField\GridFieldButtonRow;
use SilverStripe\Forms\GridField\GridFieldConfig;
use SilverStripe\Forms\GridField\GridFieldDataColumns;
use SilverStripe\Forms\GridField\GridFieldExportButton;
use SilverStripe\Forms\GridField\GridFieldPrintButton;
use SilverStripe\Forms\ReadonlyField;
use SilverStripe\ORM\ArrayList;
use SilverStripe\ORM\DataList;
use SilverStripe\ORM\DataObject;
use SilverStripe\Security\Member;
use SilverStripe\Security\RandomGenerator;
use SilverStripe\UserForms\Model\Submission\SubmittedForm;

/**
 * Class \Firesphere\PartialUserforms\Models\PartialFormSubmission
 *
 * @property boolean $IsSend
 * @property string $TokenSalt
 * @property string $Token
 * @property int $UserDefinedFormID
 * @method DataObject UserDefinedForm()
 * @method DataList|PartialFieldSubmission[] PartialFields()
 * @method DataList|PartialFileFieldSubmission[] PartialUploads()
 */
class PartialFormSubmission extends SubmittedForm
{
    private static $table_name = 'PartialFormSubmission';

Consider using a different property name as you override a private property of the parent class.

    private static $db = [

Consider using a different property name as you override a private property of the parent class.

        'IsSend'    => 'Boolean(false)',
        'TokenSalt' => 'Varchar(16)',
        'Token'     => 'Varchar(16)',
    ];

    private static $has_one = [

Consider using a different property name as you override a private property of the parent class.

        'UserDefinedForm' => DataObject::class
    ];

    private static $has_many = [

Consider using a different property name as you override a private property of the parent class.

        'PartialFields'  => PartialFieldSubmission::class,
        'PartialUploads' => PartialFileFieldSubmission::class
    ];

    private static $cascade_deletes = [

Consider using a different property name as you override a private property of the parent class.

        'PartialFields'
    ];

    /**
     * @var array
     */
    private static $summary_fields = [

Consider using a different property name as you override a private property of the parent class.

        'ID'          => 'ID',
        'PartialLink' => 'Link',
        'Created'     => 'Created',
        'LastEdited'  => 'Last Edited',
    ];

    public function getCMSFields()
    {
        /** @var FieldList $fields */
        $fields = parent::getCMSFields();
        $fields->removeByName([
            'Values',
            'IsSend',
            'PartialFields',
            'TokenSalt',
            'Token',
            'UserDefinedFormID',
            'Submitter',
            'PartialUploads'
        ]);

        $partialFields = $this->PartialFields();
        $fileFields = $this->PartialUploads();
        $list = ArrayList::create();
        $list->merge($partialFields);
        $list->merge($fileFields);

        $partialFields = GridField::create(
            'PartialFields',
            _t(static::class . '.PARTIALFIELDS', 'Partial fields'),
            $list->sort('Created', 'ASC')
        );

        $exportColumns = [
            'Title'       => 'Title',
            'ExportValue' => 'Value'
        ];

        $config = new GridFieldConfig();
        $config->addComponent(new GridFieldDataColumns());
        $config->addComponent(new GridFieldButtonRow('after'));
        $config->addComponent(new GridFieldExportButton('buttons-after-left', $exportColumns));
        $config->addComponent(new GridFieldPrintButton('buttons-after-left'));
        $partialFields->setConfig($config);

        $fields->addFieldsToTab(
            'Root.Main',
            [
                ReadonlyField::create('ReadonlyPartialLink', 'Partial Link', $this->getPartialLink()),
                $partialFields
            ]
        );

        return $fields;
    }

    public function getParent()
    {
        return $this->UserDefinedForm();
    }

    /**
     * @param Member $member
     * @param array $context
     * @return bool
     */
    public function canCreate($member = null, $context = [])
    {
        return false;
    }

    /**
     * @param Member
     *
     * @return boolean|string
     */
    public function canView($member = null)
    {
        if ($this->UserDefinedForm()) {
            return $this->UserDefinedForm()->canView($member);

The expression $this->UserDefinedForm()->canView($member); of type boolean|string adds the type string to the return on line 140 which is incompatible with the return type of the parent method SilverStripe\UserForms\Model\Submission\SubmittedForm::canView of type boolean.

        }

        return parent::canView($member);
    }

    /**
     * @param Member
     *
     * @return boolean|string
     */
    public function canEdit($member = null)
    {
        if ($this->UserDefinedForm()) {
            return $this->UserDefinedForm()->canEdit($member);

The expression $this->UserDefinedForm()->canEdit($member); of type boolean|string adds the type string to the return on line 154 which is incompatible with the return type of the parent method SilverStripe\UserForms\Model\Submission\SubmittedForm::canEdit of type boolean.

        }

        return parent::canEdit($member);
    }

    /**
     * @param Member
     *
     * @return boolean|string
     */
    public function canDelete($member = null)
    {
        if ($this->UserDefinedForm()) {
            return $this->UserDefinedForm()->canDelete($member);

The expression $this->UserDefinedForm()->canDelete($member); of type boolean|string adds the type string to the return on line 168 which is incompatible with the return type of the parent method SilverStripe\UserForms\Model\Submission\SubmittedForm::canDelete of type boolean.

        }

        return parent::canDelete($member);
    }

    /**
     * Get the share link of the form
     *
     * @return string
     * @throws Exception
     */
    public function getPartialLink()
    {
        if (!$this->isInDB()) {
            return '(none)';
        }

        return Controller::join_links(
            Director::absoluteBaseURL(),
            'partial',
            $this->generateKey($this->Token),

It seems like $this->Token can also be of type boolean; however, Firesphere\PartialUserforms\Models\PartialFormSubmission::generateKey() does only seem to accept string, maybe add an additional type check?

            $this->Token
        );
    }

    /**
     * Generate tokens
     * @throws Exception
     */
    protected function onBeforeWrite()
    {
        if (!$this->TokenSalt) {
            $this->TokenSalt = $this->generateToken();
            $this->Token = $this->generateToken();
        }

        parent::onBeforeWrite();
    }

    /**
     * Generate a new token
     *
     * @return bool|string
     * @throws Exception
     */
    protected function generateToken()
    {
        $generator = new RandomGenerator();

        return substr($generator->randomToken('sha256'), 0, 16);
    }

    /**
     * Generate a key based on the share token salt
     *
     * @param string $token
     * @return string|bool
     */
    public function generateKey($token)
    {
        return hash_pbkdf2('sha256', $token, $this->TokenSalt, 1000, 16);
    }

    /**
     * Get all partial fields for loading data into the form
     *
     * @return array
     */
    public function getFields()
    {
        $formFields = $this->PartialFields()->map('Name', 'Value')->toArray();
        $fileFields = $this->PartialUploads()->map('Name', 'FileName')->toArray();

        return array_merge($formFields, $fileFields);
    }

    /**
     * Validate key/token combination
     *
     * @param string $key
     * @param string $token
     * @return bool|PartialFormSubmission
     */
    public static function validateKeyToken($key, $token)
    {
        /** @var PartialFormSubmission $partial */
        $partial = PartialFormSubmission::get()->find('Token', $token);
        if (!$partial ||
            !$partial->UserDefinedFormID ||
            !hash_equals($partial->generateKey($token), $key)
        ) {
            return false;
        }

        return $partial;
    }
}